TradeReport

[renexxxx]

But in addition I´d like to define a profit-limit in currency (for account control), say in the example 20 ($,€) profit to get an pop-up alert or/and an email-message, when the defined profit-limit in summary for the open/active orders has been crossed.

Although it wouldn't be too hard to add this sort of functionality, I am making the point that TradeReport is just that, a Trade Report, not a Trade Monitor. The initial idea was to just report on closed trades. The current profitability of open trades was added at a later stage. If we are now going to send alerts if certain profit targets have been reached, if feel that we are building a different tool. A next request would undoubtedly be, to close these open trades if/when these profit targets have been reached. And then we are talking about a Trade Manager. Of course you can bang a nail in the wall with a pair of pliers, but I'd think that a hammer would be easier.

So, I am going ahead and resist this change request.

[SteveHopwood]

But in addition I´d like to define a profit-limit in currency (for account control), say in the example 20 ($,€) profit to get an pop-up alert or/and an email-message, when the defined profit-limit in summary for the open/active orders has been crossed.

Although it wouldn't be too hard to add this sort of functionality, I am making the point that TradeReport is just that, a Trade Report, not a Trade Monitor. The initial idea was to just report on closed trades. The current profitability of open trades was added at a later stage. If we are now going to send alerts if certain profit targets have been reached, if feel that we are building a different tool. A next request would undoubtedly be, to close these open trades if/when these profit targets have been reached. And then we are talking about a Trade Manager. Of course you can bang a nail in the wall with a pair of pliers, but I'd think that a hammer would be easier.

So, I am going ahead and resist this change request.

Good plan.

Plus, there are probably a fair few half-decent trade managers available here at SHF should Over60 care to go looking for them. Hunting down memory lane throws up distant recollections of MPTM, BPTM, APTM. I am sure they are available here somewhere, if only I could remember where....................................

[xray2]

This is such a nice tool renexxxx. I just wanted to Thank you personally.

[Bruster400]

Thanks this is really a great indicator.

At the moment I'm using it to see my current day trading report. So I change the start day every day.
I'm not a coder but I was trying to change the code so it would take the current day. I was looking in the help file of MetaEditor how I could take the current day as start value. I found I could use TimeCurrent(), but this also takes the current time.
Can somebody give me a push in the right direction or a little help what code to use so StartDate uses the current day at 00.00hr.

I want to change this line:
input datetime StartDate = D'2015.01.01 00:00';

to something like:
input datetime StartDate = TimeCurrent();

But then just take the current day instead of day and time.

Thank you for any help!

Hi,

I was looking for a similar "teensy bit extra" but then I read Steve's earlier posts about mission creep and I decided against it!! Instead I took it as a challenge to my fledgling coding skills to see if I could add this functionality myself.

Now at this point I have to emphasise that I am in awe of the coding skills of Rene and the other coders who make this forum what it is. So, Rene, I fully understand that this is your thread and your indicator so please feel free to delete this post and keep the indi how you intended it. If you actually think it's a worthwhile addition and you want to incorporate it at some point in the future then hopefully I've saved you a little time. It's only code that would take you minutes to knock out but I thought it best to share it rather than ask you to do it.

TradeReport (1).mq4

[renexxxx]

Hi,

I was looking for a similar "teensy bit extra" but then I read Steve's earlier posts about mission creep and I decided against it!! Instead I took it as a challenge to my fledgling coding skills to see if I could add this functionality myself.

Now at this point I have to emphasise that I am in awe of the coding skills of Rene and the other coders who make this forum what it is. So, Rene, I fully understand that this is your thread and your indicator so please feel free to delete this post and keep the indi how you intended it. If you actually think it's a worthwhile addition and you want to incorporate it at some point in the future then hopefully I've saved you a little time. It's only code that would take you minutes to knock out but I thought it best to share it rather than ask you to do it.

The easiest way for you to accomplish what you want is to right-click in the Account History tab and select the Custom Period appropriately (eg. select 'Today'). TradeReport can not report on trades that are not listed in the 'Account History'.

[Bruster400]

The easiest way for you to accomplish what you want is to right-click in the Account History tab and select the Custom Period appropriately (eg. select 'Today'). TradeReport can not report on trades that are not listed in the 'Account History'.

Hi Renexxxx,

Thanks for the quick response! Yes, I know that I could change the history tab but I like to have two instances of your indi running, this month and this week and this just stops me having to switch the history between the two to look at where I'm up to. It was as much about challenging my coding and helping out on a request for a change as it was a genuine addition that most people would want. Just trying to contribute where I can.

[renexxxx]

Hi Renexxxx,

Thanks for the quick response! Yes, I know that I could change the history tab but I like to have two instances of your indi running, this month and this week and this just stops me having to switch the history between the two to look at where I'm up to. It was as much about challenging my coding and helping out on a request for a change as it was a genuine addition that most people would want. Just trying to contribute where I can.

I hope that you are aware that you can not run two instances of TradeReport on the same chart, so this would mean that you have two charts running with TradeReport, each with a different date range. By the way, it is not impossible to alter TradeReport so that multiple instances can be run on one chart, but it means giving it x and y offset parameters, making the screen object names unique for each instance and modifying the OnChartEvent() function such that the left mouse click event is mapped to the correct table. There are other things on my mind right now, so I am not going there.

You have not totally convinced me that "most people would want", the date choice selection option to include Today, This Week's and This Month's trades (I don't have that requirement myself for that matter), but I have added the code changes to that effect. Update is in Post 1.

[Bruster400]

Renexxxx,

Thank you again for your quick response and for making these changes - I genuinely wasn't trying to make work for you, so the fact that you've done it makes it all the more generous of you. Just another example of the amazing contribution you make.

Thank you

Bruster

[MurphyMan]

I have been out a lot the last few months and I'm quite late to this party. I just wanted to thank you Renexxxx for this handy tool. You are a gem!

[renexxxx]

There was a bug that prevented you from selecting other screen objects (such as horizontal lines) when TradeReport was running on the chart, as the OnChartEvent() in trade report would capture the mouse-click to these other objects. This has now been fixed.

Update is in Post 1