Shelley's multi-pair basket trader

Share your 10.x automated traders here.
Post Reply
cytek
Trader
Posts: 43
Joined: Wed May 16, 2012 4:31 pm

Re: Shelley's multi-pair basket trader

Post by cytek »

SWG123 wrote:Today's 5-pair basket (opened at 0645GMT) which was 125 pips in the hole early on has just closed with a profit of 81 pips, adding to 99 from yesterday. :D
Sunshine, even when there's rain ;) Well played.

Btw, do you force a close at a particular time?
SWG123
Trader
Posts: 565
Joined: Wed Nov 16, 2011 3:02 pm
Location: Cape Town

Re: Shelley's multi-pair basket trader

Post by SWG123 »

cytek wrote:
SWG123 wrote:Today's 5-pair basket (opened at 0645GMT) which was 125 pips in the hole early on has just closed with a profit of 81 pips, adding to 99 from yesterday. :D
Sunshine, even when there's rain ;) Well played.

Btw, do you force a close at a particular time?
Shelley TP'd automatically in this case. :D
User avatar
droland
Trader
Posts: 52
Joined: Tue Nov 15, 2011 9:40 pm
Location: Vancouver, BC, Canada

Re: Shelley's multi-pair basket trader

Post by droland »

I had two sets of instant closes as well then it worked.

I always force a recompile when I load a new EA. I like to open it and have a quick look at the coding.

I live in Pacific Daylight Time so I set the hour and minute at 22 and 45. It instantly closed all new orders when they opened.

I recompiled and set for 23 and 45. Same thing.

I did nothing but set the hour and min to 00 and 01 and it took the trades at that time.

I do believe there is a logic problem but not sure where.
User avatar
getting
Trader
Posts: 26
Joined: Tue May 01, 2012 3:27 pm
Location: Thailand

Re: Shelley's multi-pair basket trader

Post by getting »

sharing my result from the last 12hrs; opened basket trades based on Myfxbook's calendar for medium and high impact news. AdaptivePipsTakeProfit=4
http://i48.tinypic.com/2vrwzza.png
http://tinyurl.com/d55uy2u
send time:
29.05.2012 03:00
29.05.2012 09:00
29.05.2012 15:00
29.05.2012 17:00
Image
spotdespot
Trader
Posts: 768
Joined: Sun Jan 22, 2012 11:38 pm

Re: Shelley's multi-pair basket trader

Post by spotdespot »

spotdespot wrote:
I have Original and also ShelleyPlusGary both with:

extern int AdaptivePipsTakeProfit=25;//Pips per open trade. A zero input will disable this.
extern int AdaptivePipsStopLoss=40;//Pips per open trade. A zero input will disable this.
extern int AdaptiveBreakEvenProfitPips=10;//Set to zero to disable this function
extern int AdaptiveBreakEvenProfitPipsLock=2;//Pips per open trade. A zero input will disable this.
extern int AdaptiveJumpingStopPips=7;//Zero to disable

Will see how they get on.
Changed AdaptiveJumpingStopPips to = 6 as I didn't realize, until I just ran it then checked the code that AdaptiveBreakEvenProfitLock * number of open trades is added to the starting point for the jumping stop. So for a 5 basket trade with the above original settings BE is hit at 50 pips, and the first jumping stop is hit at 80 pips (10 + 2*35) - so the second wouldn't hit until 115 pips with a 125 pip TP target. By changing to 6 it would be BE+10 at +50 pips, 1st jump at +70pips (40 pips locked), second jump at +100 pips (70 pips locked)......I think :?
garyfritz

Re: Shelley's multi-pair basket trader

Post by garyfritz »

You know, I wonder if the basket approach is the right way to trade the S+G method. Shelley's original idea opened all trades at once, you tracked the whole basket profit, and you closed the whole thing at once when you hit the basket TP or SL. Makes sense.

But with S+G you enter AND exit trades at any time. Steve's code updates the basket TP/SL/BE/etc pips when the # of open trades changes, so that's good. But with independent pair entry/exit, I don't think the basket TP/SL/BE/etc makes much sense any more. E.g. you might have half a dozen pairs enter and exit while you're waiting to hit your basket TP, and those pairs' profits/losses aren't counted in the current PipsUpl. I think each pair's profit & exits have to be tracked separately.

And that probably shouldn't be crammed into Shelley. It's too different from the original behavior and trying to do both would be a mess.
Caillou
Trader
Posts: 48
Joined: Sat Dec 03, 2011 9:11 pm

Re: Shelley's multi-pair basket trader

Post by Caillou »

Finally + 204 pips today running original Shelley. + 391 pips since yesterday. Will move to last version for Woh filter but just with TP and closing at NY close.

Cheers
fxshadow
Trader
Posts: 61
Joined: Tue Nov 15, 2011 11:46 pm

Re: Shelley's multi-pair basket trader

Post by fxshadow »

garyfritz wrote:You know, I wonder if the basket approach is the right way to trade the S+G method. Shelley's original idea opened all trades at once, you tracked the whole basket profit, and you closed the whole thing at once when you hit the basket TP or SL. Makes sense.

But with S+G you enter AND exit trades at any time. Steve's code updates the basket TP/SL/BE/etc pips when the # of open trades changes, so that's good. But with independent pair entry/exit, I don't think the basket TP/SL/BE/etc makes much sense any more. E.g. you might have half a dozen pairs enter and exit while you're waiting to hit your basket TP, and those pairs' profits/losses aren't counted in the current PipsUpl. I think each pair's profit & exits have to be tracked separately.

And that probably shouldn't be crammed into Shelley. It's too different from the original behavior and trying to do both would be a mess.
Gary, I agree.
User avatar
verb
Trader
Posts: 61
Joined: Mon Apr 02, 2012 2:27 am

Re: Shelley's multi-pair basket trader

Post by verb »

The best time to enter the market in a trend is during a retracement. Following this logic, entering at a set hour without considering what state the market is in is for me too risky.

My recommendation, is to turn on the original basket trader when you feel the market has retraced within the trends at a significant level and when liquidity is at the highest.

One way to accomplish the liquidity component is as many have discovered during Frankfurt, London and subsequently NY opens. The next is going to be to wait until the markets have retraced, before forcing the basket trader to trade.

You can edit the code to force the EA to basket trade when you want it.

Find BasketSent in the code and change the line to:
extern bool BasketSent=true;//Set to false if a basket send fails, to force a retry.

Basket trading is really about correlations. If you understand correlations then you will know that the markets are interconnected. So once a currency makes a move, there is a trickle down effect.

The key is to wait until supply comes into the picture on a downtrend and demand takes over in an uptrend. This only happens at the extremes (retracements).

.02
cytek
Trader
Posts: 43
Joined: Wed May 16, 2012 4:31 pm

Re: Shelley's multi-pair basket trader

Post by cytek »

droland wrote:I had two sets of instant closes as well then it worked.

I always force a recompile when I load a new EA. I like to open it and have a quick look at the coding.

I live in Pacific Daylight Time so I set the hour and minute at 22 and 45. It instantly closed all new orders when they opened.

I recompiled and set for 23 and 45. Same thing.

I did nothing but set the hour and min to 00 and 01 and it took the trades at that time.

I do believe there is a logic problem but not sure where.
Refer Foxgirl's earlier post - think she was experiencing similar problems this morning. I think she found a solution.
Post Reply

Return to “10.x EA forum”