MADTrader

[Wavegarrick]

Hi Guys,

It seems Mad trader is starting to wake up from its slumber

Positive results today and hopefully tomorrow some more...

Tc
Leon

[fxstrategie]

I've attached a special version of OrderReliable.mqh, that basically replaces every OrderSend() with the following code...

Let me know if this solves your problem. I guess this involves sending a few live trades at a time when there is no liquidity available at the live server. You may not be keen to do this -- which I fully understand -- but it would be a good test though.

R.

damn - can't get my hands out of fire
Test last night on Broker XM. The behavior is much better, but still opens 2 same orders per Trigger!
Fix work partially - No errors now, but still 2 (instead of 10 or more) orders at the exact same entry and time. Results in 6.6% loss again... Any Ideas Rene?

Unbenannt.PNG

Unbenannt2.PNG

[vectieba]

I've attached a special version of OrderReliable.mqh, that basically replaces every OrderSend() with the following code...

Let me know if this solves your problem. I guess this involves sending a few live trades at a time when there is no liquidity available at the live server. You may not be keen to do this -- which I fully understand -- but it would be a good test though.

R.

damn - can't get my hands out of fire
Test last night on Broker XM. The behavior is much better, but still opens 2 same orders per Trigger!
Fix work partially - No errors now, but still 2 (instead of 10 or more) orders at the exact same entry and time. Results in 6.6% loss again... Any Ideas Rene?

Hi Rene and Fxstrategie

I just seen this post of yours and found it very interesting since I have been having a similar issue with one of my EA's using grid trading.

I have accounts with XM and Tickmill that I have been using to test. I have my EA running on multiple accounts, one Live with XM and a couple of demo accounts with XM and Tickmill.

I have set the EA to not allow trades within 60 seconds of each other but it still opens multiple trades sometimes even when it waits 60 seconds. This has happened on both brokers as well as the live and demo accounts. I thought it might not be saving the variables correctly to determine when the next order needed to be opened so I had it recalculate the variables before opening a new order but it still seemed to be doing this. Still testing that though. It did seem that it was not doing this when I restarted the Empty4 daily. Might be a variable problem, what do you think?

[renexxxx]

Fix work partially - No errors now, but still 2 (instead of 10 or more) orders at the exact same entry and time. Results in 6.6% loss again... Any Ideas Rene?

According to the documentation, the IsTradeAllowed() function checks if the trading context is free -- i.e. the trading context is not used by another EA and trading is allowed. This does not seem to be the problem you are facing.

Your br0ker told you that the initial trade was waiting (at the server) for liquidity to become available. So, I believe this is what happened:

1. Before sending this initial trade, IsTradeAllowed() returned true and the OrderSend() was executed.
2. The order was waiting at the server for liquidity and either the error ERR_SERVER_BUSY or ERR_BROKER_BUSY was returned. (I'm guessing here, as you are only showing the (partial) contents of the Journal-tab, not the Experts-tab).
3. The ERR_SERVER_BUSY or ERROR_BROKER_BUSY errors are both considered by OrderReliable as retryable errors: in other words, once it receives that error from the server, it will retry sending the order again.
4. In the meantime, the first order got filled as the trade server finally found some liquidity.
5. The second order, also got filled, so now you have two market orders.

May be the answer is to stop OrderReliable retrying OrderSend() statements, i.e. set

Code: Select all

int 	   O_R_Setting_max_retries 	= 0;

on line 398. You might sometimes not succeed in sending the order at all, but at least you won't get any doubles.

This seems to be particularly a problem on your br0ker, as I have never experienced anything like this with Global Prime.

Good luck!

[fxstrategie]

According to the documentation, the IsTradeAllowed() function checks if the trading context is free -- i.e. the trading context is not used by another EA and trading is allowed. This does not seem to be the problem you are facing.

Your br0ker told you that the initial trade was waiting (at the server) for liquidity to become available. So, I believe this is what happened:

1. Before sending this initial trade, IsTradeAllowed() returned true and the OrderSend() was executed.
2. The order was waiting at the server for liquidity and either the error ERR_SERVER_BUSY or ERR_BROKER_BUSY was returned. (I'm guessing here, as you are only showing the (partial) contents of the Journal-tab, not the Experts-tab).
3. The ERR_SERVER_BUSY or ERROR_BROKER_BUSY errors are both considered by OrderReliable as retryable errors: in other words, once it receives that error from the server, it will retry sending the order again.
4. In the meantime, the first order got filled as the trade server finally found some liquidity.
5. The second order, also got filled, so now you have two market orders.

May be the answer is to stop OrderReliable retrying OrderSend() statements, i.e. set

Code: Select all

int 	   O_R_Setting_max_retries 	= 0;

on line 398. You might sometimes not succeed in sending the order at all, but at least you won't get any doubles.

This seems to be particularly a problem on your br0ker, as I have never experienced anything like this with Global Prime.

Good luck!

now it seems completly damaged ! Nothing Changed than Line 398...

Opens now hundred of trades within seconds... nearly unstoppable... can only show the errors from experts tab with autotrading disaled now - runs faster than any screen recording tool...

Unbenannt.PNG

Unbenannt2.PNG

Unbenannt3.PNG

[Wavegarrick]

Hi Fxstrat,

I don't know what you are up to, but heck stop the pain you are putting upon yourself Rene has offered a solution and I bet you with painstaking hours of going through the code. You are the master of your own destiny Chap.

At this point I would delete the whole platform and look at opening a new one.

Tc

[vectieba]

I would also suggest testing it again on demo account or maybe a cent account before you continue.

[fxstrategie]

i know... was just a try... Want to avoid the change to global prime for different reasons... but seems that GP is (maybe) the only broker can handle that EA - others from steve, also the fast or gridding ones - work... Cant test on Demo because the initial Error doesnt occur on Demo. Maybe One of my Cent Accounts on Roboforex are an last option for testing that...

[vectieba]

i know... was just a try... Want to avoid the change to global prime for different reasons... but seems that GP is (maybe) the only broker can handle that EA - others from steve, also the fast or gridding ones - work... Cant test on Demo because the initial Error doesnt occur on Demo. Maybe One of my Cent Accounts on Roboforex are an last option for testing that...

XM also has a cent account called the micro account if you want to try that with the same spreads as a standard account. I am not a big fan of RoboForex spreads.

[renexxxx]

now it seems completly damaged ! Nothing Changed than Line 398...

I noticed these lines in your Expert-log:

Code: Select all

2	18:33:45.329	Expert MADTrader1.1 EURUSD,M5: loaded successfully
2	18:33:45.579	Expert MADTrader1.1 EURUSD,M5: loaded successfully
2	18:33:45.672	Expert MADTrader1.1 USDJPY,M5: loaded successfully
2	18:33:45.783	Expert MADTrader1.1 EURGBP,M5: loaded successfully
2	18:33:45.891	Expert MADTrader1.1 EURAUD,M5: loaded successfully
2	18:33:46.063	Expert MADTrader1.1 EURJPY,M5: loaded successfully
2	18:33:46.235	Expert MADTrader1.1 GBPJPY,M5: loaded successfully
2	18:33:46.407	Expert MADTrader1.1 AUDCAD,M5: loaded successfully
2	18:33:46.625	Expert MADTrader1.1 AUDJPY,M5: loaded successfully
2	18:33:46.860	Expert MADTrader1.1 AUDNZD,M5: loaded successfully
2	18:33:47.126	Expert MADTrader1.1 AUDUSD,M5: loaded successfully
2	18:33:47.376	Expert MADTrader1.1 CADJPY,M5: loaded successfully
2	18:33:47.672	Expert MADTrader1.1 EURCAD,M5: loaded successfully
2	18:33:47.923	Expert MADTrader1.1 EURNZD,M5: loaded successfully
2	18:33:48.141	Expert MADTrader1.1 GBPAUD,M5: loaded successfully
2	18:33:48.344	Expert MADTrader1.1 GBPCAD,M5: loaded successfully
2	18:33:48.563	Expert MADTrader1.1 GBPNZD,M5: loaded successfully
2	18:33:48.766	Expert MADTrader1.1 GBPUSD,M5: loaded successfully
2	18:33:48.860	Expert MADTrader1.1 NZDCAD,M5: loaded successfully
2	18:33:49.032	Expert MADTrader1.1 NZDJPY,M5: loaded successfully
2	18:33:49.157	Expert MADTrader1.1 NZDUSD,M5: loaded successfully
2	18:33:49.297	Expert MADTrader1.1 USDCAD,M5: loaded successfully

So, you have loaded MADTrader1.1 on 22 charts (and twice on EURUSD!).

MADTrader is a multi-symbol EA. So, now you have 22 MADTrader's working in tandem, each working with a multitude of pairs, and each of them acting on MADDY's strength/weakness signals. Do you realise what mess you have created for yourself? Stop trying to find someone or some code to blame for your misfortunes, and take ownership of your own problems. Read, learn and think! This is the best advise I can give you at this time.