Shelley's multi-pair basket trader

[SteveHopwood]

I had two sets of instant closes as well then it worked.

I always force a recompile when I load a new EA. I like to open it and have a quick look at the coding.

I live in Pacific Daylight Time so I set the hour and minute at 22 and 45. It instantly closed all new orders when they opened.

I recompiled and set for 23 and 45. Same thing.

I did nothing but set the hour and min to 00 and 01 and it took the trades at that time.

I do believe there is a logic problem but not sure where.

Just for others having this problem, I discovered the issue. In the OOTB settings, the ComeWhatMayCloseHour is set to 16. If your BasketSendHour setting is between 16 and 24 then all trades will close immediately.

Obviously this should have been adjusted but I overlooked it. It appears that since my London open hour setting is around 22 or 23, this function is of no use to me in its current form so I have set it to 24 to turn it off.

I will have a think about this; there should be a work around, but this requires logic and we all know how logical I am.

[SteveHopwood]

Dear Steve and all traders,
I have noticed today that Shelley sends orders even if the Expert Advisors button 0n Empty4 was not active.
Good to have this function working if possible.
If this issue was discussed previously please point it.
Thanks.

The only way to turn Shelley off is to remove her from the chart.

[SteveHopwood]

Re my previous post, it looks as though Shelley has a good chance of being successful. At some stage, I shall add stop/start buttons; for now, remover her when you want to stop her.

[Zypip]

PS: Shelley is currently making good pips but for me NB 10.2 EA is making even more at the mo

Hi Zypip - would you mind sharing your 10.2 EA set file in the 10.2 EA thread please? Shelley is doing very well for me but 10.2 EA not so well - probably because I have been so impressed with Shelley and manually trading NB 10.2, so the 10.2 EA has been a little unloved!

Thanks,
Dave.

Hi Spotdespot,

I'll post my set file on the NB10.2 thread this evening when I come back from work and will also try to post my results so far.

What I know is that v1u works fine for me and that I was having issues with the v1v.

[SWG123]

Another stonking performance from Shelley today. 6 pairs opened, 400 pips profit, no fuss whatsoever.

[phil_trade]

Dear Steve and all traders,
I have noticed today that Shelley sends orders even if the Expert Advisors button 0n Empty4 was not active.
Good to have this function working if possible.
If this issue was discussed previously please point it.
Thanks.

The only way to turn Shelley off is to remove her from the chart.

Steve

You can just add this line in Start() so we can use the Enabled Expert Button as a Start/Stop EA and aslo acces EA Properties

Code: Select all

int start()
{

   if (OldM1BarTime != iTime(NULL, 1, 0) )
   {
   OldM1BarTime = iTime(NULL, 1, 0);   
   
   int x = 0;
   
   
   while(x == 0)//Start an endless loop
   {
   
      if (IsExpertEnabled() == false) break;

[Armen]

Re my previous post, it looks as though Shelley has a good chance of being successful. At some stage, I shall add stop/start buttons; for now, remover her when you want to stop her.

Thank you Steve. Shelley proved to be successful so far. At least some of the traders put her on a live account. And I am glad to see they are making real money. I hope it will continue this way. But I want to see how it behaves in turning markets. Though, I am confident it will handle that as well.
Cheers,
Armen

[SteveHopwood]

You can just add this line in Start() so we can use the Enabled Expert Button as a Start/Stop EA and aslo acces EA Properties

The only time I tried to use this was a long time ago and it didn't work - I must have put it in the wrong place. It is working now.

V 1n is in post 1, with the Experts button catered for; this is a late addition, just as I was about to post the update.

The guts of the update is for verb. Please read 'Using Shelley as a manual trade manager' in post 1.

[fxozgirl]

I've been a bit busy this week, so haven't had much time to post, but my manual trades finally closed out at 317 pips profit (they were open 3 days, but with minimal drawdown), with a total of 3819 pips since I started trading this system on 8th May.

After some messing about with the Shelley EA I finally have it working correctly with 282 pips profit since yesterday. I think there was 4 trades taken yesterday and 6 today. I am using AdaptiveTakeProfitPips = 25
Tonight I have now added the EA to 3 charts and set it up to open just prior to London, New York & Tokyo sessions just for gigs

I am also having good success with the regular NB 10.2 EA with 586 pips so far this week.

Thanks again to Steve and all the other contributors we are so fortunate to have here.

And to Bob....10.2 ROCKS

[SteveHopwood]

Is their any way to increase the font size of shelly?

No. The comment font size is fixed and there nothing we can do about that.

It seems that the shelly EA daily WoH calculation is not always the same as in my daily charts

This prompted me to add a bit more to post 1, explaining this. Have a look at the 'Chart display' section for details.

Philippe, I just get into a mess when trying to place labels on a chart, when there are a variable number that need placing at variable intervals.

Do you fancy spending a couple of minutes beautifying the pairs display so they go into labels and the user can have a choice of font, size and colour? I bet a fair few people would be grateful. Omitting the pairs that are not >=0.8 or <= -0.8 would free up the space for larger labels.