Shelley's multi-pair basket trader

[michaelhryu]

I updated Shelley to v1r. It opened trades OK, but tades would close within a few seconds. I played with Basket send/close hour settings, but haven't been able to figure out how? Earlier virsion worked alright, though. I am on FXDD demo. Since the EA opens trades at the set time, I gues I know how to set the BasketSendHour, etc.

I'd appreciate if you could guide me how to fix my problem, please.

Have you tried to compile the EA and/or closed re-opened Empty4? Sometimes, I find that the ex4 doesn't come out automatically and we need to compile it. Give it a try and let us know.

Thank you very much for your suggestion!

As suggsted, I compiled the EA and closed & reoped Empty4 just now. But the same thing happened. My local (computer) time is GMT-7 (Pacific Standard Time). So, I set BasketSendHour to 23:15 accordingly. The EA opened the trades and the opened trades closed within 1-2 seconds as before. Where else should I adjust, just to see the EA works properly on my platform (FXDD demo), please?

[mobthehop]

As I posted earlier - I have the same issue of opening / immediate closing and have done all steps not once but three times on different providers demos.....

Mop

[michaelhryu]

As I posted earlier - I have the same issue of opening / immediate closing and have done all steps not once but three times on different providers demos.....

Mop

Now, my problem is which version is the last version that worked properly on my Empty4. I think I've looked everywhere to figure out why, with my limited knowledge/experience on the EA's settings, etc.

By the way, I found this message on "Expers": Shelley XAUUSD. Daily (my Empty4 chart with the EA on it): shutdown by time. What does this mean, please?

[harry45]

I updated Shelley to v1r. It opened trades OK, but tades would close within a few seconds. I played with Basket send/close hour settings, but haven't been able to figure out how? Earlier virsion worked alright, though. I am on FXDD demo. Since the EA opens trades at the set time, I gues I know how to set the BasketSendHour, etc.

I'd appreciate if you could guide me how to fix my problem, please.

Have you tried to compile the EA and/or closed re-opened Empty4? Sometimes, I find that the ex4 doesn't come out automatically and we need to compile it. Give it a try and let us know.

Thank you very much for your suggestion!

As suggsted, I compiled the EA and closed & reoped Empty4 just now. But the same thing happened. My local (computer) time is GMT-7 (Pacific Standard Time). So, I set BasketSendHour to 23:15 accordingly. The EA opened the trades and the opened trades closed within 1-2 seconds as before. Where else should I adjust, just to see the EA works properly on my platform (FXDD demo), please?

Please check "ComeWhatMayCloseHour"-it should be >23.
Regards

[SteveHopwood]

Looks as though there is a problem with KeepAliveHours. My basket just closed again, at a tiny loss.

[SteveHopwood]

I have spotted it. For now, turn off KeepAliveHours (set to zero) and use a high setting for ComeWhatMayCloseHour

Those of you who can, go to bool HasTradeLifeExpired() and change
if (TimeCurrent() >= OrderOpenTime() + (KeepAliveHours * 60) )

to

if (TimeCurrent() >= OrderOpenTime() + (KeepAliveHours * 3600) )

then recompile, and drag a fresh instance of S onto the chart and do the setfile thingy.

Fix coming uip.

[michaelhryu]

Please check "ComeWhatMayCloseHour"-it should be >23.
Regards

Sure enough, when I set "ComeWhatMayCloseHour" to "24", everything seemed OK. Now Shelley trades are alive & going strong.

Thanks a million! You saved my day (night, in fact).

[vivaldi]

I updated Shelley to v1r. It opened accordingly. The EA opened the trades and the opened trades closed within 1-2 seconds as before. Where else should I adjust, just to see the EA works properly on my platform (FXDD demo), please?

There is a variable :
extern int ComeWhatMayCloseHour=16;//Set to > 23 to disable.
set it to 24

Perhaps 24 could be made the default in a next version. I see, that in version _s it is still at 16.

Vivaldi

[SteveHopwood]

V 1s is in post 1, with the KeepAliveHours bug fix. The formula I used resulted in S waiting for KeepAliveHours minutes, not hours.

Depending on your combo if inputs, this bug may not have affected you. It is a biggie, and you are bound to forget and wonder what is wrong when you decide to try out KeepAliveHours, so the re-download is essential.

[fxozgirl]

Wow, great post Shelley. I'm guessing a lot of people here have been battered and bruised by the forex market and are now having difficulty accepting that new-found success is going to last.

I completely understand this...I have my own battle scars as well.