Not all control paths return a value - advice please

[Nufty]

Hi

Its been a few years since I looked at coding, and I thought I would start fresh. It began well too, fixed most errors in a simple EA (not one to trade.. just learning) but I am stuck on this error

Code: Select all

//My logic to determine if we can trade
//+------------------------------------------------------------------+
int logic()
{
      // Long signal 
      if ((Open[3] < Close[3]) && (Open[2] < Close[2]) && (Open[1] < Close[1]) && (Open[0] > Close[1]))
      {

      return(1);

      }

 else
   
      // Short signal 
      if ((Open[3] > Close[3]) && (Open[2] > Close[2]) && (Open[1] > Close[1]) && (Open[0] < Close[1]))

         {
         return(0);

         }
         else Print("ERROR");

}

For the life of me , I cant see my failings.

Any advice is appreciated

Thanks
Nufty

[mejayusa]

The compiler is complaining because in the primary else block the code will return a value only if a specific condition is met. Compiler doesn't know how the code will behave at runtime and is trying to tell you that your method might not return a value if it goes into the second else statement.

[SteveHopwood]

Here is an example of what mejayusa is saying, in a function I coded earlier. Never mind what its' function is:

Code: Select all

int GetTypeIndex(int ticket)
{
   //Returns the levelsIndex of the trade, calculated from its OrderComment()
   
   //Just in case
   if (!OrderSelect(ticket, SELECT_BY_TICKET, MODE_HISTORY))
      return(-1);

   string comment = OrderComment();
   
   for (int cc = 0; cc <= ArraySize(tradeComments) - 1; cc++)
   {
      if (StringFind(OrderComment(), tradeComments[cc], 0) > -1)
      return(cc);
   }//for (int cc = 0; cc <= ArraySize(tradeComments) - 1; cc++)
   
   

   //Something is wrong
   return(-1);
   
}//int GetTypeIndex(int ticket)

The compiler will whinge if I remove the return(-1); at the end of the function, because the earlier loop might not find what it is looking for and so not return anything.

Always include a final default return whenever you code a function that is not a void function.

[Nufty]

Thank you mejayusa and Steve for your replies

Having another go now

Regards

Nufty

[Nufty]

It compiled

I think thats my first ever

Thanks again

Now... to code something I actually think might work

[SteveHopwood]