Peaky on Steroids

[SteveHopwood]

Here is a great example of why a ranging market is so good for us when using thomasmoor's 4 pip TP on the M1:

AUDUSDM1.png

This is back at the start of the week so you cannot see the peak low lines, but you can clearly see where they would have been. That is 5 trades within about 9 hours. Nice.

[1Direction]

V 1d is in post 1.

I had coded for there to be both buy and sell trades open on the same chart and for Recovery to apply independently to both groups, but not allowed PoS to open a new sell position when there are already buy(s) open and vice versa. This is fixed in 1d.

These are simple DIY fixes.

Do a search for:
if (MarginCheck() )

The line of code straight after that is:
if (OpenTrades == 0)

Comment it out so that it is greyed out, or delete it altogether:
//if (OpenTrades == 0)

Then do a search for:
//Look for a sell.

You will find it high up in void LookForTradingOpportunities(string symbol, int cc). You will also see a block of code starting with this comment:
//Look for a buy.

Copy this over the top of the existing code:

Code: Select all

   //Look for a sell.
   if (MarketSellsCount == 0)//LookForTradingOpportunities() is for the starting trade only
      if (MarketDirection[cc] == shortdirection) //Market must be falling from a PH.
         if (SixthsTradingStatus[cc] == tradableshort)//And must be in the trading area.
            if (TradeShort)//User can control the trading direction
               if (!PositiveSwapOnly[cc] || shortSwap > 0)
                  if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' is allowed or there are no market buys open. See note below.
                  {
                     SendShort = true;
                  }//if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' ios allowed or there are no market buys open. See note below.
               
   //Look for a buy.
   if (MarketBuysCount == 0)//LookForTradingOpportunities() is for the starting trade only
      if (!PositiveSwapOnly[cc] || longSwap >= 0)   
         if (MarketDirection[cc] == longdirection) //Market must be rising from a PL.
            if (SixthsTradingStatus[cc] == tradablelong)//And must be in the trading area.
               if (TradeLong)//User can control the trading direction
                  if (!PositiveSwapOnly[cc] || longSwap > 0)
                     if (BrokerAllowsHedging || MarketSellsCount == 0)//Either 'hedging' is allowed or there are no market buys open. See note below.
                     {
                        SendLong = true;
                     }//if (BrokerAllowsHedging || MarketBuysCount == 0)//Either 'hedging' ios allowed or there are no market buys open. See note below.

The lines of code added to these blocks are:
if (MarketSellsCount == 0)//LookForTradingOpportunities() is for the starting trade only
and
if (MarketBuysCount == 0)//LookForTradingOpportunities() is for the starting trade only

Now, when a group of, say, buy trades has not been closed out, PoS can take sell trades as well. We profit on the way up and we profit on the way down.

We were on version 1o for PoS (1c for Awsome) if I record correctly we go now back to 1d for this new version, not that it change anything just cosmetic.

Cheers

[xphoton]

I am using the M1 set with 4pips TP, but sell trades closed before hitting TP.
The reason maybe as bellow:
In LookForTradeClosure,

Code: Select all

   if (OrderType() == OP_SELL || OrderType() == OP_SELLSTOP)
   {
      //TP
      if (bid <= OrderTakeProfit() )
         if (!CloseEnough(OrderTakeProfit(), 0) ) 
            CloseThisTrade = true;
      //SL
      if (bid >= OrderStopLoss() ) 
         if (!CloseEnough(OrderStopLoss(), 0) ) 
            CloseThisTrade = true;

When closing sell trades, the price should be Ask?
I change bid to ask and it works on the way now.

[SteveHopwood]

I am using the M1 set with 4pips TP, but sell trades closed before hitting TP.
The reason maybe as bellow:
In LookForTradeClosure,

Code: Select all

   if (OrderType() == OP_SELL || OrderType() == OP_SELLSTOP)
   {
      //TP
      if (bid <= OrderTakeProfit() )
         if (!CloseEnough(OrderTakeProfit(), 0) ) 
            CloseThisTrade = true;
      //SL
      if (bid >= OrderStopLoss() ) 
         if (!CloseEnough(OrderStopLoss(), 0) ) 
            CloseThisTrade = true;

When closing sell trades, the price should be Ask?
I change bid to ask and it works on the way now.

Nice spot. Thanks.

I will put up a fix in time for the markets opening after the weekend - I shall hang on in case anything else crops up.

Easy DIY. Go to lines 1635 and 1639 and replace 'bid' with 'ask'.

[SteveHopwood]

A tip for when loading PoS and Awesome, or when recompiling after editing the code: check the Experts tab for an error message about not being able to start the timer. The bot will be stuck with the "Initialising. Please Wait." message on the chart. You have to drag the bot onto the chart again.

[Gertje]

Last week PoS started slowly, closing some trades and recovery trades like intended.
Then on wednesdaymorning, Asian session, the NZD move made the equity jump had PoS closed all and every trade for 1,24% profit. I had the trade1, trade2 basket TP set at 1%, and the global basket set at 10%, so I'm not sure why PoS cleared the board, could have been a spike the touched the 10% level.
While doing so, it closed a lot of trades that would have hit their TP later in the week.
I have changed the trade1-, trade2-, and global basket TP to a higher percentage, because the singular trades can de better on their own.
After wednesday, no traded closed, PoS (H1 and H4) needs some time to build up her portfolio.

IMG_0379.PNG

The losing pairs that show red were closed during the global basket close, together with a bunch of winning trades.

Still appr. 6% a week after 4 weeks.

[SteveHopwood]

V 1e with the fix we discussed a few posts ago is in post 1. Most of you should have fixed your version yourselves, so consider yourself a wimp if you need the download and are not a new visitor here.

[Kopan]

V 1e with the fix we discussed a few posts ago is in post 1. Most of you should have fixed your version yourselves, so consider yourself a wimp if you need the download and are not a new visitor here.

FYI: If anyone is still playing with or testing Peaky/Peaky FIFO ---> same DIY fix required for both of those EAs as well.

[SteveHopwood]

V 1e with the fix we discussed a few posts ago is in post 1. Most of you should have fixed your version yourselves, so consider yourself a wimp if you need the download and are not a new visitor here.

FYI: If anyone is still playing with or testing Peaky/Peaky FIFO ---> same DIY fix required for both of those EAs as well.

Nice one Kopan. I have posted a fix.

[szfxtrader]

Hi, what does it mean the array out of arrange (1622,30)? Thanks a lot for the help!