ShelleyJem. Fantastic collision of accident and analysis

[SteveHopwood]

2. Look at Baluda 4H. Trend must match #1 (ie; short audusd = aud must be above usd)
I'm going to spend next week playing with this and I'll get back to you. have a great weekend guys, this week has been monumental for my trading with 10.2, I've learned a lot of lessons!

I looked at this briefly last night and yes, it looks really promising. I noticed, unsurprisingly, that best results were to be gained when the two strengths were diverging. They can be going in the same direction on the graph, so long as the gap is widening.

I also tried 10.1 and it looked to me as though this made the situation clearer as the market appeared to stay on the desired side of the MA for longer. I was only looking at GChf and only briefly, so this may be illusory, but it might be worthwhile playing with the moving average as well.

[SteveHopwood]

Note that the fix for the jumping stop stuff has itself caused a problem.

I did the fix on my trading machine instead of my coding machine because my trading machine is super-fast and my coding machine is a slug that takes 20 minutes to wake up in the morning.

I had forgotten to download the latest onto my trading machine, so the 'fixed' version lacks the second Tma timeframe input. I shall fix all this when The Slug wakes up.

Were I to print the language I am using right now, I would probably be banned from my own forum.

Back in about 20 minutes.

[SteveHopwood]

Fixed fix in post 1 - V 1e.

Or is that the fixed fixed fix?

Coders, cast your eye over this and see if it looks right to cover all possible eventualities. It looks ok to me but requires me to be logical, and I am not in the mood. Plus, this is CtapTBloody4 allied to CrapMqlBloody4 and the combination is lethal.

Code: Select all

double BrokerPoint(string symbol)
{
    //Returns Point for the symbol. Necessary because MarketInfo(symbol,MODE_POINT) sometimes returns zero.
    int digits = MarketInfo(symbol,MODE_DIGITS);
    double point              = 0.1;
    if (digits == 2)    point = 0.01;
    if (digits == 3)    point = 0.001;
    if (digits == 4)    point = 0.0001;
    if (digits == 5)    point = 0.00001;
    if (digits == 6)    point = 0.000001;//Apparently there are some of these around and people are 
                                        //stupid enough to trade with them. Leaves me speechless.
    
    return(point);
}//End double BrokerPoint(string symbol)

Boy-oh-boy but I am in a bad mood this morning. Blame the weather.

[Zypip]

I just love the SJ EA. Why? one reason is that it incorporates the fondations of two huge trading mentors, NB and Alorente from FF. I have been following his Al's extreme TMA system from the start and have been unfaithfull to him since I got hooked by Steve's forum.

Anyway, I think we shouldn't complicate the SJ system too much (even if the aim is to improve it) because we greatly increase the risk for bugs creeping in. If we can manage to make the SJ EA in its current version work without glitches it will already be an outstanding achievement

I thought I knew the NB 10.2 and Extreme TMA systems rather well but I was not able to bring these 2 together.......well Jemook did it for us! nice brain connections mate

[phil_trade]

Fixed fix in post 1 - V 1e.

Or is that the fixed fixed fix?

Coders, cast your eye over this and see if it looks right to cover all possible eventualities. It looks ok to me but requires me to be logical, and I am not in the mood. Plus, this is CtapTBloody4 allied to CrapMqlBloody4 and the combination is lethal.

Code: Select all

double BrokerPoint(string symbol)
{
    //Returns Point for the symbol. Necessary because MarketInfo(symbol,MODE_POINT) sometimes returns zero.
    int digits = MarketInfo(symbol,MODE_DIGITS);
    double point              = 0.1;
    if (digits == 2)    point = 0.01;
    if (digits == 3)    point = 0.001;
    if (digits == 4)    point = 0.0001;
    if (digits == 5)    point = 0.00001;
    if (digits == 6)    point = 0.000001;//Apparently there are some of these around and people are 
                                        //stupid enough to trade with them. Leaves me speechless.
    
    return(point);
}//End double BrokerPoint(string symbol)

Boy-oh-boy but I am in a bad mood this morning. Blame the weather.

Hi Steve

there are 2 functions in TMAtrue indicator from Bob that can be use

Code: Select all

//+------------------------------------------------------------------+
//| convert to points                                                |
//+------------------------------------------------------------------+
double Convert_2_Pts(double pd_Pips)
  {
//----
   int pd_Points=pd_Pips;  // Default - no conversion
   
 	if (Digits == 5 || (Digits == 3 && StringFind(Symbol(), "JPY") != -1)) 
 	   pd_Points=pd_Pips*10;
 	   
 	if (Digits == 6 || (Digits == 4 && StringFind(Symbol(), "JPY") != -1)) 
 	   pd_Points=pd_Pips*100;
//----
   return(pd_Points);
  }
//+------------------------------------------------------------------+
//| convert to pips                                                  |
//+------------------------------------------------------------------+
double Convert_2_Pips(double pd_Points)
  {
//----
   double pd_Pips=pd_Points/Point;  // Default - no conversion
   
 	if (Digits == 5 || (Digits == 3 && StringFind(Symbol(), "JPY") != -1)) 
 	   {
 	   pd_Pips=pd_Points/Point/10;
 	   }
 	   
 	if (Digits == 6 || (Digits == 4 && StringFind(Symbol(), "JPY") != -1)) 
 	   {
 	   pd_Pips=pd_Points/Point/100;
 	   }
//----
   return(pd_Pips);
  }

There is also very good broker like MIG BANK who have 5 digits but some pairs with 4 digits (GBPCHF)

[phil_trade]

I have modify TMA TRUE 2.1 indicator so we can chose TimeFrame. So one can have on one graph H4 TF and H1 TF to check Jemook TMA Hit.

[SteveHopwood]

I have modify TMA TRUE 2.1 indicator so we can chose TimeFrame. So one can have on one graph H4 TF and H1 TF to check Jemook TMA Hit.

Nice one Philippe. I have linked this in post 1 to ensure it does not get lost. Once you are happy that it is finished, I will upload it there so it is easy to find.

[SteveHopwood]

V 1f in post 1.

A single variable needs resetting when a basket is closed by a jumping stop or tp. At the mo, SJ thinks she still has an x pips jumping stop, fires a basket, then closes it again because the basket upl is < the jumping stop. Well-behaved little bot, is our SJ. Does as she is told every time.

Those of you who can, only need to add one line of code. Go to int start() at the end of the code and find this block:

Code: Select all

      CountOpenTrades();
      if (OpenTrades == 0)
      {
         BreakevenAchieved = false;
         JslPips = 0;
         GlobalVariableDel(PipsTpGvName);
         GlobalVariableDel(CashTpGvName);
         CloseNeeded = false;
     }//if (OpenTrades == 0)

and insert the extra line. Shut down and re-start your platform without re-compiling to save your current settings.

Code: Select all

      CountOpenTrades();
      if (OpenTrades == 0)
      {
         BreakevenAchieved = false;
         JslPips = 0;
         GlobalVariableDel(PipsTpGvName);
         GlobalVariableDel(CashTpGvName);
         CloseNeeded = false;
         JslPips = 0;/////////////////////////////////////////////EXTRA LINE
      }//if (OpenTrades == 0)

[Mike]

Strange....
Report on undesired closure pattern of SJ
ShelleyJem 1a ootb, 2 pairs basket trade in profit. no other trading activity.
During a pullback the basket reaches the locked pips-SL managed by the bot and
1. Empty4 opens two pairs, the same as there are already in the basket.
2. the now 4 pairs basket closes within secons after #1
I attach two files, the first during the trade this morning, the second after closure of the basket.

[alex_forex]

There are 2 attachments in post 1 Steve