Holy Graily Bob 'n Dotty 'n Super Slope 'n Flying Buddha

Post by **isabek** » Wed Sep 13, 2017 11:03 am

Tried using multi-trade without grids and else, found strange behavior. Expert does not open new trades after first.

Added next code to OnInit()

Code: Select all

MinimumDistanceBetweenSignals = MinimumDistanceBetweenSignalsPips;

Changed this code in ReadIndicatorValues() line 813

Code: Select all

      //We need to check that the market is sufficient distance from the highest/lowest open trade
      if (OpenTrades > 0)
      {
         //Buy signal. Market must be above the highest open buy price or below the lowest.
         if (FbStatus == fbuparrowtradable)
            if (Bid <= HighestBuyPrice + (MinimumDistanceBetweenSignals / factor) || 
                Bid >= LowestBuyPrice - (MinimumDistanceBetweenSignals / factor) )
                  FbStatus = fbuparrowuntradable;
         
         //Sell signal. Market must be above the lowest open sell price or above the highest.
         if (FbStatus == fbdownarrowtradable)
            if (Bid >= LowestSellPrice - (MinimumDistanceBetweenSignals / factor) || 
                Bid <= HighestSellPrice + (MinimumDistanceBetweenSignals / factor) )
                  FbStatus = fbdownarrowuntradable;
                  
      }//if (OpenTrades > 0)

to

Code: Select all

      //We need to check that the market is sufficient distance from the highest/lowest open trade
      if (OpenTrades > 0)
      {
         //Buy signal. Market must be above the highest open buy price or below the lowest.
         if (FbStatus == fbuparrowtradable)
            if ( (Bid <= HighestBuyPrice + (MinimumDistanceBetweenSignals / factor) && Bid > HighestBuyPrice) || 
                 (Bid >= LowestBuyPrice - (MinimumDistanceBetweenSignals / factor) && Bid < LowestBuyPrice) )
                  FbStatus = fbuparrowuntradable;
         //Sell signal. Market must be above the lowest open sell price or above the highest.
         if (FbStatus == fbdownarrowtradable)
            if ( (Bid >= LowestSellPrice - (MinimumDistanceBetweenSignals / factor) && Bid < LowestSellPrice) || 
                 (Bid <= HighestSellPrice + (MinimumDistanceBetweenSignals / factor) && Bid > HighestSellPrice) )
                  FbStatus = fbdownarrowuntradable;
      }//if (OpenTrades > 0)

So market price should NOT be between highest/lowest open trade and highest/lowest open trade +/- distance in pips

Post by **SteveHopwood** » Wed Sep 13, 2017 3:38 pm

isabek » Wed Sep 13, 2017 11:03 am wrote:Tried using multi-trade without grids and else, found strange behavior. Expert does not open new trades after first.

Added next code to OnInit() etc

Thanks for spotting all that.

That MinimumDistanceBetweenSignals thingy was an oversight. I am guessing it was not an issue before because people were not using multi-trade without grids, so the bloop did not surface - or they tried it, found it did not work and abandoned it.

I have added the fixes to V 1g in post 1.

Whilst updating the EA, I also updated the core library with Thomas' enhanced display code. I have removed the abortive DIAD stuff as well.

Post by **cozybooks** » Thu Sep 14, 2017 9:15 pm

Well that's interesting... I'll apply my modded version to Steve's update. I definitely had cases where I had multiple trades open for the same pair at the same time, although never more than two. There were certainly other cases where I wondered why a second trade didn't open, because it looked like the all of the requirements were filled for it to do so, but I blamed the wacky U.S. broker Ally Investments.

I'll keep everyone appraised on whether it makes a big difference on the trades and profit/loss I record on the live version.

Thanks for the update!

Post by **cozybooks** » Mon Sep 18, 2017 1:20 am

Trading in the Middle - I've applied Steve's latest modifications to my version, which doesn't close on opposite trades and has a couple of additional small changes to the original. I'm curious to see how it changes things this week.

Last week I left about 60 million pips on the table when I closed my GBPJPY buy trade the night before the BOE event. I was up about 25 pips on the trade at the time and thought this was a 50-50 crap shoot, so I closed that trade and then closed the week.

Net for last week was + $ 12.08 on just nine trades. Now up $ 98.22 on my $1,000 live account (two $500 U.S. accounts).

Happy Trading this week!

Post by **cozybooks** » Mon Sep 18, 2017 1:30 am

BTW, I'm now using two other live accounts to run trading in the middle on a 4-Hour TF, using Weekly Super Slope as a higher TF filter with settings of 4-50. Running this on just eight pairs right now, so I'll see how it goes. I'm anticipating leaving these trades on their own more, but I've said that before...

Post by **SteveHopwood** » Mon Sep 18, 2017 9:34 am

I'm anticipating leaving these trades on their own more, but I've said that before..

So easy to say. Sooooooooooooo hard to do.

Post by **cozybooks** » Fri Sep 22, 2017 10:52 pm

A dreadful week for trading in the Middle, as I was on the road for work most of the week and just left everything running as AUD dove first in one direction against superslope on the 1-hour charts, and then just as superslope changed color to adjust, AUD went shooting back in the other direction.

The one time I was around to see the wreckage, I closed two EURAUD buy trades (that were down $25), in theory saving some money before they continued on to the respective SL numbers. Ha! Price reversed, of course, and I could have made a few dollars instead of losing $25.00 on those trades.

Numbers for the week are ugly: Minus $ 23.13 in closed trades, minus $ 27.16 in running open trades. We'll see if some of the open trades can make their way back or if they continue on a downward spiral.

In the good news department, my 4-hour trading in the middle live account is up $ 20.47 after one week on eight pairs. Steve, I have survived one week on the 4-hour charts completely hands-off. We'll see if I can keep it up.

More good news --- next week is a new trading week!

Happy Trading!

Post by **SteveHopwood** » Fri Sep 22, 2017 11:26 pm

cozybooks » Fri Sep 22, 2017 10:52 pm wrote:
A dreadful week for trading in the Middle, as I was on the road for work most of the week and just left everything running as AUD dove first in one direction against superslope on the 1-hour charts, and then just as superslope changed color to adjust, AUD went shooting back in the other direction.

I feel your pain.

So do any of the old stagers here. There is not one of us whose utter loathing of, say, stop losses is forged in the white heat of a market taking it out seconds before hurtling back in the direction of our original trade. Ditto manual closures. Especially ditto manual closures. "How could I be so stupid?"

AGAIN?

We are in an agonising position here at SHF. We know we are producing magnificent trading systems and that many of them are morphing into wonderful automated trading bots.

We know that even the best of systems can have losing days. They can have losing weeks. Dammit, they can have losing months.

What we do not yet have are EA's that have moved on from losing days, weeks and months to be magnificently profitable in the longer term. Five years from now will be a different story. We are where we are now and this is the result of many wonderful brains cooperating on the business of becoming profitable Forex traders. Five years from now some successful auto-traders will have emerged as long term successes. Noobs joining the circus will be wondering what all the fuss is about.

I often wonder if there are people out there using some of my bots from my early years who rode out the bad times and are steadily building huge accounts that make in a day what I make in a year.

So hang on in there and keep the experiment going. I can keep churning out the EA's. There is bugger all I can do about testing them all apart from the latest whizz-bangs that has attracted the limited attention span that my modest firing synapses allows me. Being the mechanic is the easy bit. The rest I leave to you guys and all you testers are playing your part, even if your experiments lead nowhere; one day one of you will hit the jackpot.

Post by **cozybooks** » Sat Sep 23, 2017 12:16 am

Steve, you are an never ending phenomenal source of inspiration to all of us!

I'm more convinced than ever that becoming successful long term means accepting the short term losses and downturns if a strategy is a good one. You are right. Day by day, week by week and month by month we are getting closer and closer.

Thanks for the support!

Post by **TraderJoeForex** » Sat Sep 23, 2017 10:26 am

cozybooks » Sat Sep 23, 2017 12:16 am wrote:Steve, you are an never ending phenomenal source of inspiration to all of us!

I'm more convinced than ever that becoming successful long term means accepting the short term losses and downturns if a strategy is a good one. You are right. Day by day, week by week and month by month we are getting closer and closer.

Thanks for the support!

+ 1. Absolutely