ShelleyJem. Fantastic collision of accident and analysis

[Caillou]

The latest version in P1 still has this immediate opening and closing problems. I guess it is a criminal issue. anybody can advise me which criminal I should use to test this gem?

Works perfect in Admiral Markets.....

[kwchau]

The latest version in P1 still has this immediate opening and closing problems. I guess it is a criminal issue. anybody can advise me which criminal I should use to test this gem?

no problem for me with Alpari and HotForex

Look for - bool CriminalIsECN=true; - in the code and if it is set to false, change it to true and see if this fixes the prob...

thanks, will try now.

[SteveHopwood]

Yes, I will try... but why change TF if we have all in one [/quote]
It doesn't retain my colour choice come what may - load the indi onto another chart, shut down and restart the platform, anything.

[/quote]

Steve, I have added 2 params to select colors of chart TF and extra TF[/quote]
Fantastic. Thanks.

[SteveHopwood]

thanks, will try now.

Press the F3 key and delete any global variables you see in that window.

[kwchau]

thanks, will try now.

Press the F3 key and delete any global variables you see in that window.

Done, hope it is fixed. Thank you !

[fxshadow]

The problem is LUC. Gary's fix for one problem created others in the various stop routines.

I have removed the fix and it will stay removed permanently. I do not remember entirely what it was about - something to do with some of the more blatant criminals using a variable Point.

Steve, the problem is in the EA. The error can be worked around with most crims, but cannot with those variable-digit crims -- but it's still wrong with "normal" crims.

The fix I proposed got rid of the fundamental problem -- calculating points when you were supposed to be calculating pips. BUT I think you had already patched around the incorrect point calculation, so once that problem was fixed, it broke your patches.

The way it was before, and presumably is again, was incorrect and IMHO extremely confusing. I remember a lot of people trying to figure out if the EA was using points or pips, which was hard to know because it was using both at different points!!

It is your call of course, but IMHO you would do everyone a favor if you put my fix back in, and then go back through the EA and fix it to properly use pips everywhere. I suspect the Shelley lineage has enough legs that it would be worthwhile to make it work consistently.

It looks like it's working fine on my 5 digit crim.

[fxshadow]

*shrug* Like I said, it's Steve's call. Some of the errors and confusions are internal, in the code, and he's coded around it for the status messages &etc. I suspect it will cause problems in the future if it stays the way it is, but it's his decision. He may choose to leave it alone if it's basically working for most people.

Thanks for making Steve and everybody aware of this. All the work that is going on in this thread is amazing and greatly appreciated.

[Verto]

I am new around this thread/board, but spent a long time working with NB on Forex Factory and sharing ideas.

I just wanted to say thanks to Steve for all the hard work he puts in.

How you are able to do it all, coding like three+ different EAs at a time while you have people constantly changing things or using the EAs when they don't even understand the methodology, is beyond me. You are amazing Steve!

Thank you so much for all your hard work. If you were my employee I would give a bonus and some vacation time. It would be well earned- deserved. You are great at translating all the different ideas us traders have on a daily basis into code quickly.

I believe that without all your hard work the evolution and adaptation of 10.2 would be a much slower process. In the span of... weeks we have gone from original concept to basket trading and tweaking for entries. NB gave us a powerful tool and we were able to quickly convert it into a profitable trading system.

[OldTrader]

boy sure hope gary wasn't banned for trying to help hehe

[phil_trade]

Steve

I think there is a mismatch in ATR parameter

You set xi_ATR.Period = 20 instead of 100 like all i can see in indicator and also in your NB 10.2 EA

Code: Select all

int            xi_Period = 20;//extern input from the indi, hidden from users
int            xi_ATR.Period = 20;//extern input from the indi, hidden from users
double         xd_ATR.Mult = 2.0;//extern input from the indi, hidden from users

should be

Code: Select all

int            xi_Period = 20;//extern input from the indi, hidden from users
int            xi_ATR.Period = 100;//extern input from the indi, hidden from users
double         xd_ATR.Mult = 2.0;//extern input from the indi, hidden from users