ShelleyJem. Fantastic collision of accident and analysis

[Jemook]

Steve, all good with stopping support for SJ. As I said - we are going to crack the Basket Trades EA but not before lots of testing. I'm looking at a combo of the following to trade baskets.

Trend Direction:
a. H4/D1 Currency Slope (converging/diverging/crossing) OR
b. 10.2a Pivots (ordered by Monthly,Weekly,Daily)

High Strength Confirmation:
H4/D1 TMA Slope above .8 / below -.8

Basket Entry (made up of pairs matching the above requirements)
a. Simultaneous pairs of H4 5.1 MA touches OR
b. Simultaneous pairs of 10.2a daily pivot crosses OR
c. Simultaneous pairs of H1 Currency Slope converging/diverging/crossing in direction of H4/D1 trend

Stops/TP
a. Adaptivepips to risk 1:1
b. Mixture of Adaptivepips and jumping stops to lock in 1:1 but also allows for a bigger move.

[garyfritz]

I propose we all agree about one robust and exaustif module to convert pips or deci-pips to point and vice versa. As a majority of criminal are using deci-pips, I suggest that all parameters would have to be in deci-pips -> SL = 500 stand for 50 pips.
and for simplify Steve job (not an Apple joke !), I suggest that user with criminal in pips or centi-pips, just adapt there parameters themself in .set file.

No no no!! I don't think we want points or deci-pips or centi-pips or nano-pips or anything else like that. We want pips, seulement. If the crim uses deci-pips, then we'll get pip values like 12.3, and centi-pips will produce pip values like 12.34.

If we ONLY work in pips, for ALL calculations, then the logic is simple and consistent throughout the EA. The EA (except the PFactor code that scales price to pips) should be blind to the crim's digits and even the pair's scale (JPY vs. non-JPY).

I'm fine with your code, but this line below assume this is with a 5 digits criminals no ?
int PipFactor=10000
may be at least, set a parameter for that 10000 that everyone could adjust to it's criminal ?

No -- 10000 is correct for ALL non-JPY FX pairs, for ALL crims. With a 5-digit crim you might have 0.00123 profit. Multiply times 10000 and you have 12.3 pips profit. With an 11-digit crim (silly example!) you might have 0.00123456789 profit; multiply times 10000 and you have 12.3456789 pips profit.

10000 doesn't refer to the # of crim digits, but to the value of "1 pip." 1 pip is 0.0001 = 1/10000, regardless of crim digits.

[Lifesys]

Thanks Gary. 10000 does not look like 5 dec places to me either. This has nothing to do with how many decimal places, but the fact that a Pip = 100th of a cent & a cent is 100th of a dollar, hence factor = 10000.

On another point, for those who live on the right side of the world realising that Forex week starts with Asia and not London or NY & that NY session straddles 2 days for us, the following code must be added to SetUpSessions() : ConvertedNewYorkClose to ensure that NY session is properly identified.
ConvertedNewYorkClose (Hours) here is less than ConvertedNewYorkOpen (Hours) so the dates moved on a day. The following code brings it back to current session.
[for ShelleyJem-G in SetUpSessions function - approx line 1470, where t = local date/time]

ConvertedNewYorkClose = ConvertedNewYorkClose + (24 * 3600);
}//if (t > ConvertedNewYorkClose)
// added for + GMT regions
if (TimeToStr(t,TIME_MINUTES)<TimeToStr(ConvertedNewYorkClose, TIME_MINUTES) &&
TimeToStr(t,TIME_DATE)<TimeToStr(ConvertedNewYorkClose, TIME_DATE))
{
ConvertedNewYorkOpen -= (24 * 3600);
ConvertedNewYorkClose -= (24 * 3600);
}
}//void SetUpSessions()

[phil_trade]

I propose we all agree about one robust and exaustif module to convert pips or deci-pips to point and vice versa. As a majority of criminal are using deci-pips, I suggest that all parameters would have to be in deci-pips -> SL = 500 stand for 50 pips.
and for simplify Steve job (not an Apple joke !), I suggest that user with criminal in pips or centi-pips, just adapt there parameters themself in .set file.

No no no!! I don't think we want points or deci-pips or centi-pips or nano-pips or anything else like that. We want pips, seulement. If the crim uses deci-pips, then we'll get pip values like 12.3, and centi-pips will produce pip values like 12.34.

If we ONLY work in pips, for ALL calculations, then the logic is simple and consistent throughout the EA. The EA (except the PFactor code that scales price to pips) should be blind to the crim's digits and even the pair's scale (JPY vs. non-JPY).

I'm fine with your code, but this line below assume this is with a 5 digits criminals no ?
int PipFactor=10000
may be at least, set a parameter for that 10000 that everyone could adjust to it's criminal ?

No -- 10000 is correct for ALL non-JPY FX pairs, for ALL crims. With a 5-digit crim you might have 0.00123 profit. Multiply times 10000 and you have 12.3 pips profit. With an 11-digit crim (silly example!) you might have 0.00123456789 profit; multiply times 10000 and you have 12.3456789 pips profit.

10000 doesn't refer to the # of crim digits, but to the value of "1 pip." 1 pip is 0.0001 = 1/10000, regardless of crim digits.

woh woh woh...I JUST propose we all agree about something.... but if you're agree together...that's fine and Steve can say Janet and John... perfect ! we will have a fantastic EA very soon.

[SteveHopwood]

Hey guys. Want the Hoot of the Century?

Gary managed to ban himself earlier.

I think I have un-banned him, so he should re-appear with an embarrassed avatar.

Good thing that having banned himself, he could not then delete all his posts.

What a class act.

[garyfritz]

Steve just wanted to get even with me for my "two syllable words" crack earlier......

[SteveHopwood]

[SteveHopwood]

In Gary's defence, and bearing in mind that I will never let him forget this wonderful episode, he accidentally banned himself whilst banning a spammer. Gary tends to spot these cowboys long before I do; without his vigilance these boards would not always be the pleasant place they are. Gary, we all owe you.

My wife is still giggling, mind, several hours later.

[spotdespot]

Found Gary a new avatar -

What does this button do?

Button.png

[SWG123]

Found Gary a new avatar -

What does this button do?

Button.png

Wonderful