Slopey Peaky Bob

[SteveHopwood]

Hi,

It seems the error message came from the function SendSingleTrade().
That function is called by these other functions:

SendTrendTrade()
LookForTradingOpportunities()
ReadIndicatorValues()
SendBuyGrid()
SendSellGrid()

Since SendTrendTrade()and LookForTradingOpportunities() are using the ask/bid price directly,
and SendBuyGrid() and SendSellGrid() are normalizing the price before calling SendSingleTrade(),
I believe the issue is in ReadIndicatorValues().

Perhaps the fix is to replace line 2129

Code: Select all

 SendPrice = price - (DistanceBetweenTrades / factor); 

with

Code: Select all

 SendPrice = NormalizeDouble(price - (DistanceBetweenTrades / factor),digits); 

and replace line 2169

Code: Select all

 SendPrice = price + (DistanceBetweenTrades / factor); 

with

Code: Select all

SendPrice = NormalizeDouble(price + (DistanceBetweenTrades / factor),digits);

Hope this helps,

- Sherwin

Fabulous spot Sherwin. Thank you very much.

There is the fix in V 1d in post 1. DIYers, you already know how to add the fix.

Here is a lesson for all of us coders. I thought I had identified all opportunities to normalise a double, yet still missed two of them. Here is the lesson: NormalizeDouble every calculation involving a double even when there is absolutely, positively, definitively NO chance of the calculation falling foul of the eighth digit thingy in Empty4. Just Normalize it, OK?

Sherwin, your contribution wins you instant membership of the Grumpy Ole Bastards' group and I welcome you. For all I know, you are a 13 year old coding genius giggling at the lunacy of Empty4 and rewriting it before breakfast in preparation for submitting it for your Doctorate this time next week. If so, give it half a century and you will have joined the rest of us, for sure.

To those of you who have been unaffected by the problems highlighted earlier and are wondering what all the fuss is about: it is better to have accurate coding than inaccurate coding, even if said inaccuracies have not harmed you yet. Just do the re-download, OK?

Now we come to the apology. I rule SHF by fear deliberately. My mods buy into this principle. Not everybody likes this but it serves useful purposes: it stops trolls dead in their tracks; It cuts out bullshit immediately it is posted; it keeps SHF a mine of useful information rather than the morass of pointless dead ends that so many forums lead into.

Occasionally, it leaves me looking a total tit and this is one of them. Wayne, you kindly wrote earlier that grovelling is not needed. I disagree, so here goes:

SilverTrader and nixxx: I deeply, humblingly and grovellingly apologise to both of you for my gratuitous abuse. I hope you can find it in your hearts to forgive me.

[SilverTrader]

Hi Steve

I didn't like the abuse at all, but I understand why you rule as you do and thank you for the apology.

Just on a side note, I do this for a living and have for the past 15 years of my life. I obviously take trading very seriously and would not complain without just cause nor without first exhausting every possible issue in my control, unfortunatly I dont code and have no will to learn at almost 60 years of age.

[billv]

Hi Wayne, Steve and Nick

After seeing the fix I went and had a look at my EA and realized that it was also getting errors,
I just hadn't looked in the experts log until now.

Anyway all fixed now, thanks guys.

[woodlands]

Here is SPB on M5 Peaky with 72 bars on chart, HTF SS H1 at 1.4, Target basket £2
One week GP demo 10k, uploaded to Thomas' database

After two weeks

SPB_M5.png

[SteveHopwood]

V 1e is in post 1. kannyjie sent me a pm suggesting there should be a line of code added to one of the functions. This is taken care of elsewhere but it led me to a couple of bloops.

Coders, do a search for, "if (MustObeyFIFO)". Inside the conditional you will see this:
CloseAllTrades(symbol, type);

This would result eventually in a stack overflow as the CloseAllTrades() function is called recursively. For sure, it would not close the basket.

The code should be:
CloseAllTradesFIFO(symbol, type);

Next, do a search for, "ForceWholePositionClosure = true;//Closure succeeded"

This should be:
ForceWholePositionClosure = false;//Closure succeeded

This was a stellar week for SPB and left the account balance doubled from its initial $500 deposit, in 8 weeks. I am going to calculate the Slopey results for last week and post them in the general discussion thread.

[Mark1963]

Hi Steve

I am one of those who sit in the background and read & research. Hence, this is my first post.
I have a GP Account and have been trading for a month now and have made +-USD8K in that period interpreting the CSS indicator (thanks to everyone for that) and placing manual trades with TP's or TSL's.

I loaded SPB V 1d onto my Demo account 2 days ago and started playing with it to try and emulate something similar to my manual strategy. I think I came across bug in the operation.
When i set 'Trailing Stop' on, it works fine on all currencies except JPY. The alert pops up with errors saying 'Invalid Integer' when trying to set TS's.
My logic tells me it it an issue with the reduced number of decimals required by the JPY.

Thanks to you & all on the forum for a really enlightening website.

Mark

[SteveHopwood]

I loaded SPB V 1d onto my Demo account 2 days ago and started playing with it to try and emulate something similar to my manual strategy. I think I came across bug in the operation.
When i set 'Trailing Stop' on, it works fine on all currencies except JPY. The alert pops up with errors saying 'Invalid Integer' when trying to set TS's.
My logic tells me it it an issue with the reduced number of decimals required by the JPY.

This has probably not arisen before because most of us are basket trading.

I found a possible cause and have attempted a fix in 1f in post 1. Please let me know if it works.

The update is not relevant to basket traders, but accurate code is always better than inaccurate code, so re-download at some stage anyway. DIYers, do a search for, "//Buile up the position picture of market trades" - note the typo in that Line 2323 in my file.

Scroll down three lines to "pips = CalculateTradeProfitInPips(OrderType());" and insert this directly above:
GetBasics(OrderSymbol() );

void CountTotalsForDisplay() already has this line of code, so no need to add it there.

[traderduke]

Bishop
Steve as bishop said “its rocking” but we have been here before. This time there seems to be a more organized consortium. I hope to join it when I get some distance under this EA but until then here is my small offering.

Bishop I appreciate you mentioning all the changes to the ootb SPB, that’s the next best thing to a set file. I will mention my changes which were changes to your changes or my changes to the ootb, everybody got that, oh hell I’ll attach the set file.

The big item changed was the “GridAtrTimeFrame to 4 Hours”. It keep the grid a little tighter.
There were 4 basket runs with Basket TP of +50. The last basket ran for 26 hours with a bad DD of -50, it got caught on the wrong side of CHFJPY which closed with a loss of -17, but still got back to the Basket TP of +50, it closed just before the NY open on Thursday. I would normally stop for the week but I’ll test till Friday and see what storms we have to navigate.

I don’t know if the 4 hour change is any better than your D1, let me know.

Best of Luck to all
Ray

4-12-2018 1-53-48 PM-SPB-4day run.png

SPB-bishop-pg3-rk-grH4.set

[woodlands]

end week 3, Friday close hour at 20:00 but max loss at -20 so left open DD

SPB_M5_wk3.png

[traderduke]

well this is why I don't normally trade on Fridays or stay open over the weekend but in this case a demo. I'll test the come back ability of my settings. So far 5 closed runs for +251, running open with a loss of -27.

Not a bad week at all & the DD wasn't too bad!

4-14-2018 8-29-48 AM-SPB-5day run-overwkend.png