Desky. TDesk's trading drone.

Post by **c1borg** » Wed Oct 24, 2018 2:21 pm

Same issue but I am on % target hope the feedback helps :hi:

Capture1.png

Capture.PNG

Post by **SteveHopwood** » Wed Oct 24, 2018 9:50 pm

Just to let you know folks, that Brendon (oridsb) has found the problem with the basket closure stuff.

It is located where not many of us would have thought to look.

The morning spent rehearsing The Flatulent Beauty And Her Sodding Beast followed by a matinee then an evening performance leaves me with nothing left to give, so I will sort this out tomorrow.

Solution coming soon.

Post by **pipcruiser** » Thu Oct 25, 2018 6:37 am

Hi there

I can confirm the same issues with USDJPY, XY42 trading, last night Desky opened/closed 28 USDJPY sell trades within 1-2 hrs. - see image. Default settings, GP account.

I disabled USDJPY for now.

Cheers

PC

Vokin » Wed Oct 24, 2018 2:18 pm wrote:Its cool thisMT4.
Now i dont see nothing here, but EA close and open repeatedly USD/JPY.

Post by **SteveHopwood** » Thu Oct 25, 2018 1:29 pm

V 1n is in post 1, with a fix for the global baskets not closing. I realised after Brenden's PM that I was trying to make a single-pair function (CountOpenTrades() ) fulfil the global basket function and that they needed separating.

I know the code works now because Desky just closed the basket after hitting a trailing stop.

I had not intended the TS, so I will add more code to the display function to show the functions that we have enabled.

Re the trades opening and closing thingy, I remind everyone that Desky is TDesk's drone and makes no independent individual trade opening/closing decisions. He relies solely on TDesk's signals, so I am inclined to assume that you have TDesk set up incorrectly.

Having said that, we all know that I make mistakes so I have added some more variable re-sets just in case an un-reset one was causing the problem. If you folks want to take a look to see if you can spot any bloops, these are the variables that deal with opening and closing individual trades and single pair baskets:

Opening trades:
- BuySignal
- SellSignal
Closing trades:
- BuyCloseSignal
- SellCloseSignal
- Dealing with failed trade closures:
  - BuyClosureFailure
  - SellClosureFailure
  - ForceTradeClosure

Post by **Vokin** » Thu Oct 25, 2018 2:02 pm

Steve,
thanks for your work and for the time of your life that you give us for free for all of us.
V.

Post by **SteveHopwood** » Thu Oct 25, 2018 2:05 pm

Vokin » Thu Oct 25, 2018 2:02 pm wrote:Steve,
thanks for your work and for the time of your life that you give us for free for all of us.
V.

You are most welcome.

I forgot to explain that I have added a couple of inputs. From the updated UG:

HighestCashUpl and HighestPipsUpl: these are to help you work out your optimum basket TP. You will see them displayed on your chart when there are trades open. They allow you to reset these values after a platform or EA restart. Remember to reset them to zero after a basket closure.

Post by **SteveHopwood** » Sat Oct 27, 2018 1:01 pm

V 1o is in post 1.

Mauro pointed out to me that the code using ATR to calculate the distance between trades in a grid looked wrong. I had not coded what I intended to code, so this is corrected.

I have added more detail to the chart feedback, showing which functions we have enabled.

I have added shirt protection.

monty · Post by **monty** » Sat Oct 27, 2018 5:24 pm

:hi:

SteveHopwood » Sat Oct 27, 2018 2:01 pm wrote:V 1o is in post 1.

Mauro pointed out to me that the code using ATR to calculate the distance between trades in a grid looked wrong. I had not coded what I intended to code, so this is corrected.

I have added more detail to the chart feedback, showing which functions we have enabled.

I have added shirt protection.

Thank you.

Post by **SteveHopwood** » Sat Oct 27, 2018 6:25 pm

monty » Sat Oct 27, 2018 5:24 pm wrote::hi:

Thank you.

My pleasure.

ace811122 · Post by **ace811122** » Mon Oct 29, 2018 9:22 am

Hi,

I have a problem with trade open and close immediately.

Thanks.
Terence