Desky. TDesk's trading drone.

[c1borg]

Version 1o hasn't made any trades as yet on any of my setups? will check my setfile(s) for any cockups later :youknow:

[ace811122]

yes, i was using version v1o, maybe my setup on demo is too aggressive

[wallywonka]

Version 1o hasn't made any trades as yet on any of my setups? will check my setfile(s) for any cockups later :youknow:

Working fine here, make sure you have adjusted the Monday start hour in the settings.

[c1borg]

Working fine here, make sure you have adjusted the Monday start hour in the settings.

Yes probably me guess ive set something wrong

[SteveHopwood]

V 1p is in post 1.

Desky stopped early this morning after generating an array out of range error. The culprit was a typo. This line:
for (int pairIndex = 0; pairIndex < ArraySize([color=#0000FF]TDeskSignals[/color]); pairIndex++)

should have been:
for (int pairIndex = 0; pairIndex < ArraySize(TDeskSymbols); pairIndex++)

I have added code to reset the basket trailing stop values after a basket closure.

[ace811122]

V 1p is in post 1.

Desky stopped early this morning after generating an array out of range error. The culprit was a typo. This line:
for (int pairIndex = 0; pairIndex < ArraySize([color=#0000FF]TDeskSignals[/color]); pairIndex++)

should have been:
for (int pairIndex = 0; pairIndex < ArraySize(TDeskSymbols); pairIndex++)

I have added code to reset the basket trailing stop values after a basket closure.

Thanks

[lbs48]

Hi.
I have the same problem when I set -- All trades belong to a single basket -- to YES (300 pips).
All pairs with signals open and close immediately.
When set to false, EA working fine.

Hi there

I can confirm the same issues with USDJPY, XY42 trading, last night Desky opened/closed 28 USDJPY sell trades within 1-2 hrs. - see image. Default settings, GP account.

I disabled USDJPY for now.

Cheers

PC

Its cool thisMT4.
Now i dont see nothing here, but EA close and open repeatedly USD/JPY.

[SteveHopwood]

Hi.
I have the same problem when I set -- All trades belong to a single basket -- to YES (300 pips).
All pairs with signals open and close immediately.
When set to false, EA working fine.

Hi there

I can confirm the same issues with USDJPY, XY42 trading, last night Desky opened/closed 28 USDJPY sell trades within 1-2 hrs. - see image. Default settings, GP account.

I disabled USDJPY for now.

Cheers

PC

Its cool thisMT4.
Now i dont see nothing here, but EA close and open repeatedly USD/JPY.

I have not seen this because I am not testing the single pair basket feature. Turn it off for now and I will look at the code.

[SteveHopwood]

V 1q is in post 1. Thomas emailed today with code that provides three stop loss and take profit calculation features for individual trades. You will see that TakeProfitPips and StopLossPips have morphed. From the updated UG:

• Trade exit strategies:
  • TakeProfitValue: your take profit sent with individual trades.
  • StopLossValue: your stop loss sent with individual trades.
  • SLTPCalcMode: Thomas designed this. Desky takes your TakeProfitValue and StopLossValue and offers you three ways to calculate the stops:
    • FixedPips: this treats TakeProfitValue and StopLossValue as though they are 'hard' stop values.
    • PriceFractions: this causes TakeProfitValue and StopLossValue to be treated as fractions of the current price. I cannot explain this as I do not understand it.
    • ATRPercent: his causes TakeProfitValue and StopLossValue to be treated as a percentage of the D1, 14 period ATR.

Re the trades opening and then closing when individual pairs as a basket is enabled, I have no idea why. I did see one variable that needed changing but have no idea if this was the cause. I will spend more time hunting the bug tomorrow.

[SteveHopwood]

V 1r is in post 1.

The good(ish) news is that following my turning on individual basket trading I found several hundred GU trades opened and then closed the following second.

This suggests that one of the trade closure variables is not being reset following a closure. Truth to tell, I am floundering here a bit, so this is what I have done. Do a search for, "//We have got here, so there are no trade closure failures." It is line 4132 in 1r. This block of code follows:

Code: Select all

      //We have got here, so there are no trade closure failures.
      BuyClosureFailure = false;
      SellClosureFailure = false;
      BuySignal = false;
      SellSignal = false;
      BuyCloseSignal = false;
      SellCloseSignal = false;
      ForceWholePositionClosure = false;
      ForceTradeClosure = false;
 

You can see how this code resets all the trade opening and closing variables.

There are three blocks of code that force a retry of trade closures following a failure. In 1r:

• Line 3938 "//In case an entire basket closure failure happened" deals with a failed global position closure.
• Line 4008 "if (UseShirtProtection)" deals with shirt protection at a global level.
• Line 4109 "//Deal with a closure failure" deals with individual trade closure failures and individual pairs as a basket closure failures.

Can any of you guys see anything I have missed?