Desky. TDesk's trading drone.

[cptcherry]

Thanks for fixing the bug Steve, c1borgs addition, i thought was really helpful.
amazing work on Desky!!
Lots of pips since implementing. Just need to keep track of the profitability of each variation I am currently running.

[SteveHopwood]

Folks, this is nothing to do with Desky. Have a read of Jem's latest post at http://www.stevehopwoodforex.com/phpBB3 ... 39#p165939

[c1borg]

Bit of feedback on ver q....

Working brilliantly so far

Capture2.png

but may have found a bug. I have this situation

Capture.PNG

With this setting

Capture1.png

The 2 pending orders with FLAT signals dont seem to be deleted is this the correct behaviour?

[SteveHopwood]

The 2 pending orders with FLAT signals dont seem to be deleted is this the correct behaviour?

Probably. Don't really know. Not had the same position.

[c1borg]

The 2 pending orders with FLAT signals dont seem to be deleted is this the correct behaviour?

Probably. Don't really know. Not had the same position.

Curious as it has now decided to delete some pending trades I will keep an eye on things but very happy many thanks again :hi:

[SteveHopwood]

V 2r is in post 1, in response to c1borg's post in the Confused thread: http://www.stevehopwoodforex.com/phpBB3 ... 32#p166032

The code that deletes pending orders on a FLAT signal was underneath the code that detects a NONE signal and stops Desky from doing anything at all. We do not want that, so I have moved the code higher.

Easy DIY. Do a search for, "//Code to delete pending orders when the signal goes FLAT,". Delete the block of code.

Then do a search for, " //Lot size based on account size" and insert the code block you just deleted, just above the lot calculation block. Your code will look like this:

Code: Select all

      //Code to delete pending orders when the signal goes FLAT,
      //then replace them when the signal turns back to trading.
      DoPendingOrdersDeletionAndReplacement(symbol, signal);
      
      //Lot size based on account size

I will work out an 'orphaned' pending trade function to pick up on anything else like this.

[c1borg]

V 2r is in post 1, in response to c1borg's post in the Confused thread: http://www.stevehopwoodforex.com/phpBB3 ... 32#p166032

The code that deletes pending orders on a FLAT signal was underneath the code that detects a NONE signal and stops Desky from doing anything at all. We do not want that, so I have moved the code higher.

Easy DIY. Do a search for, "//Code to delete pending orders when the signal goes FLAT,". Delete the block of code.

Then do a search for, " //Lot size based on account size" and insert the code block you just deleted, just above the lot calculation block. Your code will look like this:

Code: Select all

      //Code to delete pending orders when the signal goes FLAT,
      //then replace them when the signal turns back to trading.
      DoPendingOrdersDeletionAndReplacement(symbol, signal);
      
      //Lot size based on account size

I will work out an 'orphaned' pending trade function to pick up on anything else like this.

Many thanks again will report back.

[c1borg]

Ok just watching this trade live it placed a pending SELL trade bang on time as far as I could see, then went to a FLAT signal and it hasnt deleted as yet. Could it be my chart is set for 1H and it needs to wait for a new bar or should it delete immediately?

Capture.PNG

Edit:
Looks like the SELL trade was made at the start of the new H1 bar now FLAT 15m old and still there
Edit:
Next bar just begun still FLAT and pending trade refuses to budge

Capture1.png

[SteveHopwood]

V 2s is in post 1.

c1borg solved the conundrum of the non-deleted pending orders. He spotted that I had coded only the grid orders, not those generated when SendPendingTrades is enabled.

Reading another programmers code is hard even when you are used to doing so. Managing it when you are a fledgling coder is just plain bloody marvelous, so well done and thanks, c1borg.

I decided to separate the pending order deletion decisions, so watch your inputs if you download 2s:

• DeletePendingOrdersOnFlatSignal and DeletePendingOrdersOnOppositeSignal are now in the grid section.
• DeletePendingOrderWhenSignalChanges has replaced them in the "Trading styles"; orders will be deleted if the spread widens above acceptable levels.

DIYers, do a search for, "//Pending order deletion following a FLAT or opposite direction signal." Copy this code into your clipboard:

Code: Select all

//Pending order deletion following a FLAT or opposite direction signal.
extern bool    DeletePendingOrdersOnFlatSignal=true;
extern bool    DeletePendingOrdersOnOppositeSignal=true;

Scroll down to the grid section and insert the code you copied just above "extern bool UseAtrForGrid=false;"

Scroll back to the code you copied, delete it and insert,
extern bool DeletePendingOrderWhenSignalChanges=false;

Then find "void DoPendingOrdersDeletionAndReplacement(string symbol, int signal)", go to the end of the function and insert this:

Code: Select all

   //Stop/limit orders sent when SendPendingTrades is enabled
   if (SendPendingTrades)
      if (DeletePendingOrderWhenSignalChanges)
         if (PendingTradesTotal > 0)
         {
            //Long pendings
            if (BuyStopOpen || SellStopOpen)
               if (signal != LONG)
               {
                  DeletePendingOrders(symbol);
                  CountOpenTrades(symbol);         
               }//if (signal != LONG)
               
            //Short pendings
            if (SellStopOpen || SellStopOpen)
               if (signal != SHORT)
               {
                  DeletePendingOrders(symbol);
                  CountOpenTrades(symbol);         
               }//if (signal != LONG)
               
         }//if (PendingTradesTotal > 0)
   

[wallywonka]

V 2s is in post 1.

c1borg solved the conundrum of the non-deleted pending orders. He spotted that I had coded only the grid orders, not those generated when SendPendingTrades is enabled.

Hi Steve, I'm using grid orders and it doesn't appear to be deleting pending orders on opposite or flat signals, both are enabled.