jiva34's BB Stop auto-trader

[SteveHopwood]

Regarding the Indi All Averages, I've found somewhere a newer version with 2 new methods (from the same original author), no clue if that could be useful for you, but better to share it.

The 2 new methods are :

// MA_Method=18: TriMAgen - Triangular Moving Average generalized by J.Ehlers
// MA_Method=19: VWMA - Volume Weighted Moving Average

Thx
Gamma

Cheers. This reminds me I need to put the indi in post 1.

I won't use this one for now, as it has a different name to the one used by the EA, but I will update the code sometime. In the meantime, anyone who wants to use this version in this post, can copy it over the top of the old one, keeping the same old name.

[SteveHopwood]

Hey Steve,

You've probably already seen this, but I have a couple of observations.

In ReadIndicatorValues() you have a "return" statement after testing that SlowUpTrendSignal > -1, which skips the AllAverages test later.

More importantly, perhaps, the exit criteria doesn't use the AllAverages test, so it is possible that even though you have an opposite cross of BBands, if the AA slope doesn't change you set the direction to "none" and then your test in start() doesn't close the open trade.

Does it make sense to add an option to your standard TrendDetectionModule() for UseAATrendDetection() and then handle like you do with the other trend detection options? I'm not sure the AllAverages test has been proven as well as the others in your template, but it might simplify matters. The faster option is probably to just add an AATrend variable and set that separately, but I'm always trying to think in terms of code reuse.

George

Oops. Fixed the 'return' thingy straight off - post 1 as usual.

The rest I will look at later - going out now.

Cheers Geroge - you really are fantastic.

[SteveHopwood]

Latest update in post 1. In light of George's recent comments, this is an essential re-download if you use All/averages.

George, the AA reading does indeed usually lie within TrendDetectionModule(). I removed the module from this EA because I thought it would not be needed. I have left it for now in ReadIndicatorValues() but moved the use of the data to LookForTradingOpportunities(), where it probably belongs.

If you see anything in TrendDetectionModule() that can be improved/streamlined, please sing out. The better this code is, the more reliable will be my shell code for myself and for others using it.

[peterke]

heres a couple more.
rgds

Peter

Regarding the Indi All Averages, I've found somewhere a newer version with 2 new methods (from the same original author), no clue if that could be useful for you, but better to share it.

The 2 new methods are :

// MA_Method=18: TriMAgen - Triangular Moving Average generalized by J.Ehlers
// MA_Method=19: VWMA - Volume Weighted Moving Average

Thx
Gamma

Cheers. This reminds me I need to put the indi in post 1.

I won't use this one for now, as it has a different name to the one used by the EA, but I will update the code sometime. In the meantime, anyone who wants to use this version in this post, can copy it over the top of the old one, keeping the same old name.

[jiva34]

Woohooo looks like you've got it....
it's trading with the aa trend.
Fantastic..
I want to be able to code like you do...
I coded my first script today....

[SteveHopwood]

Woohooo looks like you've got it....
it's trading with the aa trend.
Fantastic..
I want to be able to code like you do...
I coded my first script today....

GoForItGoForItGoForItGoForItGoForItGoForItGoForItGoForItGoForItGoForIt

My first ever mq4 coding was adapting a trade-sending script. Most of those that I use still have an appreciation of the original authour.

We all start somewhere...............................

And, there are a few people here to help you.

[SteveHopwood]

Have fun. Let's see if this baby can sing.

Steve,

It sang quite well today, the first day I have live traded (manual entries) the EA and its mirror off Empty4 and MultiCharts -- DDE data fed for tick chart.

The mirror EA is the one where I changed all OP_BUY to OP_SELL, and all OP_SELL to OP_BUY! Because , when I sat down to trade EURUSD was mostly ranging, and I thought it advisable to trade accordingly and SHORT only.

A small beginning, and an eventual hands-off trading journey ahead.

Heartfelt thanks to Jiva and you.

Khalid

Fantastic. That is a brilliant start.

I nearly took a live GC trade today but chickened out because I was a bar late. Shame, cos the move lasted a decent number of pips. Ah well, there is always the future...................

I second your heartfelt thanks to jiva. This is looking really good.

[greyfox]

I am running the latest version OOTB, loaded All Averages v2.2, changed Crim is ECN to true. It's not taking any trades. Last version was trading like a tart, OOTB. Anyone have a .set file that's working for them? Would like to get this puppy running so I can play with it. I am running it on EU tried 1M and 5M.

[SteveHopwood]

I am running the latest version OOTB, loaded All Averages v2.2, changed Crim is ECN to true. It's not taking any trades. Last version was trading like a tart, OOTB. Anyone have a .set file that's working for them? Would like to get this puppy running so I can play with it. I am running it on EU tried 1M and 5M.

Make sure you still have AA v.2.1 loaded. The bot works with that one.

[hiredwhip]

I am running the latest version OOTB, loaded All Averages v2.2, changed Crim is ECN to true. It's not taking any trades. Last version was trading like a tart, OOTB. Anyone have a .set file that's working for them? Would like to get this puppy running so I can play with it. I am running it on EU tried 1M and 5M.

greyfox,
You need to disable the BB indi and it will work.....Set the AA indi the same as the bot.....As Steve said it needs v2.1 AA indi......

whip