Ghostrider

[Pipstubborn]

Thanks for sharing David.

Pipstubborn

[Maximilian]

First:

for the possible end of such a bad situation.

Second:
Did anybody get a BUY grid even in older versions? I didn´t find any. I already did a fresh Empty4 install but to no avail.
Cheers Maximilian

[Maximilian]

Hi all,
I eventually found the code preventing Ghostie to send a buy grid with my setup. Took me a few days. Sounds obvious if you know how to code and what to look for but well...
Ghostie has a safety feature in the SendBuyGrid function which checks if the takeprofit is higher as the actual price of the stop order, if not it stops trying to send a grid. If you, like me hadn´t set a take profit in first place, no global variable is set as take profit, therefore the BuyGrid function sets the take to 0 and voila here we go: no buy grid.
The same check doesn´t matter in the sellgrid function because well, the price could always go towards zero.
Anyhow I am happy for myself to solve this one, because it was driving me nuts to see Ghostie open sellgrids but not buygrids.
Cheers Maximilian

[SteveHopwood]

Hi all,
I eventually found the code preventing Ghostie to send a buy grid with my setup. Took me a few days. Sounds obvious if you know how to code and what to look for but well...
Ghostie has a safety feature in the SendBuyGrid function which checks if the takeprofit is higher as the actual price of the stop order, if not it stops trying to send a grid. If you, like me hadn´t set a take profit in first place, no global variable is set as take profit, therefore the BuyGrid function sets the take to 0 and voila here we go: no buy grid.
The same check doesn´t matter in the sellgrid function because well, the price could always go towards zero.
Anyhow I am happy for myself to solve this one, because it was driving me nuts to see Ghostie open sellgrids but not buygrids.
Cheers Maximilian

Wonderful stuff Maximilian and thanks again.

This is one of those, "Thingies I did not think of," thingy. I did not think to cater for people sending a grid without a take profit. I will include the fix in the next release.

[Maximilian]

Hey Steve,
I think in the CandleOK function there a parenthesis is missing:

double midPoint = (iHigh(Symbol(),LowerZzTimeFrame, 1) + iLow(Symbol(),LowerZzTimeFrame, 1) / 2);
should be

double midPoint = ((iHigh(Symbol(),LowerZzTimeFrame, 1) + iLow(Symbol(),LowerZzTimeFrame, 1)) / 2);

because of dividing before adding rule (don´t know the English term)

Cheers,
Max

[SteveHopwood]

Hey Steve,
I think in the CandleOK function there a parenthesis is missing:

double midPoint = (iHigh(Symbol(),LowerZzTimeFrame, 1) + iLow(Symbol(),LowerZzTimeFrame, 1) / 2);
should be

double midPoint = ((iHigh(Symbol(),LowerZzTimeFrame, 1) + iLow(Symbol(),LowerZzTimeFrame, 1)) / 2);

because of dividing before adding rule (don´t know the English term)

Cheers,
Max

Thanks again Max. Hugely appreciated. Only someone with a better grasp of maths than I can confirm this but I will add the extra bracket anyway. I am a little surprised I did not do so in the first place - I bracket pretty much everything.

[SteveHopwood]

V 1e is in post 1, with the edits pointed out by Max.

A DIY is simple.

Do a search for:
if (take < price)

Add an extra conditional so that the snippet looks like this:

Code: Select all

      //And another
      if (!CloseEnough(take, 0) )
         if (take < price)
            return;

Then do a search for:
double midPoint = (iHigh(Symbol(),LowerZzTimeFrame, 1) + iLow(Symbol(),LowerZzTimeFrame, 1) / 2);

Add the extra brackets:
double midPoint = ((iHigh(Symbol(),LowerZzTimeFrame, 1) + iLow(Symbol(),LowerZzTimeFrame, 1)) / 2);

[tomele]

... because of dividing before adding rule (don´t know the English term)

Hi Max.

You are absolutely right. One common english term is "operator precedence". A general summary can be found here: https://en.wikipedia.org/wiki/Order_of_operations. For MQ4, it is fully explained here: https://docs.mql4.com/basis/operations/rules.

Stay well and safe.

[Maximilian]

Thanks for the links, Thomas,

Max

[SteveHopwood]

Just making sure you have seen folks, that Thomas has posted TDesk 7.3 along with a full user guide. Usual place: viewtopic.php?p=163522#p163522

Thanks Thomas.