News event monitor EA that closes/disables trading

Post by **renexxxx** » Thu Jul 15, 2021 7:52 am

sureshjit » Wed Jul 14, 2021 8:54 pm wrote:Hi everyone, is anyone else getting the following error in their experts log with this CloseOnNewsEav2.1?

Yes, I got that too and it was caused by a bug in the EasyXml code. Can you test the attached CloseOnNewsEAv2.1.ex4 and let me know if it solves the problem for you. If it does, I will update the source code in Post 1 of this thread.

R.

sureshjit · Post by **sureshjit** » Thu Jul 15, 2021 11:38 am

renexxxx » Thu Jul 15, 2021 5:52 pm wrote:
Yes, I got that too and it was caused by a bug in the EasyXml code. Can you test the attached CloseOnNewsEAv2.1.ex4 and let me know if it solves the problem for you. If it does, I will update the source code in Post 1 of this thread.

R.

Wow thanks for the prompt reply and updated code renexxxx - I admire the professionalism.

I've loaded your update onto my charts and it all seems to be working without any errors in the Experts log. I have monitored the next high impact news for USD and all trades get closed (and Autotrade disabled) before-hand as intended!

Thank you!!

R, S

heart1010 · Post by **heart1010** » Fri Jul 16, 2021 1:57 pm

Thanks renexxxx for the update - in the source you've added the include file "LibFF2.0.mqh" but in your EA "CloseOnNewsEAv2.1.mq4" you include "LibFF2.1.mqh"

Post by **renexxxx** » Fri Jul 16, 2021 10:10 pm

heart1010 » Fri Jul 16, 2021 11:57 pm wrote:... - in the source you've added the include file "LibFF2.0.mqh" but in your EA "CloseOnNewsEAv2.1.mq4" you include "LibFF2.1.mqh"

Good spot!

I have now included LibFF2.1.mqh in the zip-file. Update is in Post 1

Post by **SteveHopwood** » Sun Jul 18, 2021 10:15 pm

Kaelrick » Sun Jul 18, 2021 10:59 am wrote:(I want to prevent the program to close brutally all trades especially if we use martingal EA).

As always, it is entirely up to Rene how he responds to the generality of your post.

For now, you clearly show that you have no idea what is going on here. No, I am not going to explain. The rest of us know what I am talking about. You should have taken more notice of my Welcome message.

Your posting privileges are revoked. Work out for yourself why.

heart1010 · Post by **heart1010** » Mon Jul 19, 2021 6:27 am

renexxxx » Sat Jul 17, 2021 12:10 am wrote:
heart1010 » Fri Jul 16, 2021 11:57 pm wrote:... - in the source you've added the include file "LibFF2.0.mqh" but in your EA "CloseOnNewsEAv2.1.mq4" you include "LibFF2.1.mqh"
Good spot!
I have now included LibFF2.1.mqh in the zip-file. Update is in Post 1

Thanks for the update renexxxx

FXFX7 · Post by **FXFX7** » Fri Jan 21, 2022 5:19 pm

Hi renexxxx, I'm looking to disable trading during US bank holidays due to the lower liquidity which has a huge impact on a scalper I'm trading with. As this is a "non-economic" news item on ff calendar there doesn't seem to be an obvious way to do this with your brilliant news filter ea. If I were to type something along the lines of "US bank holiday" in the additional filter to target specific news would this achieve that?

Post by **renexxxx** » Fri Jan 21, 2022 8:49 pm

FXFX7 » Sat Jan 22, 2022 3:19 am wrote:If I were to type something along the lines of "US bank holiday" in the additional filter to target specific news would this achieve that?

No, it wouldn't. In the FF XML file, Holidays are treated as a special type of Impact (HIgh, Medium or Low). I made a few changes to the code, such that it should be able to accommodate Holidays. The new .ex4 is attached with a suggested set-file to stop trading on holidays (but leave existing trades open). Let me know if it works. If it does, I will update Post 1 with the new source.

FXFX7 · Post by **FXFX7** » Sat Jan 22, 2022 12:13 pm

renexxxx » Fri Jan 21, 2022 9:49 pm wrote:
FXFX7 » Sat Jan 22, 2022 3:19 am wrote:If I were to type something along the lines of "US bank holiday" in the additional filter to target specific news would this achieve that?
No, it wouldn't. In the FF XML file, Holidays are treated as a special type of Impact (HIgh, Medium or Low). I made a few changes to the code, such that it should be able to accommodate Holidays. The new .ex4 is attached with a suggested set-file to stop trading on holidays (but leave existing trades open). Let me know if it works. If it does, I will update Post 1 with the new source.

Thank you so much you've just made my day! I'll install it right away and report back next US Bank holiday I suppose.

indy200 · Post by **indy200** » Mon Feb 14, 2022 2:10 am

Thank you very much for the ea it rocks