Scalping New York

Post by **SteveHopwood** » Wed May 25, 2022 8:39 am

The BE and auto close functions are not working. Live with what we have for the time being. I have a half-term break coming up and will sort it out then, if not before.

Post by **sangratan** » Wed May 25, 2022 8:41 am

no problem Steve ...
take your time,
thanks

Post by **SteveHopwood** » Wed May 25, 2022 9:20 am

I had a quick look and spotted the bloops straight away. The fix isin post 1.

DIYers, do a search for this comment:
//Are we at breakeven hour?

You will see immediately that this is wrong:
if (TimeHour(TimeCurrent() ) < breakEvenStarts)

because it will always be less that breakEvenStarts.

Replace it with:
if (TimeCurrent() < breakEvenStarts)

The next function down is void lookForCloseHour(). Scroll down until you find the equivalent line and replace it with:
if (TimeCurrent() < autoCloseStarts)

Post by **TableTop** » Wed May 25, 2022 9:43 am

SteveHopwood » Wed May 25, 2022 9:20 am wrote:I had a quick look and spotted the bloops straight away. The fix isin post 1.

Blimey - you're quick. I thought I'd finished with testing until the holidays! I'll set up MS and let it run for a couple of days. I'm not around much for the next couple of days.

Post by **wolfeman** » Wed May 25, 2022 10:46 am

He's quick because he knows- like we do, just how good this EA is...
I was going to chime in with the very things Y'all did tonight, but you beat me to it.

Steve, this EA is awesome! Well done, and THANK YOU!

Post by **TableTop** » Wed May 25, 2022 1:35 pm

Great work Steve - just had MS close on a BE trigger.
Still have not seen a Automatic close but have tests running so should be able to confirm at some point.

Post by **sangratan** » Wed May 25, 2022 2:20 pm

Hi,
I don't know why but the new fixed MS version is not working ,
I attach my settings in case I am doing some mistake ...any help ?
thanks

Post by **Maximilian** » Wed May 25, 2022 2:26 pm

sangratan » Wed May 25, 2022 2:20 pm wrote:Hi,
I don't know why but the new fixed MS version is not working ,
I attach my settings in case I am doing some mistake ...any help ?
thanks

For starters. Do you intend to wait 18hours for break even closure? As far as I understood, the BreakEvenWaitingHours demands hours and not a time, eg. you start at 14:00 and want to start looking for break even you enter 2 in the BreakEvenWaitingHours. Same for AutoClosure.

By why it´s not trading at all? I don´t know. Maybe the waiting hours are also preventing to start new trades.
Greetings,
Max

Post by **sangratan** » Wed May 25, 2022 2:37 pm

Hi,
I understand what you mean ,I am trying

Post by **sangratan** » Wed May 25, 2022 2:45 pm

nothing happens ,it doesn't work