Scalping New York

[wallywonka]

Anyone else only open 2 trades on London open today?

[WorldsEnd]

Anyone else only open 2 trades on London open today?

I had 18 or 19 trades open after London open this morning but no open trades after NY open a couple of minutes ago

[wallywonka]

Anyone else only open 2 trades on London open today?

I had 18 or 19 trades open after London open this morning but no open trades after NY open a couple of minutes ago

Interesting, not sure what happened with my London but New York opened fine with about 18 or so trades, just hit TP

[SteveHopwood]

Anyone else only open 2 trades on London open today?

I had 18 or 19 trades open after London open this morning but no open trades after NY open a couple of minutes ago

Interesting, not sure what happened with my London but New York opened fine with about 18 or so trades, just hit TP

Try looking into your Experts and Journal tabs to see if there is any info there.

Empty4 is not the utter bollocks it was a decade ago, yet stuff can easily intervene to derail aspects of its performance. At the mo, there is no code in MS to resend orders that failed first time around.

I will add code to deal with this situation. It is not difficult to do.

[pivotter]

i had the same uneven amount of trades on different terminals.

Now it scans all pairs 50X to not miss a possible trade.

if (testForAlreadyTradedThisHour() == true){
openatradecounter++;
}

if (openatradecounter >= 50)
{
displayUserFeedback();
return;
}//if (testForAlreadyTradedThisHour() )

//Loop round the pairs and send a trade if necessary
for (int pairIndex = 0; pairIndex <= ArraySize(tradePair) - 1; pairIndex++)
{



(and set openatradecounter=0; on the start of a new trade round)

[WorldsEnd]

Anyone else only open 2 trades on London open today?

I had 18 or 19 trades open after London open this morning but no open trades after NY open a couple of minutes ago

Interesting, not sure what happened with my London but New York opened fine with about 18 or so trades, just hit TP

Try looking into your Experts and Journal tabs to see if there is any info there.

Neither the Experts tab nor the Journal tab shows any sign of what could have been the problem. Around NY open nothing is mentioned in either tab.

Maybe Pivotter is offering a working solution which works out Empty4 f*** ups. Dunno.

[trader689]

I wanted to report that running the latest version of multiple scalpy on a Global Prime demo, and with baskets set to open at 8.05am and 1.05pm, no trades were opened for me at all on London open, and one was opened at NY open (which closed for breakeven closure). No errors in journals or experts tab

trader

[biobier]

I'm a bit late to the show but this looks great!
Just a question why not use UTC times (UTC is the new GMT) in the setting? Then we would not need to bother adjusting to the local/brokers time as UTC is everywhere the same. https://time.is/en/UTC
London open is 07 UTC and NY is 12 UTC. https://www.babypips.com/tools/forex-market-hours

I use this code:

Code: Select all

enum ENUM_TIMESRC
{
   Local,
   Broker,
   UTC
};

input ENUM_TIMESRC  TimeSourceToUse = UTC;

datetime getTime()
 {
   switch(TimeSourceToUse){
      case Local:
         return(TimeLocal());
      case Broker:
         return(TimeCurrent());
      case UTC:
         return(TimeGMT());
      default:
         return(TimeLocal());
   }
 }

datetime getTime(MqlDateTime &ref)
 {
   switch(TimeSourceToUse){
      case Local:
         return(TimeLocal(ref));
      case Broker:
         return(TimeCurrent(ref));
      case UTC:
         return(TimeGMT(ref));
      default:
         return(TimeLocal(ref));
   }
 }

Also adding it to the screen info:

Code: Select all

sm("Broker time = "+TimeToStr(TimeCurrent(),TIME_DATE|TIME_SECONDS)+
": Local time = "+TimeToStr(TimeLocal(),TIME_DATE|TIME_SECONDS)+
": UTC Time = "+ TimeToStr(TimeGMT(),TIME_DATE|TIME_SECONDS)+NL);

[SteveHopwood]

Ben has just emailed me with this observation:

I just noticed this in the code and i think I should mention it for just in case as we are all searching the code.

#define long "Long"
#define short "Short"
#define none "None"

long and short are integer types and cant be defined as they are reserved.

I would not be surprised to find that this is the cause of AWOL orders. Don't know for sure but it is not a brilliant idea to try to redefine a 'reserved word'. I have turned them into 'longy, shorty, noney'.

Multiple Scalpy has morphed back into plain Scalpy. I shall keep the original version as Scalpy Original in post 1, once I have reorganised the post. For now, use the version attached here. Remember to:

• Save your current inputs.
• Delete the original version of Scalpy.
• Shut down the platform.
• Download the version attached here.
• Restart the platform.
• Drag Scalpy onto a chart and load up your set file.

I have added functionality to deal with the odd occasion when an order send fails, along with further details to the chart display.

[SteveHopwood]

Re-download from my previous post if you downloaded before reading this one. The display would not work properly if there are no open orders.