Scalping New York

[celte83]

[quote="[url=viewtopic.php?p=174673#p174673]
after all this time, I've not made one dime trading FX.

"If it ain't broke, don't fix it."[/quote]

Fellow,
The same for me : not made one dime at the end of all theses years. Losing

Ok I don't fix it, I try to better understand.

And yess the TP is so little ! TP vs SL we wonder how it wins at the end. Basket is magic

Cheers, Santé
jf

[SteveHopwood]

Neither the demo accounts nor the live one traded NY today. I realised why when I looked at the code. I had it checking the hour part of the trade before reaching Ben's day/month/year checks. You will have had trades if you only had today in your history tab.

Fixed in post 1.

Easiest DIY in the world. Do a search for: /*We have pivotter (Ben) to thank

Move the code block to underneath betterOrderSelect block. The function will look like this:

Code: Select all

bool testForAlreadyTradedThisHour()
{

   //The function returns 'true' if it finds an order that opened
   //or closed during the hour, else returns 'false'

   if (OrdersHistoryTotal() == 0)
      return(false);
      

      
   int hourBroker = TimeHour(TimeCurrent() );
   
   
      
   for (int cc = OrdersHistoryTotal() - 1; cc >= 0; cc--)
   {
      if (!BetterOrderSelect(cc, SELECT_BY_POS, MODE_HISTORY) )
         continue;//Shouldn't happen, but no harm in making sure
         
      /*We have pivotter (Ben) to thank for spotting why Scalpy sould stop
        trading altogether. Go to https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=174598#p174598
        to read his post.
        
        Ben also supplied the code. Break out of the loop as soon
        as we find an order that was not sent today - broker time
      */   
      if (TimeDay(OrderOpenTime()) != TimeDay(TimeCurrent())) break;
      if (TimeMonth(OrderOpenTime()) != TimeMonth(TimeCurrent())) break;
      if (TimeYear(OrderOpenTime()) != TimeYear(TimeCurrent())) break;
         
      //Did the order open during the current hour?
      int openHour = TimeHour(OrderOpenTime() );     
      if (openHour == hourBroker)
         return(true);//Yes, so already traded this hour
         
         
      //Did the order close during the current hour?
      int closeHour = TimeHour(OrderCloseTime() );
      if (closeHour == hourBroker)
         return(true);//Yes, so no more trading until a new H1 candle forms. 
         
      
   }//for (int cc = OrdersHistoryTotal() - 1; cc >= 0; cc--)
   

   //Reached here, so OK to trade
   return(false);

}//End bool testForAlreadyTradedThisHour()

[Aussie Phil]

Steve 12 UTC according to the link biobier provided can be either AM or PM. Noob question but how does Scalpy differentiate?

[TableTop]

Neither the demo accounts nor the live one traded NY today. I realised why when I looked at the code. I had it checking the hour part of the trade before reaching Ben's day/month/year checks. You will have had trades if you only had today in your history tab.

I got lucky then (and it may explain why one instance didn't trade yesterday)
FYI - London open closed at BE & NY at TP.
Thank you Steve - great work

[SteveHopwood]

Steve 12 UTC according to the link biobier provided can be either AM or PM. Noob question but how does Scalpy differentiate?

No it isn't. Google "UTC Time" to see.

[willwelll]

Hi Steve, I'm pretty sure today wasn't a bank holiday. Neither is tomorrow. It's just Thursday and Friday

[SteveHopwood]

Hi Steve, I'm pretty sure today wasn't a bank holiday. Neither is tomorrow. It's just Thursday and Friday

Yep. Something I saw confused me.

[celte83]

Hi every body
today In a few minutes we went to a few cents of the goal!
(not manually, but with EA Sclapy)

scalpy 1 juin.PNG

[holygrailfx]

Hi every body
today In a few minutes we went to a few cents of the goal!

Great work! his experience mimicks mine!
I have also noticed, just noticed nothing scientific, that all asian pairs, aud, nzd and jpy are underperforming on london open! So maybe we should have the ability to trade different baskets at each open. a basket of eurocentric pairs at london open, usd centric pairs at NY open and even downunder pairs at japan open? Last option I have never traded manually as I am rarely in front of my computer at that hour

Anybody? any comments?

[wallywonka]

Still getting trades going against the previous candle direction.. Am I the only one? This is on a clean fresh installation!