Bob and Jem and Shelley's Pivot Basket auto-trader

[Mike]

I have no trades with v1j up to now OOTB.

Set "OnlyAddToOpenBasket" = false and it will start trading

...EA is looking for trade conditions(suppose so).
What is your criminal and how many pairs are available? Mine-Cowboy Go Markets-25 pairs.
Regards

ACM - I trade 24 pairs:
AUDCAD,AUDCHF,AUDNZD,AUDJPY,AUDUSD,CADJPY,CHFJPY,EURAUD,
EURCAD,EURCHF,EURGBP,EURJPY,EURUSD,GBPAUD,GBPCAD,GBPCHF,
GBPJPY,GBPUSD,NZDUSD,NZDJPY,USDCAD,USDCHF,USDJPY,XAUUSD
I need some rest (midnight overhere), I am rather frustrated that I am not able to get this EA doing what it is supposed to do, sorry, regards

[SteveHopwood]

Hi
Finding same problem. This EA is dangerous.
It operated fine for a week, taking a couple of trades when kicked with TF change.
Friday I noticed iExposure acting funny & realised BJS had opened & closed 100 trades for spread loss in 5 mins approx 1200GMT.
BJS fired again today (Mon) and started the same open/close at approx 0500GMT.
I believe it requires split level conditional open & close to prevent transients & fluctuations.

Is this either of V1i or V1j?

[harry45]

Hi
Finding same problem. This EA is dangerous.
It operated fine for a week, taking a couple of trades when kicked with TF change.
Friday I noticed iExposure acting funny & realised BJS had opened & closed 100 trades for spread loss in 5 mins approx 1200GMT.
BJS fired again today (Mon) and started the same open/close at approx 0500GMT.
I believe it requires split level conditional open & close to prevent transients & fluctuations.

Is this either of V1i or V1j?

Steve,
something wrong with v1j,numerous trades.The only opend pair -EG.Broker-Cowboy Go Markets

[SteveHopwood]

Hi
Finding same problem. This EA is dangerous.
It operated fine for a week, taking a couple of trades when kicked with TF change.
Friday I noticed iExposure acting funny & realised BJS had opened & closed 100 trades for spread loss in 5 mins approx 1200GMT.
BJS fired again today (Mon) and started the same open/close at approx 0500GMT.
I believe it requires split level conditional open & close to prevent transients & fluctuations.

Is this either of V1i or V1j?

Steve,
something wrong with v1j,numerous trades.The only opend pair -EG.Broker-Cowboy Go Markets

What were your AllowAdditionsToBasket and OnlyAddToOpenBasket inputs set to?

[harry45]

AllowAdditionsToBasket=true,OnlyAddToOpnBasket=false

[AGT]

the same here: noumerous trades for EURGBP, small losses (0.02 lot, 2500 EUR, 20 pairs)
inputs:
AllowAdditionsToBasket=true - and OnlyAddToOpenBasket=false

v1j / Cowboy IBFX AU

[SteveHopwood]

AllowAdditionsToBasket=true,OnlyAddToOpnBasket=false

Thanks. clearly still a problem with this function.

A quick fix is to set AllowAdditionsToBasket to false. It is the code that allows the trades to be sent individually that is at fault. It is sending them incorrectly, then bjs is closing them correctly.

No idea why. For now, just accept that it doesn't work yet.

[garyfritz]

I also tried OnlyAddToOpenBasket=false and got constant in/out trades -- EURGBP on MBT, half a dozen pairs on Cowboy IBFX.

I ran 1j since Sunday night with OnlyAddToOpenBasket=true and got no trades.

[Mike]

perhaps useful: the bot v1j displays 0% even if you define "MinimumPercentOfBasket"=60% or 80%
Yesterday I had set "MinimumPercentOfBasket"=60%, during some time 6 out of 9 pairs saddisfied all criteria, but nothing happened as long as I did not set "OnlyAddToOpenBasket"=false. hmm... but then as you already know, uncountable repeating trades.
Just wondering: Is there any reason, why there is no option ECN=true/false

[SteveHopwood]

V 1k in post 1. Fixed the percentage display problem; that was LUC inviting his buddies around for morning coffee.

I am surprised LUC and his pals had time for morning coffee given the bender they were on with the open/close trade thingy. The problem turned out to be in CountOpenTrades.

In this code, bjs would close an individual trade if the previous H4 candle closed the wrong side of the pivot, yet closing the wrong side of the pivot is one of the conditions for sending an individual trade in the first place. As usual, bjs was being his usual well-behaved self.

Code: Select all

  //Check for a close on the wrong side of the daily pivot
	  CalculatePivots(OrderSymbol() );
	  if (OrderType() == OP_BUY && iClose(OrderSymbol(), PERIOD_H4, 1) < DailyPivot)
	  {
			result = CloseTrade(OrderTicket() );
			if (result) cc++;
	  }//if (OrderType() == OP_BUY && iClose(OrderSymbol(), Period_H4, 1) < DailyPivot)
	  
	  if (OrderType() == OP_SELL && iClose(OrderSymbol(), PERIOD_H4, 1) > DailyPivot)
	  {
			result = CloseTrade(OrderTicket() );
			if (result) cc++;
	  }//if (OrderType() == OP_BUY && iClose(OrderSymbol(), Period_H4, 1) < DailyPivot)

I have tried enclosing the code within a trade open time check, so it will only look at the close 1 candle ago if the trade opened before that. This should do the trick.

Code: Select all

//Check for a close on the wrong side of the daily pivot
      if (OrderOpenTime() <= iTime(OrderSymbol(), PivotCrossTimeFrame, 1)  )
      {
         CalculatePivots(OrderSymbol() );
         if (OrderType() == OP_BUY && iClose(OrderSymbol(), PivotCrossTimeFrame, 1) < DailyPivot)
         {
               result = CloseTrade(OrderTicket() );
               if (result) cc++;
         }//if (OrderType() == OP_BUY && iClose(OrderSymbol(), Period_H4, 1) < DailyPivot)
         
         if (OrderType() == OP_SELL && iClose(OrderSymbol(), PivotCrossTimeFrame, 1) > DailyPivot)
         {
               result = CloseTrade(OrderTicket() );
               if (result) cc++;
         }//if (OrderType() == OP_BUY && iClose(OrderSymbol(), Period_H4, 1) < DailyPivot)
       }//if (OrderOpenTime() < iTime(OrderSymbol(), PivotCrossTimeFrame, 1)  )

I will not be around much today - busy with the day job of pianisticking. Give this version a whirl and see if it does the job.