Nanningbob 10.2 Autotrader's new home

[jlcgarcia]

Hi,

a solution for the magic number generator would be to replace the following sentence:

Code: Select all

/---------------------------------------------------------------------
//---------------------------------------------------------------------
// GenMagic function
// @desc    Generates a unique magic number (hash)
// @param   string   suffix   additional suffix to create different magics for different style trades       
// @return  int               returns the unique magic number
int GenMagic(string suffix="")
{	int m;

//   string s=Symbol()+"_"+suffix;
   string s=StringConcatenate(AccountNumber(),"_",suffix);

Because this will generate the same number for all charts.

Regards

José Luis

[matt_32]

Is it just me or sometimes when this EA opens a trade it leaves the take profit blank (0) and I have to manually reload the EA in order to fix it?

Matt

[hopfi2k]

José,

Thanks for your proposal. Having the same number for all the charts can be dangerous though. The EA wouldn't be able anymore to distinguish which trade has been opened by itself and which one by another EA or another instance of the EA. This will maybe sooner than later result in complete random results.

Cheers,
Andy

Hi,

a solution for the magic number generator would be to replace the following sentence:

Code: Select all

/---------------------------------------------------------------------
//---------------------------------------------------------------------
// GenMagic function
// @desc    Generates a unique magic number (hash)
// @param   string   suffix   additional suffix to create different magics for different style trades       
// @return  int               returns the unique magic number
int GenMagic(string suffix="")
{	int m;

//   string s=Symbol()+"_"+suffix;
   string s=StringConcatenate(AccountNumber(),"_",suffix);

Because this will generate the same number for all charts.

Regards

José Luis

[worlock]

One thing that I think should be looked at, is that the EA is opening the same trade again the moment it gets stopped out or even exits at TP. This week I had this happening on USCAD, EURUSD, EURCAD, EURAUD, EURGBP and GBPJPY.
Somehow we should have a filter not to take same trades again, or a filter by time like some other EAs in this forum.

[philcs65]

One thing that I think should be looked at, is that the EA is opening the same trade again the moment it gets stopped out or even exits at TP. This week I had this happening on USCAD, EURUSD, EURCAD, EURAUD, EURGBP and GBPJPY.
Somehow we should have a filter not to take same trades again, or a filter by time like some other EAs in this forum.

Same thing happened to me (eurjpy). Logged in almost 100 trades before I could stop it. Good news, demo account plus made about 150 pips!

[cuzgeorge]

worlock, phil,
is it possible to have a screen pic of the offending ea showing the verbose on the left side, and possibly a set file.
also, if you manage to look up the 'expert' tab or 'journal' if anything abnormal was showing. Sometimes you would get an error, or was it a normal condition where the ea would buy and sell as if it were meant to do that.

the abovementioned would give al3xx and anyone troubleshooting this a better idea.
I thought those days were over for this ea and i'd like to take a look at this myself. maybe i can re-create the problem.

you might not be infront of your screen when it happens but it would be helpfull if you could catch this info.

thanks,
cuzgeorge

[alorente]

worlock, phil,
is it possible to have a screen pic of the offending ea showing the verbose on the left side, and possibly a set file.
also, if you manage to look up the 'expert' tab or 'journal' if anything abnormal was showing. Sometimes you would get an error, or was it a normal condition where the ea would buy and sell as if it were meant to do that.

the abovementioned would give al3xx and anyone troubleshooting this a better idea.
I thought those days were over for this ea and i'd like to take a look at this myself. maybe i can re-create the problem.

you might not be infront of your screen when it happens but it would be helpfull if you could catch this info.

thanks,
cuzgeorge

I think they mean it opens the trade again because the conditions are still valid. I don´t think this is a code problem. The EA is doing what it is supposed to.

I actually think this is a plus. For example, I am trying out a TP of 22 pips (20 pips plus spread). On trend trades, it pockets the 20 pips and opens the trade again. As the trend continues it keeps putting away the additional 20 pips, so you can´t lose them as is the case in a retracement and a larger TP. Sometimes, when you get a retracement, it will reenter the trade and you can make the 20 pips all over again. It´s pretty cool.

[worlock]

worlock, phil,
is it possible to have a screen pic of the offending ea showing the verbose on the left side, and possibly a set file.
also, if you manage to look up the 'expert' tab or 'journal' if anything abnormal was showing. Sometimes you would get an error, or was it a normal condition where the ea would buy and sell as if it were meant to do that.

the abovementioned would give al3xx and anyone troubleshooting this a better idea.
I thought those days were over for this ea and i'd like to take a look at this myself. maybe i can re-create the problem.

you might not be infront of your screen when it happens but it would be helpfull if you could catch this info.

thanks,
cuzgeorge

I think they mean it opens the trade again because the conditions are still valid. I don´t think this is a code problem. The EA is doing what it is supposed to.

You are correct. The trade would still be valid according to the conditions. But if the EA does this, then there is no point in having a pre determined TP or SL.

[freereed]

I think they mean it opens the trade again because the conditions are still valid. I don´t think this is a code problem. The EA is doing what it is supposed to.

I actually think this is a plus. For example, I am trying out a TP of 22 pips (20 pips plus spread). On trend trades, it pockets the 20 pips and opens the trade again. As the trend continues it keeps putting away the additional 20 pips, so you can´t lose them as is the case in a retracement and a larger TP. Sometimes, when you get a retracement, it will reenter the trade and you can make the 20 pips all over again. It´s pretty cool.

I think that's a really neat idea alorente, if you don't mind losing the spread each time. Are you running a side-by-side demo with 'normal' parameters to compare them? Please do share the results down the line...

[alorente]

I think they mean it opens the trade again because the conditions are still valid. I don´t think this is a code problem. The EA is doing what it is supposed to.

I actually think this is a plus. For example, I am trying out a TP of 22 pips (20 pips plus spread). On trend trades, it pockets the 20 pips and opens the trade again. As the trend continues it keeps putting away the additional 20 pips, so you can´t lose them as is the case in a retracement and a larger TP. Sometimes, when you get a retracement, it will reenter the trade and you can make the 20 pips all over again. It´s pretty cool.

I think that's a really neat idea alorente, if you don't mind losing the spread each time. Are you running a side-by-side demo with 'normal' parameters to compare them? Please do share the results down the line...

The problem is, when you try to run it as you would normally, the EA keeps getting you back in, so you really can´t set a reasonable TP. Still, thanks to this problem, I hit on my system which I really like. The spread is less than you would lose with price moving repeatedly back and forth over the same range.
I may try 12 pips TP next.