Nanningbob 10.2 Autotrader's new home

[al3xx]

Alex,

It was never my intention to take over or supersede NanningBob 10.2 Autotrader. In fact I adopted a lot of code from it. Great work and thank you again!

Paul

Don't beat yourself up. It is a splending job you did there Paul. Cheers and beautiful code as always!

Alex

[al3xx]

And that may now seem a tad redudant seeing as we now have this latest toy by Baluda here... http://www.stevehopwoodforex.com/phpBB3 ... f=44&t=827

Alex,
you brought 10.2 out of the dead.
It was dead as a doornail, unless one was able to trade 10.2 manually. Thats not the majority.

I appreciate your work and time here tremendously and i'm sure everyone will agree.

I'm rather embarrassed that i havent got your 1.3a1 up and running on demo yet as i've run out of demos and dont want to cancel anything. There are users tracking specific systems. Yours is the most followed.

Thank you for all you do here,
regards
cuzgeorge

Appreciated George. Thank's once again for all the help.

Alex

[droland]

Much appreciated good people.

I have to say that I think Paul has done amazing work on the 10.2a/10.2 EA and I am very excited about it.

Technically, the code from the multi-pair EA is much better and should be easier to maintain/extend in the long run. The only difference (if traded as a 10.2) with my 10.2 is the Multi-Pair I believe.

As I said, I am on it myself and will always share any improvements if nessesary with Paul to improve it. He is a talented coder and I am sure he will do amazing things there. For me, it is great when NanningBob 10.2 moves forward.

For NB 10.2:

As some of you know I was working on some improvements (although time has not been very kind to me of late). If I am not completely carried away by the multi-pair, I could finish them on this EA and will post a version for anyone who wants. On the other hand, I might end up doing my improvements on Baludas version and they will still get here somehow

In any case, we win. After all, what we want is a good tool to beat the markets with.

Many thanks to Steve who began it all and who continues to make it happen. Cheers to all others who contributed and who continue to do so.

Kind Regards,

Alex

I am super impressed with this attitude. There is no good, better, best programmer here. The synergy of the group is bigger than its parts. Impressive and acknowledged. Thanks everyone.

Dave R.

[SteveHopwood]

Alex, have you seen TIG's post at http://www.stevehopwoodforex.com/phpBB3 ... 008#p24008. I have not checked, but it looks as though he has found the bloop that causes the occasional rapid trade open-close thingy. I have not actually checked, but I cannot recall catching George getting something wrong.

[cuzgeorge]

Much appreciated good people.

I have to say that I think Paul has done amazing work on the 10.2a/10.2 EA and I am very excited about it.

Technically, the code from the multi-pair EA is much better and should be easier to maintain/extend in the long run. The only difference (if traded as a 10.2) with my 10.2 is the Multi-Pair I believe.

As I said, I am on it myself and will always share any improvements if nessesary with Paul to improve it. He is a talented coder and I am sure he will do amazing things there. For me, it is great when NanningBob 10.2 moves forward.

For NB 10.2:

As some of you know I was working on some improvements (although time has not been very kind to me of late). If I am not completely carried away by the multi-pair, I could finish them on this EA and will post a version for anyone who wants. On the other hand, I might end up doing my improvements on Baludas version and they will still get here somehow

In any case, we win. After all, what we want is a good tool to beat the markets with.

Many thanks to Steve who began it all and who continues to make it happen. Cheers to all others who contributed and who continue to do so.

Kind Regards,

Alex

Great post Alex,
I've got 4 new demos available from Monday.
Re-installing 2 systems and looking for direction here. Please suggest how to setup so as to avoid us all testing the same settings, and also to free up some of your space. Info will be posted as usual on myfxbook for all to track and analyze.

I have no doubt you will be looking into TOIG's code-fix for the rapid trades so will wait to hear from you, but i will keep the originals all running on demo as normal. I will only take these off if something critical happens to them.

I'm running v1.3a1 on a criminal that i cant get onto fxbook, therefore, my live account with them is history. Will wait to see what your findings are before setting up on new demo's.

regards and great to hear from you.
cuzgeorge

[cuzgeorge]

Alex, have you seen TIG's post at http://www.stevehopwoodforex.com/phpBB3 ... 008#p24008. I have not checked, but it looks as though he has found the bloop that causes the occasional rapid trade open-close thingy. I have not actually checked, but I cannot recall catching George getting something wrong.

Hi Alex, all,
just to confirm what George, Gaheitman found , i had this error come up on v1.3a1, first time.
regards,
cuzgeorge

EDIT- sorry forgot the pic as it's not one that is tracked by fxbook.

[gaheitman]

Alex, have you seen TIG's post at http://www.stevehopwoodforex.com/phpBB3 ... 008#p24008. I have not checked, but it looks as though he has found the bloop that causes the occasional rapid trade open-close thingy. I have not actually checked, but I cannot recall catching George getting something wrong.

Hi Alex, all,
just to confirm what George, Gaheitman found , i had this error come up on v1.3a1, first time.
regards,
cuzgeorge

EDIT- sorry forgot the pic as it's not one that is tracked by fxbook.

This looks a little different than what we had in the other EA. The TP for these trades is zero and the stop loss wasn't hit, so that suggests the code is manually closing them. I have added some debug statements to help pinpoint the issue. Unfortunately, I probably won't get a hit until the markets pick up a bit....

George

[cuzgeorge]

This looks a little different than what we had in the other EA. The TP for these trades is zero and the stop loss wasn't hit, so that suggests the code is manually closing them. I have added some debug statements to help pinpoint the issue. Unfortunately, I probably won't get a hit until the markets pick up a bit....

George

Hi George,
I think this might help, and i'm also including my set file in-case it's something i've done wrong with the settings.

The EA is hardcoded with this set file,
i'm only running on 4 main charts,
NO MPTM is set up here to conflict with the trades like i had on another EA.
RecoveryVirtualStop is set to '0' unlike others.
BollingerBands is 'true' and set 60/20/1 with minimum range TP at 15
UseZeljko is set to 'false'
and the last difference i see is the setting for 'EnforcePriceToWeeklyOpen' and 'TradeWeeklyPivotCross' are both set to 'true.'
Correlation is set to 'true' - 75


Hope this helps and thank you very much for the time and effort.
cuzgeorge

[gaheitman]

This looks a little different than what we had in the other EA. The TP for these trades is zero and the stop loss wasn't hit, so that suggests the code is manually closing them. I have added some debug statements to help pinpoint the issue. Unfortunately, I probably won't get a hit until the markets pick up a bit....

George

Hi George,
I think this might help, and i'm also including my set file in-case it's something i've done wrong with the settings.

The EA is hardcoded with this set file,
i'm only running on 4 main charts,
NO MPTM is set up here to conflict with the trades like i had on another EA.
RecoveryVirtualStop is set to '0' unlike others.
BollingerBands is 'true' and set 60/20/1 with minimum range TP at 15
UseZeljko is set to 'false'
and the last difference i see is the setting for 'EnforcePriceToWeeklyOpen' and 'TradeWeeklyPivotCross' are both set to 'true.'
Correlation is set to 'true' - 75


Hope this helps and thank you very much for the time and effort.
cuzgeorge

Well, first of all AdjustStopLoss() is trying to set the SL to 1.803, which doesn't make sense for that currency. I don't see that it is successful, however, which is even weirder.

Update: OK, since it is trying to set the SL on a sell to be lower than the current price, it is closing the trade (as it is WAY past stop loss ). Now to figure out why there is a line drawn at 1.803...


George

[gaheitman]

This looks a little different than what we had in the other EA. The TP for these trades is zero and the stop loss wasn't hit, so that suggests the code is manually closing them. I have added some debug statements to help pinpoint the issue. Unfortunately, I probably won't get a hit until the markets pick up a bit....

George

Hi George,
I think this might help, and i'm also including my set file in-case it's something i've done wrong with the settings.

The EA is hardcoded with this set file,
i'm only running on 4 main charts,
NO MPTM is set up here to conflict with the trades like i had on another EA.
RecoveryVirtualStop is set to '0' unlike others.
BollingerBands is 'true' and set 60/20/1 with minimum range TP at 15
UseZeljko is set to 'false'
and the last difference i see is the setting for 'EnforcePriceToWeeklyOpen' and 'TradeWeeklyPivotCross' are both set to 'true.'
Correlation is set to 'true' - 75


Hope this helps and thank you very much for the time and effort.
cuzgeorge

Well, first of all AdjustStopLoss() is trying to set the SL to 1.803, which doesn't make sense for that currency. I don't see that it is successful, however, which is even weirder.

Update: OK, since it is trying to set the SL on a sell to be lower than the current price, it is closing the trade (as it is WAY past stop loss ). Now to figure out why there is a line drawn at 1.803...


George

In CountOpenTrades(), TicketNo is only set to OrderTicket() for the first trade it looks at. So, if there are more than one ticket being examined the code that looks at the lines on the chart will use an incorrect TicketNo when looking up the lines.

I suspect the code should be changed to use OrderTicket(). The lines are:

Code: Select all

      //Check for tp/sl line movements by the user, and adjust the stops accordingly
      string LineName = TpPrefix + DoubleToStr(TicketNo, 0);//TicketNo is set by the calling function - either CountOpenTrades or DoesTradeExist
      if (ObjectFind(LineName) > -1)
      {
         AdjustTakeProfit();
      }//if (ObjectFind(LineName) > -1)
      
      LineName = SlPrefix + DoubleToStr(TicketNo, 0);//TicketNo is set by the calling function - either CountOpenTrades or DoesTradeExist
      if (ObjectFind(LineName) > -1)
      {
         AdjustStopLoss();
      }//if (ObjectFind(LineName) > -1)

DrawPendingPriceLines() also uses TicketNo, which would not work correctly either when called in this loop.


George