Balls to the Wall, a 1 minute 1 trade EA

Locked
User avatar
SteveHopwood
Owner
Posts: 9904
Joined: Tue Nov 15, 2011 8:43 am
Location: Misterton - an insignificant village in England. Very pleasant to live in.

Re: Version 1h possible code typo

Post by SteveHopwood »

fxjoe2 wrote:Hi All

While visually backtesting earlier today I saw a the yellow line appear on the opposite side of the market than what I would have expected.
I then re-read the thread as well as Paulus's initial explanation at FF.
I then scanned through version 1h and found what I believe might be a typo causing this:

Line # 2514-2516:
if (Fopen > Fclose) CreateHLine(LowLineName, iLow(NULL, PERIOD_H1, 1), STYLE_SOLID, 0,
LineColour);//Market fell
if (Fopen < Fclose) CreateHLine(LowLineName, iHigh(NULL, PERIOD_H1, 1), STYLE_SOLID, 0,
LineColour);//Market rose
I think iLow and iHigh should be swopped.

I made a copy of the code with this change and it seemed to have resolved the position of the yellow line.
I might be wrong, but thought I highlight the posibility.

FXJoe
Hmmmm. Slightly scary that I got this arse end over tip. Nothing new there. :lol: Utterly terrifying that it took a newbie here to both spot it and have the courage to point it out. Nice one, Joe; your name is now showing up in a much more fetching colour that it did originally.

Ok guys; either Joe is an idiot or I have confirmed yet again my idiocy status. I have read the code and compared it with the info in the post 1 pdf many times. Doesn't matter how many times I look; Joe appears to be correct.

Fix in post 1; this might give the original Balls a second chance. I shall try it again on demo on Monday.

Thanks Joe. Nice one.

:D
Read the effing manual, ok?

Afterprime is the official SHF broker. Read about them at https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=175790#p175790.

I still suffer from OCCD. Good thing, really.

Anyone here feeling generous? My paypal account is always in the market for a tiny donation. pianodoodler@hotmail.com is the account.

To see The Weekly Roundup of stuff you guys might have missed Click here

My special thanks to Thomas (tomele) for all the incredible work he does here.
User avatar
fxjoe2
Posts: 7
Joined: Wed Aug 08, 2012 7:49 am

Re: Balls to the Wall, a 1 minute 1 trade EA

Post by fxjoe2 »

Glad to contribute some.
Image
User avatar
wolfeman
Trader
Posts: 143
Joined: Thu Nov 17, 2011 6:15 am
Location: Slumming it in sunny California

Re: Version 1h possible code typo

Post by wolfeman »

I could be wrong, but this might explain why the trades using slope were all closing immediately. I must give it a try...

SteveHopwood wrote:
fxjoe2 wrote:Hi All

While visually backtesting earlier today I saw a the yellow line appear on the opposite side of the market than what I would have expected.
I then re-read the thread as well as Paulus's initial explanation at FF.
I then scanned through version 1h and found what I believe might be a typo causing this:

Line # 2514-2516:
if (Fopen > Fclose) CreateHLine(LowLineName, iLow(NULL, PERIOD_H1, 1), STYLE_SOLID, 0,
LineColour);//Market fell
if (Fopen < Fclose) CreateHLine(LowLineName, iHigh(NULL, PERIOD_H1, 1), STYLE_SOLID, 0,
LineColour);//Market rose
I think iLow and iHigh should be swopped.

I made a copy of the code with this change and it seemed to have resolved the position of the yellow line.
I might be wrong, but thought I highlight the posibility.

FXJoe
Hmmmm. Slightly scary that I got this arse end over tip. Nothing new there. :lol: Utterly terrifying that it took a newbie here to both spot it and have the courage to point it out. Nice one, Joe; your name is now showing up in a much more fetching colour that it did originally.

Ok guys; either Joe is an idiot or I have confirmed yet again my idiocy status. I have read the code and compared it with the info in the post 1 pdf many times. Doesn't matter how many times I look; Joe appears to be correct.

Fix in post 1; this might give the original Balls a second chance. I shall try it again on demo on Monday.

Thanks Joe. Nice one.

:D
jth
Trader
Posts: 51
Joined: Sat Dec 17, 2011 7:07 pm

Re: Balls to the Wall, a 1 minute 1 trade EA

Post by jth »

Hi Guys,
Firstly Everyone have a good trading week.

OK last friday was a very bad looking day for the basket system by mid afternoon. At this point i had lost 2 piar with quite big losses at that, then the market started to turn. In the last 5 minutes before the market close on friday the system was $-400.00 dollars short from BE for the day. I decided to leave the basket going for sunday open.
I opened the Empty4 on sunday before market open and see what would happen, the basket hit TP 5 seconds after open which gave me a small total profit from friday of $383.80

But it's still a profit :D (see attached report.)

Anyway i am still waiting for London open

Regards
JTH

will report what happens win or lose.
You do not have the required permissions to view the files attached to this post.
patman
Trader
Posts: 68
Joined: Sat Dec 10, 2011 1:48 am

Re: Version 1h possible code typo

Post by patman »

SteveHopwood wrote:
fxjoe2 wrote:Hi All

While visually backtesting earlier today I saw a the yellow line appear on the opposite side of the market than what I would have expected.
I then re-read the thread as well as Paulus's initial explanation at FF.
I then scanned through version 1h and found what I believe might be a typo causing this:

Line # 2514-2516:
if (Fopen > Fclose) CreateHLine(LowLineName, iLow(NULL, PERIOD_H1, 1), STYLE_SOLID, 0,
LineColour);//Market fell
if (Fopen < Fclose) CreateHLine(LowLineName, iHigh(NULL, PERIOD_H1, 1), STYLE_SOLID, 0,
LineColour);//Market rose
I think iLow and iHigh should be swopped.

I made a copy of the code with this change and it seemed to have resolved the position of the yellow line.
I might be wrong, but thought I highlight the posibility.

FXJoe
Hmmmm. Slightly scary that I got this arse end over tip. Nothing new there. :lol: Utterly terrifying that it took a newbie here to both spot it and have the courage to point it out. Nice one, Joe; your name is now showing up in a much more fetching colour that it did originally.

Ok guys; either Joe is an idiot or I have confirmed yet again my idiocy status. I have read the code and compared it with the info in the post 1 pdf many times. Doesn't matter how many times I look; Joe appears to be correct.

Fix in post 1; this might give the original Balls a second chance. I shall try it again on demo on Monday.

Thanks Joe. Nice one.

:D
Hi Steve,

I had wondered about this and was setting up to test today

I also figured the if statement

Code: Select all

  if (TimeHour(TimeLocal() ) == MarketOpenHour && ObjectGet(LowLineName, OBJPROP_PRICE1) != iLow(NULL, PERIOD_H1, 1) && !TradingDone && !DisableLineUse)
needed to be changed too.

if OBJPROP_PRICE1 = iHigh then for the first hour the EA keeps re-drawing the line - I think.

Would this work?

Code: Select all

  if (TimeHour(TimeLocal() ) == MarketOpenHour && (ObjectGet(LowLineName, OBJPROP_PRICE1) != iLow(NULL, PERIOD_H1, 1) || ObjectGet(LowLineName, OBJPROP_PRICE1) != iHigh(NULL, PERIOD_H1, 1)) && !TradingDone && !DisableLineUse)
patman
User avatar
cuzgeorge
Trader
Posts: 674
Joined: Mon Mar 05, 2012 10:10 am
Location: Johannesburg, South Africa.

Re: Balls to the Wall, a 1 minute 1 trade EA

Post by cuzgeorge »

Hi Steve, all,
i'm getting this error on the new Wolfie and Balls v1h.
i believe it has something to do with Balud's time software, but cant see whats wrong.
Steve, enlighten us please; the part refers to two different trading time names, please refer to pic with highlighted code.
I cant get rid of the blank alert box that keeps coming up. ive had no trades on Wolfie yet, but v1g is working fine and v1i has had a win from this morning, albeit a small BE win.
regards
Cuzgeorge

EDIT; ive tried removing the code and recompiling , but it still comes up., ive also tried changing times and also removing times altogether. same issue.
You do not have the required permissions to view the files attached to this post.
10.X, BMac,Xmeter,Marylin,and CaptsNakedTrading thread coupled with Slowkeys Intraday setup for manual trades.
http://www.stevehopwoodforex.com/phpBB3 ... f=36&t=848
jboy
Trader
Posts: 57
Joined: Sat Dec 17, 2011 7:18 am

Re: Balls to the Wall, a 1 minute 1 trade EA

Post by jboy »

jth,

what leverage are you using on your demo? I suspect it is quite high because in the US brokers, it is only 1:50 leverage. I don't see how one can open all 8 pairs at the same time with 1:50 leverage, I don't think the broker will allow the cumulative lots of 8 pairs.

jboy
Last edited by jboy on Mon Oct 01, 2012 9:07 am, edited 1 time in total.
User avatar
cuzgeorge
Trader
Posts: 674
Joined: Mon Mar 05, 2012 10:10 am
Location: Johannesburg, South Africa.

Re: Balls to the Wall, a 1 minute 1 trade EA

Post by cuzgeorge »

Hey Jboy, if i may, a leverage of 1:50 is far too low for this kind of EA. If you can try to get a higher leverage crim.
also, you can turn down the risk dramatically or adjust to fixed lots to avoid that problem.
It is as you suspect a crim thing, so hope this helps.
regards
cuz
10.X, BMac,Xmeter,Marylin,and CaptsNakedTrading thread coupled with Slowkeys Intraday setup for manual trades.
http://www.stevehopwoodforex.com/phpBB3 ... f=36&t=848
jboy
Trader
Posts: 57
Joined: Sat Dec 17, 2011 7:18 am

Re: Balls to the Wall, a 1 minute 1 trade EA

Post by jboy »

Yes, I think you are right. I will need to dial down the risk dramatically to run this EA in the US broker. I will probably need to cut down the risk to 0.5% instead of 5%. Shame. It won't really feel like Balls to the Wall. LOL. The CTFC has neutered the balls of US traders.
jth
Trader
Posts: 51
Joined: Sat Dec 17, 2011 7:07 pm

Re: Balls to the Wall, a 1 minute 1 trade EA

Post by jth »

Hi Guys,

Boooooooom Yeah

Basket TP was just hit: for $2479.74 = 10% of capital (Detailed report Attached)
5 pairs were triggered.
Time basket TP reached is: 09;59 local time (11;59 criminal time)
Will be waiting for NY open to setup trades again.
Regards
JTH

jboy wrote:jth,

what leverage are you using on your demo? The EA is generating some huge lots on my criminal (mbtrading) since it says I don't have enough money to open the trades. I'm in the US, so the leverage is at 1:50, perhaps that is the reason...but I don't think that is. I will dig into the code to see if I can fix this. I think I saw someone else who had this problem earlier in the thread. but many others do not have this problem at all, so it may be criminal specific.

jboy
Hi jboy,
i Think to reduce the lot size you need to change the Riskpercent from 5 to say about 2. then your lot size should change. Give that a try.
JTH
You do not have the required permissions to view the files attached to this post.
Locked

Return to “Automated trading systems”