I hope this helps to confirm. Till now, I do not have any AUDNZD nor EURAUD position open as I have set useCorrFilter=True and highCorrelation=80.
Having said that, now I'm having issues with wanting a Sell on AUDNZD after turning the filter off
It doesn't really matter if it returns true or false, the key is that it is exiting the procedure early so it doesn't send the trade. The actual result (true/false) from sendSingleTrade() is being discarded anyway.lucklogic wrote:Is this not incorrectCode: Select all
bool sendSingleTrade( int symbolIndex, int type, string comment, double lotSize, double price, int magicNumber ) { if ( useCorrFilter ) { if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true); } ..............................................
If using the useCorrFilter, the EA is assessing if a prospective order is highly correlated to an existing order BUT if the result is true (that it is highly correlated, so is likely to move in exactly the same direction) THE TRADE is being allowed rather than refused
The result of the argument - if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true);
should return (false) because we do not in affect want to repeat the trade twice
gaheitman wrote:It doesn't really matter if it returns true or false, the key is that it is exiting the procedure early so it doesn't send the trade. The actual result (true/false) from sendSingleTrade() is being discarded anyway.lucklogic wrote:Is this not incorrectCode: Select all
bool sendSingleTrade( int symbolIndex, int type, string comment, double lotSize, double price, int magicNumber ) { if ( useCorrFilter ) { if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true); } ..............................................
If using the useCorrFilter, the EA is assessing if a prospective order is highly correlated to an existing order BUT if the result is true (that it is highly correlated, so is likely to move in exactly the same direction) THE TRADE is being allowed rather than refused
The result of the argument - if ( isCorrelated( symbolNames[symbolIndex] ) ) return (true);
should return (false) because we do not in affect want to repeat the trade twice
George
Looks like it was GBPAUD. There were many (hundreds of) failures, then at 22:35:21 GMT+0 it finally succeeded.Baluda wrote:What trade caused this? Please check your experts tab.