Bob's Biggest Balls Ever

[McNish]

@ Wiggy : Calculations for the pips and points are already dealt with in the code and the user has to input the correct pip value only. Eg. a 5 digit crim will have EU @ 1.33452 whereas a regular 4 digit crim will give the same value as 1.3345. The inputs in the EA however will still be taken as that of a 4 digit crim. So if your 5 digit crim has an sl value of 350, this means a 35 pip sl. Thus if you buy EU at the above value of 1.33452 with your 5 digit crim and SL in the EA is 30 pips, that will reflect as 1.33152 on your terminal trade window. Regarding the error, guess you are on demo. Try a bigger size SL for all kinds ( SL, BE, TSL, JSL), try something greater than 35 pips for 10.3 & 10.2 and see if you still get error. If not, then now you know what the issue might be. Please report back after trying the changes. Hope that clears some doubt.

Edit. My EA is not taking any trades. I don't know what the issue is. If someone can please post a set file that takes trades, that be great help.

[Wiggy1965]

Thanks McNish

[ovisun]

Hi,
Here is a set file which works for me. I use only 10.2A trend, 24 hours trading.
One more thing, to speed up the job, make sure to download enough history for pairs traded.

Regards.
Edit1: even I put scalp on false, just took a scalp trade on eurcad, buy :
Edit2: Luckily it closed quickly with good profit

[fmuir]

Hello,

The "TradeManagementModule" errors are coming from the "ScalpTradeManagementModule (lines 2430-2490)." The OrderModify statement that generates the errors is in a block of code between lines 2475 and 2485.

Error 1 (non-error) is generated when the OrderModify tries to update a TP or SL with the same value.

I had also received a different error messsage , from the same module, the night before last that caused error messages. I forget the number, but the server had accepted the OrderModify.

The most annoying part of these errors is that an Alert pops up on the screen. The Alert and also a Print statement is recorded in the Expert Log.

With regards to having enough historical data for all symbols that you wish to attempt to trade, mbkennel had created a script about a year ago that was well received (over 1260 downloads). Since I haven't figured out how to create a link to point to another post, on a different thread on this board, I will attach the script to this post.

Regards,
-Frank

[ovisun]

Hello,
I'm not so good a programmer, sorry Steve, still, maybe somebody can check why is still taking scalp trades even if they are disabled.
One more scalp now on euraud this time...

Thanks.

[fmuir]

@ovisun
Two variables, scalptrading and trendtrading, should be used within the LookForTradingOpportunities function to control blocks of code. They aren't, therefore that function goes through evey symbol looking for long or short trend trades and long or short scalps, irregardless of what those two variables are set to, every time that it's used.

Regards,
-Frank

[ovisun]

Thanks fmuir,

I've put lines 1389 - 1398 between /*--*/ to ignore them, compiled, no errors and let see, maybe no more scalp trades. I like 24 hours trend trading and one single instance of the EA.
Until now all trend trades were very good for me, some in progress...

Regards.

[fmuir]

@ovisun

The section of coding that you commented out doesn't contain any code that controls whether or not scalping trades are made. It just controls the output message on the screen. With the variable scalptrading set to false, it has the same effect.

Since trading is now closed for the next couple of days, I would suggest that you wait for Steve to address the issue.

Regards,
-Frank

[McNish]

@ Ovisun : Thank you for the set file. Will try it today.

Waiting for the new version from Steve.

[SteveHopwood]

@ovisun
Two variables, scalptrading and trendtrading, should be used within the LookForTradingOpportunities function to control blocks of code. They aren't, therefore that function goes through evey symbol looking for long or short trend trades and long or short scalps, irregardless of what those two variables are set to, every time that it's used.

Regards,
-Frank

Nice spot Frank. I forgot to add this. Fixed in V 1j in post 1.

I came here because I was still having problems with the waiting for all the new candles to open function, so I have added some extra code to break out of the loop after 5 minutes, regardless of whether BBBE thinks all the candles have formed or not. I had not seen these previous posts because I have not been receiving subscription notifications.

Frank, can you see what is wrong with the code you mentioned a few posts back about the order modify errors - I can't?