Bob's Biggest Balls Ever

[Wiggy1965]

Hi Guys,

Has anybody seen this behavior....

i woke up to find the BBBE 1j had open over 20 GBPUSD trend trades....This is odd, given the maxtrades under the trend settings was set to 6....!

By the time i got around to checking everything i decided to close them all, unfortunately for losses...

They all seem to have been open at the same time, which is wild...!

It's seem the trade limit may be ignored....

Wiggy

[trader689]

ah ok i was using h, will try version j now. really wish TISH would label the version numbers.

@trader689,

Did you use the last version from post 1, which is v1j?
Because after I installed the last version there were no more scalp trades for me.

Regards.

[SteveHopwood]

Hi Guys,

Has anybody seen this behavior....

i woke up to find the BBBE 1j had open over 20 GBPUSD trend trades....This is odd, given the maxtrades under the trend settings was set to 6....!

By the time i got around to checking everything i decided to close them all, unfortunately for losses...

They all seem to have been open at the same time, which is wild...!

It's seem the trade limit may be ignored....

Wiggy

Nope. Mine damn well never trades at all. Maybe it is either one or the other.

Joking apart, this is concerning. You wouldn't believe the strength of coding that lies behind stopping this sort of behaviour. We are talking industrial strength by some of the cleverest coders around.

No idea what to do about it, mind, and will not have until it is reproduced on my demo.

[SteveHopwood]

ah ok i was using h, will try version j now. really wish TISH would label the version numbers.

@trader689,

Did you use the last version from post 1, which is v1j?
Because after I installed the last version there were no more scalp trades for me.

Regards.

You could always try reading my damn posts. If you cannot even be arsed to read those, you can expect the occasional bite on the bum. Do you even begin to have any concept of how irritated I get when people show they cannot even be arsed to do this? I will describe it if you want.

Think carefully before you reply; you are on scary ground here.

[Wiggy1965]

Hi Guys,

Has anybody seen this behavior....

i woke up to find the BBBE 1j had open over 20 GBPUSD trend trades....This is odd, given the maxtrades under the trend settings was set to 6....!

By the time i got around to checking everything i decided to close them all, unfortunately for losses...

They all seem to have been open at the same time, which is wild...!

It's seem the trade limit may be ignored....

Wiggy

Nope. Mine damn well never trades at all. Maybe it is either one or the other.

Joking apart, this is concerning. You wouldn't believe the strength of coding that lies behind stopping this sort of behaviour. We are talking industrial strength by some of the cleverest coders around.

No idea what to do about it, mind, and will not have until it is reproduced on my demo.

@Steve,

Just a couple of things, i'm not sure are important, but just to provide a complete picture....

This is a GFT Account...
GFT Servers are set to GMT....I know you hate time talk, but just not sure how important time is to this issue....

I have the same setup on a AXI Demo, and it did not take the trade....

Wiggy

[fmuir]

Hello,

The LookForTradingOpportunities function contains the code that applies the rules to determine if a trend trade or scalp trade should be made! I extracted copies of blocks of code from the LookingForTradingOpportunities function in BBBE v1j. They were placed in separate files, one each for LongTrendTrades 10.2a, ShortTrendTrades 10.2a, LongScalpTrades 10.3 and ShortScalpTrades 10.3. After adding or removing blank lines from one or more of the files, I ran MicroSoft's WinDiff program to compare LongTrendTrades 10.2a against ShortTrendTrades 10.2a and LongScalpTrades 10.3 against ShortScalpTrades 10.3.

The pics that will be included inline in this post, as well as being added as attachments, show the output from MS WinDiff. Trend 1 and Scalp 1 show the rules defined for trend trades and scalp trades respectively. Trend 2 and Scalp 2 show how the rules are applied in a series of 'if' statements to qualify a trade. Any trade that is not qualified will not be made.

Red lines show the lines from LongTrendTrades 10.2a or LongScalpTrades 10.3. Yellow lines show the lines from ShortTrendTrades 10.2a or ShortScalpTrades 10.3. White lines show the lines that are the same in the appropriate files. The line numbers on the left end of the line are the line numbers from the appropriate file.

Two things which will need to be reviewed or checked are:
-- Are the rules for trading either 10.2a and 10.3 correct?
-- Are the rules applied correctly and in the correct order?

As SteveHopwood stated, this EA is humungous. The more eyes that look at this code, the better chance of identifying critical errors! The more errors that can be identified, the quicker this EA can be improved!

The pics follow. I will be following up with another post that will itemize either logic or typographical errors that I have seen.

trend_1.png

trend_2.png

scalp_1.png

scalp_2.png

Regards,
-Frank

[fmuir]

Hello,

Here is the attachment of the pics from the WinDiff output that I referenced in my last post. Sorry, but I had to archive them in a zip file to be able to send them as an attachment. Pics like to add themselves inline when you try attaching them to a post.

Regards,
-Frank

[fmuir]

@ SteveHopwood,
The following code was extracted from the SendSingleTrade function of BBBE v1j:


//Make sure the trade has appeared in the platform's history to avoid duplicate trades.
//My mod of Matt's code attempts to overcome the bastard crim's attempts to overcome Matt's code.
bool TradeReturnedFromCriminal = false;
while (!TradeReturnedFromCriminal)
{
TradeReturnedFromCriminal = O_R_CheckForHistory(ticket);
if (!TradeReturnedFromCriminal)
{
Alert(symbol, " sent trade not in your trade history yet. Turn of this ea NOW.");
}//if (!TradeReturnedFromCriminal)
}//while (!TradeReturnedFromCriminal)

//Got this far, so trade send succeeded
return(true);

}//End bool SendSingleTrade(int type, string comment, double lotsize, double price, double stop, double take)


If this code failed, wouldn't it allow multiple trades of the same symbol? If it allows multiple trades (because of failure), then different brokers might influence how the multiple trades are handled?

Just a thought!

Regards,
-Frank

[fmuir]

@ Wiggy1965,
How many symbols were you attempting to trade at the time that you had multiples trades of GBPUSD open? Is your broker an ECN?

My broker is an ECN. I had multiple trades of the same symbol open at the same time today. However, I was experimenting and had manufactured a trade. The fact that I had multiple trades open, on a demo account, surprised me. But, since I was experimenting, I didn't think too much about it. The reason might or might not be the same.

Regards,
-Frank

[ovisun]

Hi,
On my small live account I have now a buy on eurgbp and on demo a sell for gbpcad. I "transfered" also the trade from demo to live with same magic no. Till now looks good. I'm using 20 pairs.

Regards.