Bob's Biggest Balls Ever

[Wiggy1965]

@ Wiggy1965,
How many symbols were you attempting to trade at the time that you had multiples trades of GBPUSD open? Is your broker an ECN?

My broker is an ECN. I had multiple trades of the same symbol open at the same time today. However, I was experimenting and had manufactured a trade. The fact that I had multiple trades open, on a demo account, surprised me. But, since I was experimenting, I didn't think too much about it. The reason might or might not be the same.

Regards,
-Frank

Hi Frank,

These are the pairs i have configured....

GBPJPY,EURAUD,GBPUSD,EURJPY,AUDJPY,USDJPY,EURUSD,AUDNZD,NZDUSD,AUDUSD,EURGBP

I believe my broker is ECN....i think i mentioned in an earlier post that the broker is GFT....

The EA has traded a number of times both trend and scalp before this happened...

I have turned trend off for the moment until i get some feedback at to what may be causing his....

If you have a close look at the picture i sent, you will notice al trades were open at the same time....The ea also opened a single scalp at the same time...

Regards
Wiggy

I

[fmuir]

...
These are the pairs i have configured....

GBPJPY,EURAUD,GBPUSD,EURJPY,AUDJPY,USDJPY,EURUSD,AUDNZD,NZDUSD,AUDUSD,EURGBP

I believe my broker is ECN....i think i mentioned in an earlier post that the broker is GFT....
...

@ Wiggy1965,
If your setfile says that CriminalIsECN is true (default), then your broker is an ECN.

My question about the symbols that you were trading was meant to find out the number of symbols that you were attempting to trade. If only one or two symbols, then that might contribute to the multiple trades. If over twenty symbols, that wouldn't provide enough time to have multiple trades all showing the same time.

I had added a post (a few before this one) that posed a question to SteveHopwood about what might be causing multiple trades to be allowed. Haven't had a response yet.

Hopefully, we'll see a fix, soon, for the issue of having multiple trades for the same symbol at the same time.

Regards,
-Frank

[McNish]

@ Frank : Hi there, thanks for taking time out to study and post the code. I'm a very basic level programmer with only mix, match capability. I did study the code and the particular trading opportunities section but I wasn't too sure to post anything about it. Since you have made a heads up, I'm more than happy to follow and post my observations. Here's one.
Swaps : In the LookForTradingOpportunities section right before the commented " ///// " conditions, there is TradeLong = true; TradeShort=true; Why reset the boolean value once it is already calculated in the TradeDirectionBySwap section? Will it not override the swap conditions already calculated?

Will post more when I spot them. Regards,

[Lifesys]

McNish
LookForTradingOpportunities() is where the process starts.
As the rest of the lines says, it has not got to filters or Swap yet.
Must start with 'true' by default or there will be no trading at all.
They are being set, NOT reset - code runs in logical order not literal.

Code: Select all

      TradeLong = true; TradeShort=true;  //Defaults. TradeDirectionBySwap() will make any necessary adjustments

[McNish]

OK, So it's just initializing, shouldn't that be done in the void TradeDirectionBySwap section. Sorry, this has got off topic, I thought maybe this is missed but it seems correct with the coders. I guess in this case the void TDBSwap is called after initializing TradeLong, TradeShort.

[Wiggy1965]

Hi Guys,

Can i ask what trade management settings people are using for 10.3 Scalpe....I'm running just a straight 20pip stop and it seems too close....

Any suggesting would be appreciated...

Wiggy

[SteveHopwood]

@ SteveHopwood,
The following code was extracted from the SendSingleTrade function of BBBE v1j:


//Make sure the trade has appeared in the platform's history to avoid duplicate trades.
//My mod of Matt's code attempts to overcome the bastard crim's attempts to overcome Matt's code.
bool TradeReturnedFromCriminal = false;
while (!TradeReturnedFromCriminal)
{
TradeReturnedFromCriminal = O_R_CheckForHistory(ticket);
if (!TradeReturnedFromCriminal)
{
Alert(symbol, " sent trade not in your trade history yet. Turn of this ea NOW.");
}//if (!TradeReturnedFromCriminal)
}//while (!TradeReturnedFromCriminal)

//Got this far, so trade send succeeded
return(true);

}//End bool SendSingleTrade(int type, string comment, double lotsize, double price, double stop, double take)


If this code failed, wouldn't it allow multiple trades of the same symbol? If it allows multiple trades (because of failure), then different brokers might influence how the multiple trades are handled?

Just a thought!

Regards,
-Frank

And a good one. I will look into it.

[SteveHopwood]

@ SteveHopwood,
The following code was extracted from the SendSingleTrade function of BBBE v1j:


//Make sure the trade has appeared in the platform's history to avoid duplicate trades.
//My mod of Matt's code attempts to overcome the bastard crim's attempts to overcome Matt's code.
bool TradeReturnedFromCriminal = false;
while (!TradeReturnedFromCriminal)
{
TradeReturnedFromCriminal = O_R_CheckForHistory(ticket);
if (!TradeReturnedFromCriminal)
{
Alert(symbol, " sent trade not in your trade history yet. Turn of this ea NOW.");
}//if (!TradeReturnedFromCriminal)
}//while (!TradeReturnedFromCriminal)

//Got this far, so trade send succeeded
return(true);

}//End bool SendSingleTrade(int type, string comment, double lotsize, double price, double stop, double take)


If this code failed, wouldn't it allow multiple trades of the same symbol? If it allows multiple trades (because of failure), then different brokers might influence how the multiple trades are handled?

Just a thought!

Regards,
-Frank

I had a look frank, and no. The point of the while (!TradeReturnedFromCriminal){} snippet is to drive the user nuts with repeated alerts to attract the user's attention, because it will not stop calling the O_R_CheckForHistory(ticket); function.

Extra layers of security never do any harm, so I will add to this. I will add code to suspend trading but allow management should some strange concatenation of events cause this to fail. Can't see how, and Matt is an exceptionally clever programmer with levels of understanding way, way beyond mine but hey, I can add an extra layer so why not?

[fmuir]

... Why reset the boolean value once it is already calculated in the TradeDirectionBySwap section? Will it not override the swap conditions already calculated? ...

LookForTradingOpportunities() calls IsTradingAllowed() which will call TradeDirectionBySwap() only for trend trades. TradeLong and TradeShort will be set in TradeDirectionBySwap only if the variables CadPairsPositiveOnly, AudPairsPositiveOnly, NZDPairsPositiveOnly or OnlyTradePositiveSwap had been set to true in the setfile. TradeLong or TradeShort could conceivably be in the wrong state if they weren't re-initialized to true in LookForTradingOpportunites, which could affect whether trend trades or scalp trades are made. And, remember, this EA is trading multiple pairs (usually). The location where they are initialized is correct, which is just prior to them being changed (if necessary), just prior to them being used.

... SL of 20 is too tight ...

I haven't had enough trades to really be able to judge the effectiveness of the SL that this EA places. Hopefully, improvements will come.

Regards,
-Frank

[fmuir]

... If this code failed, wouldn't it allow multiple trades of the same symbol? If it allows multiple trades (because of failure), then different brokers might influence how the multiple trades are handled?

Just a thought!

Regards,
-Frank

I had a look frank, and no. The point of the while (!TradeReturnedFromCriminal){} snippet is to drive the user nuts with repeated alerts to attract the user's attention, because it will not stop calling the O_R_CheckForHistory(ticket); function.

Extra layers of security never do any harm, so I will add to this. I will add code to suspend trading but allow management should some strange concatenation of events cause this to fail. Can't see how, and Matt is an exceptionally clever programmer with levels of understanding way, way beyond mine but hey, I can add an extra layer so why not?

@ SteveHopwood,

Thanks for the response.

Regards,
-Frank