Slopey Graeme: another pipEasy-inspired trend trading EA

[gaheitman]

Ehup guys

Just starting to catch up after 4 extremely frustrating days without an internet connection.

Re the possible missing bars thingy, the version in post 1 that I uploaded last Thursday includes the iBars thingy. In int init()

Code: Select all

//This forces the platform to 2048 bars of data - necessary if this is a new Empty4 installation
   iBars(NULL, Period() );

This should do the trick unless I have misunderstood George's post about this.

You'll actually need to call it for any time frame you are referencing. The user may have it on an hourly chart but using the daily RSI, so you'd want to call (in this care):

Code: Select all

iBars(NULL,RsiTdTf);

George

[MichaelM]

mbkennel's script to force download all data works like a charm (check your PM from Steve)

[SteveHopwood]

Ehup guys

Just starting to catch up after 4 extremely frustrating days without an internet connection.

Re the possible missing bars thingy, the version in post 1 that I uploaded last Thursday includes the iBars thingy. In int init()

Code: Select all

//This forces the platform to 2048 bars of data - necessary if this is a new Empty4 installation
   iBars(NULL, Period() );

This should do the trick unless I have misunderstood George's post about this.

You'll actually need to call it for any time frame you are referencing. The user may have it on an hourly chart but using the daily RSI, so you'd want to call (in this care):

Code: Select all

iBars(NULL,RsiTdTf);

George

Cheers George. It looks as though Matt might be ahead of all of us. I hope so.

[MichaelM]

Hi Steve,

I've noticed today that quite a few of the pairs I've put Graeme on don't have the Pending Price Line drawn on the chart even though the Overall Trend says either "Up" or "Down".

Looked in the Objects list on each chart and there's nothing there.

Using Graeme OOTB

EDIT: I figured it out... in LookForTradingOpportunities() it uses the RsiBuffer whereas in the TrendDetectionModule it does not.

So you can either set the RsiBuffer = 0 or fix the TrendDetectionModule code as follows:

Code: Select all

//Rsi. This one is scooby-doo's suggestion and is based on a 20 period D1 Rsi.
   if (UseRsiTrendDetection)
   {
      RsiTrend = ranging;
      TrendRsiVal = GetRsi(RsiTdTf, RsiTdPeriod, RsiTdAppliedPrice, 0);
      if (TrendRsiVal > 55 + RsiBuffer) RsiTrend = up;
      if (TrendRsiVal < 45 - RsiBuffer) RsiTrend = down;
      if (RsiIsMaster) OverallTrend = RsiTrend;
   }//if (UseRsiTrendDetection)

[MichaelM]

Another coding error in LookForTradingOpportunities():

Code: Select all

   //Short
   if (OverallTrend == down)
   {
      if (!TradeShort) return;

      //Big number filter
      if (RoundNumberHigh == BigNumberHigh && !TradeBigNumbers) return;

...should be...

Code: Select all

   //Short
   if (OverallTrend == down)
   {
      if (!TradeShort) return;

      //Big number filter
      if (RoundNumberLow == BigNumberLow && !TradeBigNumbers) return;

[MichaelM]

Another one in GetNextRoundNumbers():

Because High[0] could be above the real next High Round Number, but the market price is actually below it:

//Finds the nearest big numbers to the market price.
//Saves these in RoundNumberHigh and RoundNumberLow, BigNumberHigh and BigNumberLow.
//George provided this code, so thanks again George.

Code: Select all

   double price = High[0];

...should be...

Code: Select all

   double price = Bid;

[scalpz]

Another one in GetNextRoundNumbers():
...

Code: Select all

   double price = Bid;

3 real good posts MichealM keep up the good work.

Have updated my altered copy of Graeme.
I have named my copy millimanual as that is what I am trying to get it to do.
ie. nothing - until I spot some relavent price action, generally at reverses.
Then build like hell with closer trades & sl's.
Only 2 trades not in the green at once.


cheers scalpz

[MichaelM]

Thanks scalpz... I'll try my best

EDIT: That last suggested fix I posted might have broken G - I had heaps of AUDUSD trades triggered, while it was bouncing around the 1.04 area.
Still doesn't explain why it didn't do it for the other pairs that were bouncing around their round numbers.

So for now to get the best results leave the code as it was, but change your TF to M1 to get the most accurate next High/Low Round Numbers.

[SteveHopwood]

Hi Steve,

I've noticed today that quite a few of the pairs I've put Graeme on don't have the Pending Price Line drawn on the chart even though the Overall Trend says either "Up" or "Down".

Looked in the Objects list on each chart and there's nothing there.

Using Graeme OOTB

EDIT: I figured it out... in LookForTradingOpportunities() it uses the RsiBuffer whereas in the TrendDetectionModule it does not.

So you can either set the RsiBuffer = 0 or fix the TrendDetectionModule code as follows:

Code: Select all

//Rsi. This one is scooby-doo's suggestion and is based on a 20 period D1 Rsi.
   if (UseRsiTrendDetection)
   {
      RsiTrend = ranging;
      TrendRsiVal = GetRsi(RsiTdTf, RsiTdPeriod, RsiTdAppliedPrice, 0);
      if (TrendRsiVal > 55 + RsiBuffer) RsiTrend = up;
      if (TrendRsiVal < 45 - RsiBuffer) RsiTrend = down;
      if (RsiIsMaster) OverallTrend = RsiTrend;
   }//if (UseRsiTrendDetection)

Thanks, but the Rsi used in trend detection detects the trend. The filter in LookForTradingOpps uses the extra filter to avoid chop. The change you describe is unnecessary.

[SteveHopwood]

Another coding error in LookForTradingOpportunities():

Code: Select all

   //Short
   if (OverallTrend == down)
   {
      if (!TradeShort) return;

      //Big number filter
      if (RoundNumberHigh == BigNumberHigh && !TradeBigNumbers) return;

...should be...

Code: Select all

   //Short
   if (OverallTrend == down)
   {
      if (!TradeShort) return;

      //Big number filter
      if (RoundNumberLow == BigNumberLow && !TradeBigNumbers) return;

Fabulous. Thanks. This is one of my famous copy/paste bloops.

This is fixed in post 1, guys, and is an essential fix.