Hi Jose Luis, Thank You very much. Utility is working as it should!!! Now optimal position size/acct. balance/EquityProtection parameters must be calculated. Will do my best...Pippojlcgarcia wrote:Pippopotamus wrote:Hi Jose Luis, Not yet... Marcello, M30, and H1 are candidates... Pippo
Hi Pippo,
I have backtested this one, and it does what it has to do (close orders, and stop trading).
Take a look and tell me.
Regards
José Luis
The New Beast!
- Pippopotamus
- Trader
- Posts: 70
- Joined: Wed Nov 16, 2011 2:32 pm
- Location: NY/NJ Metro Area
Re: The New Beast!
Trading is Art
- Pippopotamus
- Trader
- Posts: 70
- Joined: Wed Nov 16, 2011 2:32 pm
- Location: NY/NJ Metro Area
Re: The New Beast!
Here is a good pass...Jan 09'-Jan 12'... 3 years. 1 micro/$1500, protecting 30% of acct. bal. EquityProtection never came into play. Open trades were simply closed at end of test. When viewing this result it is important to keep in mind that output from Empty4 strat tester is, in the opinion of many, less than completely trustworthy.
You do not have the required permissions to view the files attached to this post.
Trading is Art
-
thor68
- Posts: 4
- Joined: Wed Nov 16, 2011 12:50 am
Re: The New Beast!
Pippo:Pippopotamus wrote:Here is a good pass...Jan 09'-Jan 12'... 3 years. 1 micro/$1500, protecting 30% of acct. bal. EquityProtection never came into play. Open trades were simply closed at end of test. When viewing this result it is important to keep in mind that output from Empty4 strat tester is, in the opinion of many, less than completely trustworthy.
Is that OOTB?
If no, could you post the set file?
- Pippopotamus
- Trader
- Posts: 70
- Joined: Wed Nov 16, 2011 2:32 pm
- Location: NY/NJ Metro Area
Re: The New Beast!
H1, no WhiteBoxTrading, close at Gold, Trailing Stop=1, automate TS choice=1, and variables=1, Rsi at 60/13, 1,2,6 recovery, use CBI=0. These settings are not recommendations, just those I am testing ATM... Pippothor68 wrote:Pippo:Pippopotamus wrote:Here is a good pass...Jan 09'-Jan 12'... 3 years. 1 micro/$1500, protecting 30% of acct. bal. EquityProtection never came into play. Open trades were simply closed at end of test. When viewing this result it is important to keep in mind that output from Empty4 strat tester is, in the opinion of many, less than completely trustworthy.
Is that OOTB?
If no, could you post the set file?
Trading is Art
- Pippopotamus
- Trader
- Posts: 70
- Joined: Wed Nov 16, 2011 2:32 pm
- Location: NY/NJ Metro Area
Re: The New Beast!
'Into each life some rain must fall,'.....
You do not have the required permissions to view the files attached to this post.
Trading is Art
- KingHigh
- Posts: 6
- Joined: Sun Nov 27, 2011 5:52 am
- Location: The Left Coast Of America
Re: The New Beast! Code Review Question
Pippo,
Firstly, I commend you for picking up this thread and revitalizing it. Great job.
I am going through the code to figure out how the recovery and hedge works. Was looking at this function and found that the handling of Buys and Sells is not symetrical. Take a look. I believe that both should be set to TRUE in this function. Look for "////////////////////".
Just a nit: Also - as noted these variables are set as externs and initialize = false. Probably should just be global vars initialized.
void CalculateTradeClosureLine( int type )
{
close_trade_at_gold = false;// No need to be an extern
close_trade_at_green = false;// No need to be an extern
close_trade_at_middle_white = false;// No need to be an extern
close_box_trade_at_magenta = false;// No need to be an extern
close_box_trade_at_gold = false;// No need to be an extern
trail_box_trade_at_magenta = false;// No need to be an extern
trail_box_trade_at_gold = false;// No need to be an extern
//Low
if( type == OP_BUY )
{
if( rsi_val <= 45 )
{
close_trade_at_gold = true;
close_box_trade_at_gold = true;
}
if( rsi_val > 45 && rsi_val < 55 )
{
close_trade_at_green = true;
close_box_trade_at_magenta = true;
}
if( rsi_val >= 55 )
{
close_trade_at_middle_white = true;
trail_box_trade_at_gold = true; ///////////////////////////////
}
}
if( type == OP_SELL )
{
if( rsi_val <= 45 )
{
close_trade_at_middle_white = true;
trail_box_trade_at_gold = false; //////////////////////////////
}
if( rsi_val > 45 && rsi_val < 55 )
{
close_trade_at_green = true;
close_box_trade_at_magenta = true;
}
if( rsi_val >= 55 )
{
close_trade_at_gold = true;
close_box_trade_at_gold = true;
}
}
}//void CalculateTradeClosureLine()
Firstly, I commend you for picking up this thread and revitalizing it. Great job.
I am going through the code to figure out how the recovery and hedge works. Was looking at this function and found that the handling of Buys and Sells is not symetrical. Take a look. I believe that both should be set to TRUE in this function. Look for "////////////////////".
Just a nit: Also - as noted these variables are set as externs and initialize = false. Probably should just be global vars initialized.
void CalculateTradeClosureLine( int type )
{
close_trade_at_gold = false;// No need to be an extern
close_trade_at_green = false;// No need to be an extern
close_trade_at_middle_white = false;// No need to be an extern
close_box_trade_at_magenta = false;// No need to be an extern
close_box_trade_at_gold = false;// No need to be an extern
trail_box_trade_at_magenta = false;// No need to be an extern
trail_box_trade_at_gold = false;// No need to be an extern
//Low
if( type == OP_BUY )
{
if( rsi_val <= 45 )
{
close_trade_at_gold = true;
close_box_trade_at_gold = true;
}
if( rsi_val > 45 && rsi_val < 55 )
{
close_trade_at_green = true;
close_box_trade_at_magenta = true;
}
if( rsi_val >= 55 )
{
close_trade_at_middle_white = true;
trail_box_trade_at_gold = true; ///////////////////////////////
}
}
if( type == OP_SELL )
{
if( rsi_val <= 45 )
{
close_trade_at_middle_white = true;
trail_box_trade_at_gold = false; //////////////////////////////
}
if( rsi_val > 45 && rsi_val < 55 )
{
close_trade_at_green = true;
close_box_trade_at_magenta = true;
}
if( rsi_val >= 55 )
{
close_trade_at_gold = true;
close_box_trade_at_gold = true;
}
}
}//void CalculateTradeClosureLine()
- Pippopotamus
- Trader
- Posts: 70
- Joined: Wed Nov 16, 2011 2:32 pm
- Location: NY/NJ Metro Area
Re: The New Beast! Code Review Question
Glad to see you here KH, hope you have the inclination to participate... PippoKingHigh wrote:Pippo,
Firstly, I commend you for picking up this thread and revitalizing it. Great job.
I am going through the code to figure out how the recovery and hedge works. Was looking at this function and found that the handling of Buys and Sells is not symetrical. Take a look. I believe that both should be set to TRUE in this function. Look for "////////////////////".
Just a nit: Also - as noted these variables are set as externs and initialize = false. Probably should just be global vars initialized.
void CalculateTradeClosureLine( int type )
{
close_trade_at_gold = false;// No need to be an extern
close_trade_at_green = false;// No need to be an extern
close_trade_at_middle_white = false;// No need to be an extern
close_box_trade_at_magenta = false;// No need to be an extern
close_box_trade_at_gold = false;// No need to be an extern
trail_box_trade_at_magenta = false;// No need to be an extern
trail_box_trade_at_gold = false;// No need to be an extern
//Low
if( type == OP_BUY )
{
if( rsi_val <= 45 )
{
close_trade_at_gold = true;
close_box_trade_at_gold = true;
}
if( rsi_val > 45 && rsi_val < 55 )
{
close_trade_at_green = true;
close_box_trade_at_magenta = true;
}
if( rsi_val >= 55 )
{
close_trade_at_middle_white = true;
trail_box_trade_at_gold = true; ///////////////////////////////
}
}
if( type == OP_SELL )
{
if( rsi_val <= 45 )
{
close_trade_at_middle_white = true;
trail_box_trade_at_gold = false; //////////////////////////////
}
if( rsi_val > 45 && rsi_val < 55 )
{
close_trade_at_green = true;
close_box_trade_at_magenta = true;
}
if( rsi_val >= 55 )
{
close_trade_at_gold = true;
close_box_trade_at_gold = true;
}
}
}//void CalculateTradeClosureLine()
Last edited by Pippopotamus on Fri May 17, 2013 7:36 pm, edited 1 time in total.
Trading is Art
- Pippopotamus
- Trader
- Posts: 70
- Joined: Wed Nov 16, 2011 2:32 pm
- Location: NY/NJ Metro Area
Re: The New Beast!
King High, I made Buy/Sell correction you suggested above. I have noted since day 1 with this BOT that Magenta line closure style will always be Auto Calc'd regardless of setting(i.e., I have...close trade at gold selected, but EA will auto calc anyway). BTW, Usd/Chf still stubbornly unrepentant...
You do not have the required permissions to view the files attached to this post.
Last edited by Pippopotamus on Fri May 17, 2013 7:37 pm, edited 1 time in total.
Trading is Art
-
jlcgarcia
Re: The New Beast!
Pippopotamus wrote:King High, I made Buy/Sell correction you suggested above. I have noted since day 1 with this BOT that Magenta line closure style will always be Auto Calc'd regardless of setting(i.e., I have...close trade at gold selected, but EA will auto calc anyway). Does that have anything to do with the extern/global var issue you referred to above? Any Ideas for remedy? ...BTW, Usd/Chf still stubbornly unrepentant...
Hi Pippo,
try these version. I have corrected the AutoCalc. If you choose AutoCalc false, you must select a line for closing.
Regards
José Luis
You do not have the required permissions to view the files attached to this post.
- Pippopotamus
- Trader
- Posts: 70
- Joined: Wed Nov 16, 2011 2:32 pm
- Location: NY/NJ Metro Area
Re: The New Beast!
Jose Luis, Thank you once again. Will change EA after current trades are resolved. Thank You, and Best Wishes for this new trading week.......Pjlcgarcia wrote:Pippopotamus wrote:King High, I made Buy/Sell correction you suggested above. I have noted since day 1 with this BOT that Magenta line closure style will always be Auto Calc'd regardless of setting(i.e., I have...close trade at gold selected, but EA will auto calc anyway). Does that have anything to do with the extern/global var issue you referred to above? Any Ideas for remedy? ...BTW, Usd/Chf still stubbornly unrepentant...
Hi Pippo,
try these version. I have corrected the AutoCalc. If you choose AutoCalc false, you must select a line for closing.
Regards
José Luis
Trading is Art