ChangeTheColor EA

Post Reply
MiTija

Re: ChangeTheColor EA

Post by MiTija »

ROBST3R wrote:here you go, 1.35
Thank you!

Best Regards,


MiTija
skoda2008
Trader
Posts: 60
Joined: Wed Nov 16, 2011 12:20 am

Re: ChangeTheColor EA

Post by skoda2008 »

I have been running version 1.38 for the last few days. I noticed a few orders were slipping through with no stoploss applied. It turns out there is a small typo in the InsertStopLoss module, a small typo which could potentially cost you $$$!

Code: Select all

if (OrderType() == OP_BUY)
   {
      stop = CalculateStopLoss(OP_SELL);
   }//if (OrderType() == OP_BUY)
   
Should be changed to:

Code: Select all

if (OrderType() == OP_BUY)
   {
      stop = CalculateStopLoss(OP_BUY);
   }//if (OrderType() == OP_BUY)
   
Otherwise you may end up with no stoploss applied to some Buy orders, as I was experiencing.
magft
Trader
Posts: 195
Joined: Tue Nov 15, 2011 9:59 pm
Location: East Midlands, UK

Re: ChangeTheColor EA

Post by magft »

skoda2008 wrote:I have been running version 1.38 for the last few days. I noticed a few orders were slipping through with no stoploss applied. It turns out there is a small typo in the InsertStopLoss module, a small typo which could potentially cost you $$$!

Code: Select all

if (OrderType() == OP_BUY)
   {
      stop = CalculateStopLoss(OP_SELL);
   }//if (OrderType() == OP_BUY)
   
Should be changed to:

Code: Select all

if (OrderType() == OP_BUY)
   {
      stop = CalculateStopLoss(OP_BUY);
   }//if (OrderType() == OP_BUY)
   
Otherwise you may end up with no stoploss applied to some Buy orders, as I was experiencing.
Oops! I havent done anything with that code from the Shell so something to watch for in other EAs maybe? I'll update and send out a fix in a bit. Nice catch!

Mike
skoda2008
Trader
Posts: 60
Joined: Wed Nov 16, 2011 12:20 am

Re: ChangeTheColor EA

Post by skoda2008 »

I'm still getting a few orders with no stoploss. It looks like there is still some contention when orders try and open at the same time, even with the global variable thing going on. The orders open okay, but when they are modified to take the stop loss (2 stage crim) only one of them ends up with a SL, the other stays at zero. The log isn't showing any errors, the EA just appears not to be sending the request? I will see if I can decipher the code and figure out what is (or isn't) happening...
magft
Trader
Posts: 195
Joined: Tue Nov 15, 2011 9:59 pm
Location: East Midlands, UK

Re: ChangeTheColor EA

Post by magft »

Update in Post #1
trader689
Trader
Posts: 674
Joined: Thu Nov 17, 2011 12:53 am

Re: ChangeTheColor EA

Post by trader689 »

hey magft does this latest update also fix this following error, referring to v1.38? -

"Weird activity this morning. I had several trades open up that were totally backwards. Buy orders when candles were all well below MA"


thanks
magft wrote:Update in Post #1
magft
Trader
Posts: 195
Joined: Tue Nov 15, 2011 9:59 pm
Location: East Midlands, UK

Re: ChangeTheColor EA

Post by magft »

trader689 wrote:hey magft does this latest update also fix this following error, referring to v1.38? -

"Weird activity this morning. I had several trades open up that were totally backwards. Buy orders when candles were all well below MA"


thanks
magft wrote:Update in Post #1
It should do :roll:
Rascacio
Trader
Posts: 11
Joined: Tue Nov 15, 2011 10:33 pm

Re: ChangeTheColor EA

Post by Rascacio »

magft wrote:
trader689 wrote:hey magft does this latest update also fix this following error, referring to v1.38? -

"Weird activity this morning. I had several trades open up that were totally backwards. Buy orders when candles were all well below MA"


thanks
magft wrote:Update in Post #1
It should do :roll:
Hi magft, I have the latest version and I have had 8 trades all losers and all appear to placed back to front.

I can't figure it out. Anyone else with obviously reversed trades ?
User avatar
spyderman
Trader
Posts: 338
Joined: Sun Dec 11, 2011 1:39 pm

Re: ChangeTheColor EA

Post by spyderman »

Rascacio wrote: Hi magft, I have the latest version and I have had 8 trades all losers and all appear to placed back to front.

I can't figure it out. Anyone else with obviously reversed trades ?
I'm not getting back to fronts, just losing trades... :| Like 80% loosers. Don't know if it's the market but I haven't been doing well since version 1.35. Might try going back to that. ???
Snaggin' some pips
Walking Hell
Posts: 1
Joined: Mon Jan 16, 2012 10:33 pm

Re: ChangeTheColor EA

Post by Walking Hell »

project still alive? :shock:
Post Reply

Return to “Automated trading systems”