we could change the variablename from lwma60 to ma1 and lwma240 to ma2. But there is no need to do so I think ...
I changed the IsTesting-stuff also, it is now checked in the start()-function ...
Further I changed the function-type from 'int GetOuterBuff(...)' to 'double GetOuterBuff(...)' and modified the ea to calculate the Adr not only in the init()-function, but in the start()-part also (Although it is calculated on a daily base it imho should be updated) ....
I've updated the post with the latest version http://www.stevehopwoodforex.com/phpBB3 ... 900#p76900
HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
- fxdaytrader
- Trader
- Posts: 190
- Joined: Sun Jun 10, 2012 7:03 am
- Location: Poon-Town (germany, se-asia, se-europe) ...
-
fx800
- Trader
- Posts: 1334
- Joined: Sun Dec 04, 2011 4:11 am
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
Without the change, how does the ea calculate the values for ma1 and ma2 ?we could change the variablename from lwma60 to ma1 and lwma240 to ma2. But there is no need to do so I think ...
As for the line
if ma1 > ma2, and price > ma1, price is automatically > ma2.(price > ma1 && price > ma2 && ma1 > ma2)
So, is price > ma2 necessary ?
Last question, without the graphic user interface, does it mean the buttons on the dashboard will not work properly.
You are the expert, I am still learning.
- fxdaytrader
- Trader
- Posts: 190
- Joined: Sun Jun 10, 2012 7:03 am
- Location: Poon-Town (germany, se-asia, se-europe) ...
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
the (current) last function in the ea (so scroll down to the end) does the job.fx8000 wrote: Without the change, how does the ea calculate the values for ma1 and ma2 ?
so when calling the function, the ma-values are passed to it.
I have changed that, so price > ma2/price< ma2 ist not necessary anymore.fx8000 wrote: Without the change, how does the ea calculate the values for ma1 and ma2 ?
(...)So, is price > ma2 necessary ?(price > ma1 && price > ma2 && ma1 > ma2)
fx8000 wrote: Last question, without the graphic user interface, does it mean the buttons on the dashboard will not work properly.
I will upoload a mt4gui-version with the latest changes later today in this post:
http://www.stevehopwoodforex.com/phpBB3 ... 900#p76900
-
fx800
- Trader
- Posts: 1334
- Joined: Sun Dec 04, 2011 4:11 am
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
Many thanks. There is absolutely no hurry. I will use the noGui version until the other one is ready.fxdaytrader wrote:the (current) last function in the ea (so scroll down to the end) does the job.fx8000 wrote: Without the change, how does the ea calculate the values for ma1 and ma2 ?
so when calling the function, the ma-values are passed to it.
I have changed that, so price > ma2/price< ma2 ist not necessary anymore.fx8000 wrote: Without the change, how does the ea calculate the values for ma1 and ma2 ?
(...)So, is price > ma2 necessary ?(price > ma1 && price > ma2 && ma1 > ma2)
fx8000 wrote: Last question, without the graphic user interface, does it mean the buttons on the dashboard will not work properly.right. No mt4gui, no buttons.
I will upoload a mt4gui-version with the latest changes later today in this post:
http://www.stevehopwoodforex.com/phpBB3 ... 900#p76900
Is it possible now to use Empty4 to back test the ea now even though it is a basket ea ?
- fxdaytrader
- Trader
- Posts: 190
- Joined: Sun Jun 10, 2012 7:03 am
- Location: Poon-Town (germany, se-asia, se-europe) ...
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
When testing the EA it sets "CurrentPair = Symbol()", so that should do that.fx8000 wrote: Is it possible now to use Empty4 to back test the ea now even though it is a basket ea ?
Nevertheless I assume that backtesting is not possible (and/or misleading) because the EA looks to different timeframes (but I have to admit that I do not know how the craptester exactly works).
-
fx800
- Trader
- Posts: 1334
- Joined: Sun Dec 04, 2011 4:11 am
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
OK. I am not keen on BT, only to check if an ea is entering trades correctly.fxdaytrader wrote:When testing the EA it sets "CurrentPair = Symbol()", so that should do that.fx8000 wrote: Is it possible now to use Empty4 to back test the ea now even though it is a basket ea ?
Nevertheless I assume that backtesting is not possible (and/or misleading) because the EA looks to different timeframes (but I have to admit that I do not know how the craptester exactly works).
BT to check if an ea is profitable or not is a futile exercise and complete waste of time.
Don't ever mention the the BT word in front of Steve. He will have you for breakfast.
Last edited by Anonymous on Sun Sep 29, 2013 11:41 am, edited 1 time in total.
- fxdaytrader
- Trader
- Posts: 190
- Joined: Sun Jun 10, 2012 7:03 am
- Location: Poon-Town (germany, se-asia, se-europe) ...
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
ok, post http://www.stevehopwoodforex.com/phpBB3 ... 900#p76900 updated with a mt4gui-version.
I am looking forward to your test with the new version tomorrow (and if you have got the time, could you check if the SL is set correct now?, maybe it does since we changed som variabletypes from int to double) ...

I am looking forward to your test with the new version tomorrow (and if you have got the time, could you check if the SL is set correct now?, maybe it does since we changed som variabletypes from int to double) ...
-
fx800
- Trader
- Posts: 1334
- Joined: Sun Dec 04, 2011 4:11 am
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
Thanks, will do.fxdaytrader wrote:ok, post http://www.stevehopwoodforex.com/phpBB3 ... 900#p76900 updated with a mt4gui-version.
I am looking forward to your test with the new version tomorrow (and if you have got the time, could you check if the SL is set correct now?, maybe it does since we changed som variabletypes from int to double) ...
- fxdaytrader
- Trader
- Posts: 190
- Joined: Sun Jun 10, 2012 7:03 am
- Location: Poon-Town (germany, se-asia, se-europe) ...
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
fx800 came up with one more suggestion - Using of pending stoporders and a improvement regarding the entries (see also BASA with pendingorders-thread).
We will implement this soon
We will implement this soon
-
fx800
- Trader
- Posts: 1334
- Joined: Sun Dec 04, 2011 4:11 am
Re: HELP TO ADD ATR STOP LOSS TO MULTI 10.4 TRADER
Watch this space.fxdaytrader wrote:fx800 came up with one more suggestion - Using of pending stoporders and a improvement regarding the entries (see also BASA with pendingorders-thread).
We will implement this soon
I have asked Fxdaytrader if he could modify the ea to enter a trade ONLY at the daily pivot rather than at a series of pivot lines, be it weekly pivots or daily pivots which I prefer.
It is my belief that the best entry is at the beginning of a move when price crosses THE daily pivot(not a midpivot, DS1/DR1, etc). Quite often, I see trades entered when price has travelled a long distance from the DP, then quite predictably, it retraces and ends up in a drawdown.
It is interesting to test this idea with an ea.