Bob and Shelley Again

[fxozgirl]

So with that in mind, is Dave's suggestion able to be incorporated into the EA for both main & re-entry trades as some extra protection without affecting the existing money management features?

Done. V 1y in post 1.

BASA runs the check at the open of the second candle after the trade candle, and only if the trade is not in profit.

I think this GBPAUD trade should be closed in accordance with Dave's rules just now...does anyone have this trade and did it close?

gbpaudh4_tradenotclosed_131002.png

[spotdespot]

I agree Shelley - with what I envisaged this should have closed on the close of the previous candle/open of the latest candle (not sure coding-wise which way it works).

I don't think I had this trade but I saw a suspicious one earlier but have been so snowed under today I didn't have time to confirm. I will check in the morning.

Cheers,
Dave.

[fxozgirl]

I agree Shelley - with what I envisaged this should have closed on the close of the previous candle/open of the latest candle (not sure coding-wise which way it works).

I don't think I had this trade but I saw a suspicious one earlier but have been so snowed under today I didn't have time to confirm. I will check in the morning.

Cheers,
Dave.

Thanks Dave...according to Steve's post, the check is run at the open of the current candle (2nd candle after the trade open candle)

[SteveHopwood]

OK guys, V2 is in post 1. I had coded Dave's closure filter when open trades = 0, not 1 (we don't want this filter when there is a basket open, hence when open trades = 1).

Fixed in V2.

Here is where thingies get potentially messy and I need you guys to stay on top of this for me. It really is in your best interests to do so.

I code on my coding machine, which is an old desktop in my living room. It was a state of the art Mean Machine when I built it, but that was a few years ago. These days, it takes about 10 minutes to get going from start up.

Then I have this always-on trading lappy in my music room.

Disaster always follows if I code on my lappy because I always forget to transfer said coding to my coding machine.

Thing is, is is late here in the UK and my coding machine is turned off. Worse still, I forgot to transfer fxdaytrader's updates to it. So, instead I have just downloaded his fixes to my trading machine BASA demo and added the fix for Dave's thingy and uploaded it to post 1 here.

So, in the morning I need to download V2 from post 1 here onto my coding machine in the morning.

Trouble is, I have had a couple of drinkies and am about to add a third. Then I have to go out in the morning. The chances of me remembering all this are not good.

So, from about 13.00 gmt on Wednesday, could a few of you guys send me pm's along the lines of, "Ehup dimwit. Download BASA V2 to your coding machine so you don't cause chaos. AGAIN." Gives you all the perfect opportunity to insult me without risking a ban.

Hehe.In the time it took to type this I could have cranked up the coding machine and done the necessary. Trouble is, in the time it took to crank up I would have forgotten why it was cranking up. Then I would have answered a couple of emails, remembered to check on the state of my bank balance, looked to see if anything interesting was happening in the cricket world.................. The one thing I would not have done is what I cranked the damn thing up for in the first place.

Then forgotten I had not downloaded V2 from post 1................................................

Be VERY GLAD you do not occupy a part of my world.

[SteveHopwood]

V 2a is in post 1.

My subconscious carried on working overnight and I awoke with the realisation that spotdespot's candle closure code was in the wrong place.

I have moved it to CountOpenTrades() but after the loop that does the counting, so BASA knows there is only 1 trade open when the code is run.

All done from my coding machine as well, so no need for the reminders.

[fxozgirl]

V 2a is in post 1.

My subconscious carried on working overnight and I awoke with the realisation that spotdespot's candle closure code was in the wrong place.

I have moved it to CountOpenTrades() but after the loop that does the counting, so BASA knows there is only 1 trade open when the code is run.

All done from my coding machine as well, so no need for the reminders.

Thanks Steve...I was just about ready to send your reminder

[plateman]

You have disappointed thousands of members this morning Steve. ("Gives you all the perfect opportunity to insult me without risking a ban.") :>))

Just shows the difficulty in trying to make rules that cover many situations, that GBPAUD trade that "should have closed" reversed and is now well in profit.

[milanese]

Thanks Steve...I was just about ready to send your reminder

me too , thanks great Steve as always!!

Cheers
Tommaso

[fxozgirl]

You have disappointed thousands of members this morning Steve. ("Gives you all the perfect opportunity to insult me without risking a ban.") :>))

Just shows the difficulty in trying to make rules that cover many situations, that GBPAUD trade that "should have closed" reversed and is now well in profit.

Yes it has, so we were lucky...
Most of my analysis shows this function will save us more than we will lose...unfortunately we will miss the odd winner from time to time

[spotdespot]

Just shows the difficulty in trying to make rules that cover many situations, that GBPAUD trade that "should have closed" reversed and is now well in profit.

Yes it has, so we were lucky...
Most of my analysis shows this function will save us more than we will lose...unfortunately we will miss the odd winner from time to time

Yes - I just checked and, with the setup I have, there were 4 trades yesterday that should have closed that didn't (and went on to hit full SL) so you can't look at a single trade in isolation.

Cheers,
Dave.