4 Ducks

[OldTrader]

yes, sorry, my mistake. used wrong editor to open

[SteveHopwood]

V 1c is in post 1. I noticed some strange behaviour when starting up, and found a line of code that needed moving.

To make the change yourself, go to int init() and find this line of code

Code: Select all

ReadIndicatorValues();

Cut and paste this to just above

Code: Select all

CountOpenTrades();

so the snippet reads:

Code: Select all

ReadIndicatorValues();
CountOpenTrades();

then recompile.

[RxCape]

I keep getting rogue trades. I have left the rogue trade parameters in the settings as OOTB, i.e 0 & 1. I cannot figure out why I keep getting these trades. Any suggestions would be appreciated.

[SpiderX]

I keep getting rogue trades. I have left the rogue trade parameters in the settings as OOTB, i.e 0 & 1. I cannot figure out why I keep getting these trades. Any suggestions would be appreciated.

Seems to be the same for me here.

Cheers

[SteveHopwood]

Read the 'Safety Feature' section of the BASA user guide.

I am trying to work out why the damn trades are closing so quickly.

[SteveHopwood]

V 1d is in post 1, with attempted fixes for possible problems causing trades to close as soon as they open.

Colders, bool LookForTradeClosure(int ticket) is the relevant function. I had forgotten to explicitly declare CloseThisTrade as false. Default declarations are unreliable in crapql4. This fault was in my shell code as well.

I noticed that M5MaVal was zero for several seconds, so I have added a check that this is >0 when tested for closure.

[RxCape]

Thanks for version 1d Steve. I suppose I should have explicitly stated that I had re-read the user guide in an attempt to better understand the safety features.

I also should have stated that fractal identification appears to work very well. The rate /speed of trading in 4 Ducks is a nice complement to BASA.

Tom

PS: Sorry to report that I had multiple trade opens with immediate closures, resulting in the rogue trade error shortly after implementing version 1d. From my observation, it seems to occur when price is moving quickly. A steady move, spread over time does not seem to trigger the close and rogue trade error. Not sure that observation helps in identifying the reason in the code, but I hope it helps.

[Elixe]

You can have theses rogues trades if price move very quickly from the trigger back to the MA60 on M5 (in the minute after opening the trade).
I had some yesterday that looked like this, maybe adding some spare room around the MA60 would reduce this (opposite fractal to leave breathing room maybe ?).

[SteveHopwood]

Here is a version of 1d that has the trade-closure on recross of the M5 MA removed, so we are simply relying on the stop loss.

We will know the problem lies elsewhere if the behaviour continues. Tommaso made a suggestion in a pm that I am going to investigate.

[SpiderX]

Hi,

Is this EA working fine for anyone ?
My demo still shut down from rogue trade warning.

Cheers