Pitbul: Brian's strategy automated
-
garyfritz
Re: Pitbul: Brian's strategy automated
I think he means his local time is GMT+1 and he's set the morning/evening hours to 8-19. I'm at GMT-6 so I should set the hours to 1-12? (The CheckTradingTimes() function calls TimeLocal(), which uses your computer's local time, NOT your crim's time.)
-
jb68
- Trader
- Posts: 71
- Joined: Mon Jan 30, 2012 11:30 pm
Re: Pitbul: Brian's strategy automated
This is what I'm wondering too.garyfritz wrote:I think he means his local time is GMT+1 and he's set the morning/evening hours to 8-19. I'm at GMT-6 so I should set the hours to 1-12? (The CheckTradingTimes() function calls TimeLocal(), which uses your computer's local time, NOT your crim's time.)
Using SL and morning reference will transform Pitbul strategy in a completely different beast trading fastest moving pairs for that day.
We might be onto something.
BTW, for my testing pitbul the black swan has come yesterday and all pair are now into DD. I did watch it going out of DD several times. It is possibile having an SL to flush the system..
-
garyfritz
Re: Pitbul: Brian's strategy automated
OK, I kept getting the "order send failed with error (0): no error." I found a mistake in the SendSingleTrade() code.
If the CrimIsECN code hits a problem setting SL or TP, it gets the error info (err=GetLastError();) and prints the error. But if OrderSend() fails, for ECN or non-ECN, it never calls err=GetLastError() before it drops into the "if (ticket < 0)" error-handling code. err is 0 so you get the "no error" message.
I added "err=GetLastError()" just before the print/alert code, and that produced proper errors.
The error, it turns out, was "invalid stops." I thought maybe the SL/TP were "points," and I had to multiply by 10 for my 5-digit crim. But that didn't help.
Anybody? What's causing this "invalid stops" error?
In the meantime I set CriminalIsECN = True so it doesn't try to set the stops in the OrderSend(), and that's working.
If the CrimIsECN code hits a problem setting SL or TP, it gets the error info (err=GetLastError();) and prints the error. But if OrderSend() fails, for ECN or non-ECN, it never calls err=GetLastError() before it drops into the "if (ticket < 0)" error-handling code. err is 0 so you get the "no error" message.
I added "err=GetLastError()" just before the print/alert code, and that produced proper errors.
The error, it turns out, was "invalid stops." I thought maybe the SL/TP were "points," and I had to multiply by 10 for my 5-digit crim. But that didn't help.
Anybody? What's causing this "invalid stops" error?
In the meantime I set CriminalIsECN = True so it doesn't try to set the stops in the OrderSend(), and that's working.
-
597743
- Posts: 6
- Joined: Thu Dec 01, 2011 4:29 pm
Re: Pitbul: Brian's strategy automated
Marcello,MarcelloT wrote:automatically, without intervention ...
EA game 8-19 GMT +1
Settings on the previous pages + previous story
Maciej
Thanks for the settings, will give it a try
Roberto
- MarcelloT
- Trader
- Posts: 39
- Joined: Wed Nov 16, 2011 12:23 pm
- Location: POLAND
Re: Pitbul: Brian's strategy automated
Please find enclosed today's result + set ....
Do not know if this is important, but EA is working on H1 chart
Do not know if this is important, but EA is working on H1 chart
You do not have the required permissions to view the files attached to this post.
-
garyfritz
Re: Pitbul: Brian's strategy automated
Thanks for the update and the set file, Maciej! I will try it -- modifying the local-time setting, of course. (Actually I'm running it 24h, and I'll analyze performance vs. time of day later.)
I hope your set file works better than what I'm doing. I don't know what I did wrong but it hasn't been placing any trades at all. EDIT: Hm. I switched it to H1 and it instantly opened 4 positions, and I hadn't loaded the set file yet!
I hope your set file works better than what I'm doing. I don't know what I did wrong but it hasn't been placing any trades at all. EDIT: Hm. I switched it to H1 and it instantly opened 4 positions, and I hadn't loaded the set file yet!
- MarcelloT
- Trader
- Posts: 39
- Joined: Wed Nov 16, 2011 12:23 pm
- Location: POLAND
Re: Pitbul: Brian's strategy automated
8-19: GMT +1 = POLAND this is my time in running the EA
-
garyfritz
Re: Pitbul: Brian's strategy automated
I must be doing something wrong. Maciej, I'm using your set file, except I set the Lot size to 0.1 and I set the trading time to 24H. (I wanted it to trade all day long and then I would analyze the behavior later.)
I started it 9 hours ago, at 21:17 GMT+3. It instantly opened 4 trades, then 20 minutes later it opened one more. Then it did nothing for the next 8.5 hours, until a few minutes ago, when it opened a 5th trade. It hasn't closed any trades yet.
Currently it's at -54 pips. That doesn't look anything like your results!
Maybe the market just isn't cooperating. In all the trades that opened 8-9 hrs ago, the market immediately reversed. Not enough to hit the SL but it never hit the TP either. Maybe the system would be more active if any pairs hit the TP? That's sort of what your system report looks like.
But I'm VERY confused by your latest system report. Look at the first 5 trades, in USDCHF. All of them win 11.8 or 12.0 pips. Trading 5 standard lots, they should be making CHF 590 or 600. But the 4th and 5th trades make CHF 230 and 130 !?!?
Same with all the xxxUSD trades. They all make about 12 pips, which should make about $600 or about CHF 550. But the reported profit ranges from CHF 617 down to CHF 46 !?
I started it 9 hours ago, at 21:17 GMT+3. It instantly opened 4 trades, then 20 minutes later it opened one more. Then it did nothing for the next 8.5 hours, until a few minutes ago, when it opened a 5th trade. It hasn't closed any trades yet.
Currently it's at -54 pips. That doesn't look anything like your results!
Maybe the market just isn't cooperating. In all the trades that opened 8-9 hrs ago, the market immediately reversed. Not enough to hit the SL but it never hit the TP either. Maybe the system would be more active if any pairs hit the TP? That's sort of what your system report looks like.
But I'm VERY confused by your latest system report. Look at the first 5 trades, in USDCHF. All of them win 11.8 or 12.0 pips. Trading 5 standard lots, they should be making CHF 590 or 600. But the 4th and 5th trades make CHF 230 and 130 !?!?
Same with all the xxxUSD trades. They all make about 12 pips, which should make about $600 or about CHF 550. But the reported profit ranges from CHF 617 down to CHF 46 !?
-
blahn
- Trader
- Posts: 53
- Joined: Wed Nov 30, 2011 2:39 am
Re: Pitbul: Brian's strategy automated
Similar problems. mine is opening 4 or 5 trades, then after it closes them never opens more. maybe it's a bug in using absolute time or with using 24h trading..
-
garyfritz
Re: Pitbul: Brian's strategy automated
Mine's not doing that. It's opened and closed 31 trades with a total of 29 pips profit, and it has 6 open trades (all opened in the last 4 hours) with -95 pips loss.
So it's trading OK. It's just not making any money. I haven't figured out Maciej's magic secret yet.
He says he's only trading 8-19 GMT+1. My crim is at GMT+3 so that would be 10-21 for me. If I look only at the trades entered in that window, my closed profits increase from 28 to 41. My open losses would still be there.
In reality, though, his one-month system report shows entries from 5:57 to 23:00, crim time. In his report the profits were distributed so:
< 06:00 5 trades, CHF 1129 profit (all entered on 3/12)
06-07 48, 13098
07-08 88, 25632
08-09 95, 31610
09-10 99, 36701
10-11 54, 21711
11-12 45, 14373
12-13 67, 15893
13-14 63, 20092
14-15 65, 21385
15-16 75, 20553
16-17 75, 31357
17-18 42, 8514
18-19 44, 11130
19-20 30, 5334
20-21 18, 7319
21-22 33, 8399 (includes 2 trades stamped 23:00)
So he got profits in all hours, though it dropped off a lot after 17:00 crim time. Most of the dropoff is due to "fewer trades," though. The profit-per-trade is reasonably consistent all day long.
I would really love to figure out what Maciej is doing differently. He's seeing very different results than I am!
So it's trading OK. It's just not making any money. I haven't figured out Maciej's magic secret yet.
He says he's only trading 8-19 GMT+1. My crim is at GMT+3 so that would be 10-21 for me. If I look only at the trades entered in that window, my closed profits increase from 28 to 41. My open losses would still be there.
In reality, though, his one-month system report shows entries from 5:57 to 23:00, crim time. In his report the profits were distributed so:
< 06:00 5 trades, CHF 1129 profit (all entered on 3/12)
06-07 48, 13098
07-08 88, 25632
08-09 95, 31610
09-10 99, 36701
10-11 54, 21711
11-12 45, 14373
12-13 67, 15893
13-14 63, 20092
14-15 65, 21385
15-16 75, 20553
16-17 75, 31357
17-18 42, 8514
18-19 44, 11130
19-20 30, 5334
20-21 18, 7319
21-22 33, 8399 (includes 2 trades stamped 23:00)
So he got profits in all hours, though it dropped off a lot after 17:00 crim time. Most of the dropoff is due to "fewer trades," though. The profit-per-trade is reasonably consistent all day long.
I would really love to figure out what Maciej is doing differently. He's seeing very different results than I am!