Once Upon A Timeframe

Haggadah · Post by **Haggadah** » Tue Jul 15, 2014 11:20 am

Radar,

The attached pic I am posting shows that the EA is closing trades very early. Is there an option to turn on and off the Take Profit portion of the EA. I would prepare closing profitable trades manually.

Thank you,

Haggadah

Post by **Radar** » Tue Jul 15, 2014 11:38 am

Hey Haggedah,

Haggadah » Tue Jul 15, 2014 8:50 pm wrote:Radar,

The attached pic I am posting shows that the EA is closing trades very early. Is there an option to turn on and off the Take Profit portion of the EA. I would prepare closing profitable trades manually.

Thank you,

Haggadah

If you don't want to use a TakeProfit, set both "D1_CashProfitTarget" and "D1_CashProfitTargetPerTrade" to zero.

The trades in your pic all closed at the correct time, though, (they were open for 8 hours, which is what you have for your current settings (Open trades at 08:00, close them at 16:00 your Local time (15:00 to 23:00 Broker time)). If you want your trades to stay open longer, change your settings

Have fun!

Radar =8^)

Haggadah · Post by **Haggadah** » Tue Jul 15, 2014 12:17 pm

Radar » Tue Jul 15, 2014 11:38 am wrote:Hey Haggedah,

If you don't want to use a TakeProfit, set both "D1_CashProfitTarget" and "D1_CashProfitTargetPerTrade" to zero.

The trades in your pic all closed at the correct time, though, (they were open for 8 hours, which is what you have for your current settings (Open trades at 08:00, close them at 16:00 your Local time (15:00 to 23:00 Broker time)). If you want your trades to stay open longer, change your settings

Have fun!

Radar =8^)

Radar,

Thank you. Now I am getting an idea how the EA works. Will update you of any progress in my demo.

Cheers,

Haggadah

Post by **SteveHopwood** » Wed Jul 16, 2014 11:07 am

Lots of 'invalid stops' errors when trying to move the SL to breakeven, Radar, so I had a look at the code and saw the cause straight away.

You have used 'Digits' instead of 'digits' in lines:
598
603
1375
1386
1448/9
1464/2

If you have done fresh work on the code and the line numbers are incorrect now, just do a 'Match case' search for 'Digits'.

Post by **Radar** » Wed Jul 16, 2014 9:07 pm

SteveHopwood » Wed Jul 16, 2014 8:37 pm wrote:Lots of 'invalid stops' errors when trying to move the SL to breakeven, Radar, so I had a look at the code and saw the cause straight away.

You have used 'Digits' instead of 'digits' in lines:
598
603
1375
1386
1448/9
1464/2

If you have done fresh work on the code and the line numbers are incorrect now, just do a 'Match case' search for 'Digits'.

Thanks, Steve

Fixed EA in post 2.

Have fun!

Radar =8^)

Post by **remix919** » Fri Jul 18, 2014 4:11 pm

Hey, just want to confirm, this is a basket trader EA so I can just put it on 1 EURUSD Daily chart and that's it right?

Post by **Radar** » Fri Jul 18, 2014 11:13 pm

remix919 » Sat Jul 19, 2014 1:41 am wrote:Hey, just want to confirm, this is a basket trader EA so I can just put it on 1 EURUSD Daily chart and that's it right?

Yep, Remix, it's a basket case

No, wait, that's me!

Put it on a single chart, unless you find that some symbols have a better set of start/stop times.

Have fun!

Radar =8^)

Post by **currymonster** » Mon Jul 21, 2014 9:45 pm

Thanks guys have set up a demo. Will let it run and see how it does, thanks Radar and Steve

Post by **currymonster** » Mon Jul 21, 2014 10:33 pm

Think Steve will tazer me for asking, but the EA on a GP demo eur usd D1 chart comes up with in the EA tab
2014.07.21 23:17:40.199 Once a Day basket trader v1_d with MTFTM EURUSD.G,Daily: uninit reason 8
2014.07.21 23:17:40.199 Once a Day basket trader v1_d with MTFTM EURUSD.G,Daily: initialization failed (-1)

So looking at the reason codes on Empty4........

Constant
Value
Description
REASON_PROGRAM
0
Expert Advisor terminated its operation by calling the ExpertRemove() function
REASON_REMOVE
1
Program has been deleted from the chart
REASON_RECOMPILE
2
Program has been recompiled
REASON_CHARTCHANGE
3
Symbol or chart period has been changed
REASON_CHARTCLOSE
4
Chart has been closed
REASON_PARAMETERS
5
Input parameters have been changed by a user
REASON_ACCOUNT
6
Another account has been activated or reconnection to the trade server has occurred due to changes in the account settings
REASON_TEMPLATE
7
A new template has been applied
REASON_INITFAILED
8
This value means that OnInit() handler has returned a nonzero value
REASON_CLOSE
9
Terminal has been closed

the reason 8 code means nowt to me I'm afraid as a dumkopf non coder - I deserve flaming, but anyone help me out as to a possible cause?

Many thanks and apologees Steve!

Post by **SteveHopwood** » Mon Jul 21, 2014 11:15 pm

currymonster » Mon Jul 21, 2014 10:33 pm wrote:Think Steve will tazer me for asking, but the EA on a GP demo eur usd D1 chart comes up with in the EA tab

etc

Many thanks and apologees Steve!

Well, leaving aside the fact that I do not tazer my old buddies from Way Back When, this isn't my thread.

Doesn't mean you haven't balsed something up, just that I neither have to worry about it nor tazer you for it.