Symphonie EA

[slowkey]

Hi Steve, all and Eval,

i noticed this part of the code for Option 1;

//Exit Strategy 1: Close the trade on an opposite direction Extreme spike
if (UseExitStrategy1)
{
if (HtfMajorCycleSell > 0 && HtfExCandleCount >= 2)
{
CloseThisTrade = true;
}//if (HtfMajorCycleSell > 0)
if (LowerTimeFrame > 0)
{
if (LtfMajorCycleSell > 0 && LtfExCandleCount >= 2)
{
CloseThisTrade = true;
}//if (HtfMajorCycleSell > 0)
}//if (LowerTimeFrame > 0)
}//if (UseExitStrategy1)


in this code, you are waiting for both the TF5 AND the TF60 to be the same before CLOSING the position. i think this might be very bad to the position and explains why the EA does'nt get out of a losing position sometimes.
please can you throw some light on this Eval. I would think 5M at candle close if i got the POST 1 thingy right.

also, does the CODE wait for the candle to close, and if it does, i can't find which TF it waits for to close.
sorry, my in-experience kicking in here.

ps: PLS ignore the "2" for the candle count, its just me messing with the bars, Standard setting as per Steve is "4". Sorry Eval, i'm not intentionally breaking the rules, it's just testing again. i got other charts on other Empty4 installs running the '3 and 4 bar rule. this one happens to be the 2 bar rule Empty4.

regards
cuzgeorge

George I think you are looking at older code but my understanding would be that the trade closes based on the extreme spike on just the lower time frame but I am still wading through the last updated code. To make it more clear the new code changes it to 4 bars.

[cuzgeorge]

Hi Slowkey, it's right at the bottom, just before the end. i also messed a bit with the RSI settings and i'm trying 8 and 9, instead of 20. and the 55, and 45 are now 67 and 33. Just for testing.
i'm pretty sure i used the new EA version, i downloaded Steve's fix this evening/morning now, and installed already across the platforms,

setting charts up now,
regards
george

[slowkey]

George the newest code solves the bar issue

//Buy trades
if (OrderType() == OP_BUY)
{
//Exit Strategy 1: Close the trade on an opposite direction Extreme spike
if (UseExitStrategy1)
{
if (HtfMajorCycleSell > 0 && HtfExCandleCount >= 4)
{
CloseThisTrade = true;
}//if (HtfMajorCycleSell > 0)
if (LowerTimeFrame > 0)
{
if (LtfMajorCycleSell > 0 && LtfExCandleCount >= 4)
{
CloseThisTrade = true;
}//if (HtfMajorCycleSell > 0)
}//if (LowerTimeFrame > 0)
}//if (UseExitStrategy1)

Now I have not looked at a code enough to say that Steve is not exiting just on the lower time frame extreme spike. However to look at this I agree it looks as if both signals are used. I am a code hacker and not much of a coder LOL.

[cuzgeorge]

George the newest code solves the bar issue

//Buy trades
if (OrderType() == OP_BUY)
{
//Exit Strategy 1: Close the trade on an opposite direction Extreme spike
if (UseExitStrategy1)
{
if (HtfMajorCycleSell > 0 && HtfExCandleCount >= 4)
{
CloseThisTrade = true;
}//if (HtfMajorCycleSell > 0)
if (LowerTimeFrame > 0)
{
if (LtfMajorCycleSell > 0 && LtfExCandleCount >= 4)
{
CloseThisTrade = true;
}//if (HtfMajorCycleSell > 0)
}//if (LowerTimeFrame > 0)
}//if (UseExitStrategy1)

Now I have not looked at a code enough to say that Steve is not exiting just on the lower time frame extreme spike. However to look at this I agree it looks as if both signals are used. I am a code hacker and not much of a coder LOL.

Thanks Slowkey for confirming with me.
i was a bit concerned there for a while, buy lets see what Steve thinks, or if Eval is happy with that setup. Eval's got his hands full on the other side, (FF), the dark side, but i'm sure he'll get back to us with what he thinks.

i'm also setting up a chart in honour of you , using the slowkey method, hehe,
regards
george

[slowkey]

George the newest code solves the bar issue

//Buy trades
if (OrderType() == OP_BUY)
{
//Exit Strategy 1: Close the trade on an opposite direction Extreme spike
if (UseExitStrategy1)
{
if (HtfMajorCycleSell > 0 && HtfExCandleCount >= 4)
{
CloseThisTrade = true;
}//if (HtfMajorCycleSell > 0)
if (LowerTimeFrame > 0)
{
if (LtfMajorCycleSell > 0 && LtfExCandleCount >= 4)
{
CloseThisTrade = true;
}//if (HtfMajorCycleSell > 0)
}//if (LowerTimeFrame > 0)
}//if (UseExitStrategy1)

Now I have not looked at a code enough to say that Steve is not exiting just on the lower time frame extreme spike. However to look at this I agree it looks as if both signals are used. I am a code hacker and not much of a coder LOL.

Thanks Slowkey for confirming with me.
i was a bit concerned there for a while, buy lets see what Steve thinks, or if Eval is happy with that setup. Eval's got his hands full on the other side, (FF), the dark side, but i'm sure he'll get back to us with what he thinks.

i'm also setting up a chart in honour of you , using the slowkey method, hehe,
regards
george

George why I say I need to go back and read this through carefully is that Steve has a lot of lines commented out here. I have not had enough time to digest this section in context of the whole.

[SteveHopwood]

in this code, you are waiting for both the TF5 AND the TF60 to be the same before CLOSING the position. i think this might be very bad to the position and explains why the EA does'nt get out of a losing position sometimes.

Code: Select all

      if (UseExitStrategy1)
      {
         if (HtfMajorCycleSell > 0 && HtfExCandleCount >= 4)
         {
            CloseThisTrade = true;
         }//if (HtfMajorCycleSell > 0)

         if (LowerTimeFrame > 0)
         {
            if (LtfMajorCycleSell > 0 && LtfExCandleCount >= 4)
            {
               CloseThisTrade = true;
            }//if (HtfMajorCycleSell > 0)         
         }//if (LowerTimeFrame > 0)         
      }//if (UseExitStrategy1)

Here is the code with the formatting retained; we do this by highlighting the code snippet and clicking the Code button - makes it all much easier to read.

Notice how the higher and lower time frame checks have their own conditional? They are separate from one another, so the ltf can also close the trade.

Strictly speaking. the htf check should have an additional time check - no point in running the test every 5 minutes when the conditions it tests can only change once an hour. I shall add this to help reduce processor use.

also, does the CODE wait for the candle to close, and if it does, i can't find which TF it waits for to close.
sorry, my in-experience kicking in here.

When a number of functions are only required at the opening of a new candle, it is less typing to use the new-candle detection at the function calls rather than within the function. Go to the end of the file, to the 'Trading' section; there you will see the iTime conditionals that tell S when to call the functions that read the indi's, look at exit strategies and look for trading opps.

[MurphyMan]

How do we get rid of those ding dang alerts that keep popping up? i.e. EURUSD M5: MAJOR Cycle Top Disappeared at 14:15

I changed ShowManagementAlerts to FALSE, but no joy.

I'm sure it's something simple.

[cuzgeorge]

How do we get rid of those ding dang alerts that keep popping up? i.e. EURUSD M5: MAJOR Cycle Top Disappeared at 14:15

I changed ShowManagementAlerts to FALSE, but no joy.

I'm sure it's something simple.

Hi Murphy, i am also pestered by them and found that they have a setting in the inputs of the indikators, and the signaller , if you using it, but i have turned them all to false and i still get them, not as much, but they still come up.

i know the remaining ones are in the code of the add-ons, thingies , and there were two in the actual EA, that Steve has kept internal,
here is the one

Code: Select all

bool      MinorAlert = false;
bool      MajorAlert = false;
bool      MajorGoneAlert = false; // alerts if a recent major extreme peaks disappears. this is to facilitate fast reentry
bool      SoundAlert = false;
bool      EmailAlert = false;
extern bool    TrackMajorCycleHistory = true;
extern bool    WaitForClose = true;
extern int     MajorGoneLookBackBars = 40; // max amount of lookback bars to check if a recent spike disappears
string    note1 = "alert all = 0, none = 4", //eh added comment for 4. but leave on 0
          note2 = "buy only = 1, sell only = 2";
int       alertsOption = 0;

These are the ones i know of in the code.
they also appear in the cycle identifier, exactly the same, turn them all to false and the '4' at the end for 'none'

i have done the above to all indis and the EA and i still get them, so if you find the others, please let me know?
thanks
cuzgeorge

[SteveHopwood]

How do we get rid of those ding dang alerts that keep popping up? i.e. EURUSD M5: MAJOR Cycle Top Disappeared at 14:15

I changed ShowManagementAlerts to FALSE, but no joy.

I'm sure it's something simple.

There is an input in the indi, alertsOption, that is intended to disable all alerts if set to 4, and it looks as though the coder has attempted to ensure that the code complied with your setting.

If this does not work, go through the code and comment out every line that contains the keyword 'Alert' then recompile. This should stop the alerts.

[jjasper7]

Steve,
if it is of concern to you, i have tried to download your Shell EA from post 1...

"My shell EA – the code I use to produce EA's so quickly. viewtopic.php?f=5&t=15"

and continually get a "The requested topic does not exist" error code. I suspect a typo in the instruction. Would someone please confirm the link fails, or suggest how to download correctly?