Neither the demo accounts nor the live one traded NY today. I realised why when I looked at the code. I had it checking the hour part of the trade before reaching Ben's day/month/year checks. You will have had trades if you only had today in your history tab.
Fixed in post 1.
Easiest DIY in the world. Do a search for: /*We have pivotter (Ben) to thank
Move the code block to underneath betterOrderSelect block. The function will look like this:
Code: Select all
bool testForAlreadyTradedThisHour()
{
//The function returns 'true' if it finds an order that opened
//or closed during the hour, else returns 'false'
if (OrdersHistoryTotal() == 0)
return(false);
int hourBroker = TimeHour(TimeCurrent() );
for (int cc = OrdersHistoryTotal() - 1; cc >= 0; cc--)
{
if (!BetterOrderSelect(cc, SELECT_BY_POS, MODE_HISTORY) )
continue;//Shouldn't happen, but no harm in making sure
/*We have pivotter (Ben) to thank for spotting why Scalpy sould stop
trading altogether. Go to https://www.stevehopwoodforex.com/phpBB3/viewtopic.php?p=174598#p174598
to read his post.
Ben also supplied the code. Break out of the loop as soon
as we find an order that was not sent today - broker time
*/
if (TimeDay(OrderOpenTime()) != TimeDay(TimeCurrent())) break;
if (TimeMonth(OrderOpenTime()) != TimeMonth(TimeCurrent())) break;
if (TimeYear(OrderOpenTime()) != TimeYear(TimeCurrent())) break;
//Did the order open during the current hour?
int openHour = TimeHour(OrderOpenTime() );
if (openHour == hourBroker)
return(true);//Yes, so already traded this hour
//Did the order close during the current hour?
int closeHour = TimeHour(OrderCloseTime() );
if (closeHour == hourBroker)
return(true);//Yes, so no more trading until a new H1 candle forms.
}//for (int cc = OrdersHistoryTotal() - 1; cc >= 0; cc--)
//Reached here, so OK to trade
return(false);
}//End bool testForAlreadyTradedThisHour()
