Help Coding with iCustom(PinBar)

[fx800]

Hi
I am attempting to code an ea using a Pin Bar indicator using Steve's shell ea. The code is shown below. I would be very grateful if one of our expert coders could have a look and see if it is correct.

Thanks in advance.
peter

Code: Select all

         static datetime OldPBBarTime;
         if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))
         {
            OldPBBarTime=iTime(Symbol(),TradingTimeFrame,0); 
                
	         PBStatus = PBnosignal;
	          
         //Buffer 0 holds a buy pin bar - green up
         val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 1);
         if (!CloseEnough(val, EMPTY_VALUE) )
         {
            PBStatus = PBbuysignal;
         }//if (!CloseEnough(val 0) )         
         else
         {
            //Buffer 1 hods a sell pin bar -  red down
            val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 1, 1);
            if (!CloseEnough(val, EMPTY_VALUE) )
            {
               PBStatus = PBsellsignal;
            }//if (!CloseEnough(val 0) )
         }
         }//if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))

[SteveHopwood]

Hi
I am attempting to code an ea using a Pin Bar indicator using Steve's shell ea. The code is shown below. I would be very grateful if one of our expert coders could have a look and see if it is correct.

Thanks in advance.
peter

Code: Select all

         static datetime OldPBBarTime;
         if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))
         {
            OldPBBarTime=iTime(Symbol(),TradingTimeFrame,0); 
                
	         PBStatus = PBnosignal;
	          
         //Buffer 0 holds a buy pin bar - green up
         val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 1);
         if (!CloseEnough(val, EMPTY_VALUE) )
         {
            PBStatus = PBbuysignal;
         }//if (!CloseEnough(val 0) )         
         else
         {
            //Buffer 1 hods a sell pin bar -  red down
            val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 1, 1);
            if (!CloseEnough(val, EMPTY_VALUE) )
            {
               PBStatus = PBsellsignal;
            }//if (!CloseEnough(val 0) )
         }
         }//if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))

Looks good to me. The only thing is to check that the indi returns EMPTY_VALUE which is a mahossive integer and not a double, which will be 0.

To test, change the shift to a value you know did not generate a pinbar signal then, after val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, SomeShift); add this:
Alert(val); This will show whether the indi is returning 0 or EMPTY_VALUE when there is no signal.

I do this with every CCA I use when coding EA's.

Brilliant to see you getting your hands dirty.

[fx800]

Hi
I am attempting to code an ea using a Pin Bar indicator using Steve's shell ea. The code is shown below. I would be very grateful if one of our expert coders could have a look and see if it is correct.

Thanks in advance.
peter

Code: Select all

         static datetime OldPBBarTime;
         if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))
         {
            OldPBBarTime=iTime(Symbol(),TradingTimeFrame,0); 
                
	         PBStatus = PBnosignal;
	          
         //Buffer 0 holds a buy pin bar - green up
         val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 1);
         if (!CloseEnough(val, EMPTY_VALUE) )
         {
            PBStatus = PBbuysignal;
         }//if (!CloseEnough(val 0) )         
         else
         {
            //Buffer 1 hods a sell pin bar -  red down
            val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 1, 1);
            if (!CloseEnough(val, EMPTY_VALUE) )
            {
               PBStatus = PBsellsignal;
            }//if (!CloseEnough(val 0) )
         }
         }//if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))

Looks good to me. The only thing is to check that the indi returns EMPTY_VALUE which is a mahossive integer and not a double, which will be 0.

To test, change the shift to a value you know did not generate a pinbar signal then, after val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, SomeShift); add this:
Alert(val); This will show whether the indi is returning 0 or EMPTY_VALUE when there is no signal.

I do this with every CCA I use when coding EA's.

Brilliant to see you getting your hands dirty.

Thank you very much Steve. Will try the test as you have suggest.

peter

[fx800]

Good morning.

I carried out the test as Steve suggested and the test returned the number 2147483647 which is the default value for EMPTY_VALUE. So I guess the code snippet for the indi should work ok.

I have attached the ea to M15 charts and wait to see if it works.

peter

[SteveHopwood]

Good morning.

I carried out the test as Steve suggested and the test returned the number 2147483647 which is the default value for EMPTY_VALUE. So I guess the code snippet for the indi should work ok.

I have attached the ea to M15 charts and wait to see if it works.

peter

Please let us know Peter, for a round of applause.

[fx800]

Still patiently waiting for a trade.

The ea is an exercise in attempting to code an ea to test a theory. I have added SHI CHANNEL and SUPERSLOPE, a copy and paste job using code snippets from Steve's ea's. It is attached below in case someone would like to take a peek at it.

peter

p.s. in case you are wondering, SHS stands for SteveHopwood Shell ea.

[fx800]

The previous code did not work. Will the following one work ?

Code: Select all

void LookForPinbar()
{

   //Sets PbStatus
   PbStatus = pinbarnone;

   //Sell pinbar in buffer 1 - red arrow
   double v = iCustom(Symbol(), TradingTimeFrame, "PinBar", 1, 1);
   
   if (v != EMPTY_VALUE)
   {
      PbStatus = pinbarhigh;
      return;
   }//if (v != EMPTY_VALUE)
   

   //Buy pinbar in buffer 0 - green arrow
   v = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 1);

   if (v != EMPTY_VALUE)
   {
      PbStatus = pinbarlow;
      return;
   }//if (v != EMPTY_VALUE)
   
}//void LookForPinbar()

[SteveHopwood]

The previous code did not work. Will the following one work ?

Code: Select all

void LookForPinbar()
{

   //Sets PbStatus
   PbStatus = pinbarnone;

   //Sell pinbar in buffer 1 - red arrow
   double v = iCustom(Symbol(), TradingTimeFrame, "PinBar", 1, 1);
   
   if (v != EMPTY_VALUE)
   {
      PbStatus = pinbarhigh;
      return;
   }//if (v != EMPTY_VALUE)
   

   //Buy pinbar in buffer 0 - green arrow
   v = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 1);

   if (v != EMPTY_VALUE)
   {
      PbStatus = pinbarlow;
      return;
   }//if (v != EMPTY_VALUE)
   
}//void LookForPinbar()

I have time on my hands this week. Upload the indi and I will see what is wrong with your code.

[fx800]

Thank you very much Steve.

peter

[SteveHopwood]

I loaded your code into a script and set the iCustom shift to a bar that has an arrow and it returned the price correctly, so yours should set your PbStatus OK.

Use the bool CloseEnough(double num1,double num2) function though when testing the value of v because it is a double and might be holding 2147483647.00000001 rather than 2147483647.

I just had a look at your EA code and see you using CloseEnough() there. I see you have declared:
static datetime OldPBBarTime;

Try assigning it a zero value i.e.
static datetime OldPBBarTime = 0;

Apart from that, try adapting shift to address a candle you know has a signal. For example, there is a green arrow 4 candles back, so the call would be:
v = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 4);
Alert(v);

to show the value of the return from the indi.