fx800 » Thu Feb 08, 2018 1:50 pm wrote:Hi
I am attempting to code an ea using a Pin Bar indicator using Steve's shell ea. The code is shown below. I would be very grateful if one of our expert coders could have a look and see if it is correct.

Thanks in advance.
peter

Code: Select all

         static datetime OldPBBarTime;
         if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))
         {
            OldPBBarTime=iTime(Symbol(),TradingTimeFrame,0); 
                
	         PBStatus = PBnosignal;
	          
         //Buffer 0 holds a buy pin bar - green up
         val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 1);
         if (!CloseEnough(val, EMPTY_VALUE) )
         {
            PBStatus = PBbuysignal;
         }//if (!CloseEnough(val 0) )         
         else
         {
            //Buffer 1 hods a sell pin bar -  red down
            val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 1, 1);
            if (!CloseEnough(val, EMPTY_VALUE) )
            {
               PBStatus = PBsellsignal;
            }//if (!CloseEnough(val 0) )
         }
         }//if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))

SteveHopwood » Thu Feb 08, 2018 5:54 pm wrote:

fx800 » Thu Feb 08, 2018 1:50 pm wrote:Hi
I am attempting to code an ea using a Pin Bar indicator using Steve's shell ea. The code is shown below. I would be very grateful if one of our expert coders could have a look and see if it is correct.

Thanks in advance.
peter

Code: Select all

         static datetime OldPBBarTime;
         if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))
         {
            OldPBBarTime=iTime(Symbol(),TradingTimeFrame,0); 
                
	         PBStatus = PBnosignal;
	          
         //Buffer 0 holds a buy pin bar - green up
         val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 1);
         if (!CloseEnough(val, EMPTY_VALUE) )
         {
            PBStatus = PBbuysignal;
         }//if (!CloseEnough(val 0) )         
         else
         {
            //Buffer 1 hods a sell pin bar -  red down
            val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 1, 1);
            if (!CloseEnough(val, EMPTY_VALUE) )
            {
               PBStatus = PBsellsignal;
            }//if (!CloseEnough(val 0) )
         }
         }//if(OldPBBarTime!=iTime(Symbol(),TradingTimeFrame,0))

Looks good to me. The only thing is to check that the indi returns EMPTY_VALUE which is a mahossive integer and not a double, which will be 0.

To test, change the shift to a value you know did not generate a pinbar signal then, after val = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, SomeShift); add this:
Alert(val); This will show whether the indi is returning 0 or EMPTY_VALUE when there is no signal.

I do this with every CCA I use when coding EA's.

Brilliant to see you getting your hands dirty.

fx800 » Fri Feb 09, 2018 7:25 am wrote:Good morning.

I carried out the test as Steve suggested and the test returned the number 2147483647 which is the default value for EMPTY_VALUE. So I guess the code snippet for the indi should work ok.

I have attached the ea to M15 charts and wait to see if it works.

peter

fx800 » Sun Feb 11, 2018 6:30 am wrote:The previous code did not work. Will the following one work ?

Code: Select all

void LookForPinbar()
{

   //Sets PbStatus
   PbStatus = pinbarnone;

   //Sell pinbar in buffer 1 - red arrow
   double v = iCustom(Symbol(), TradingTimeFrame, "PinBar", 1, 1);
   
   if (v != EMPTY_VALUE)
   {
      PbStatus = pinbarhigh;
      return;
   }//if (v != EMPTY_VALUE)
   

   //Buy pinbar in buffer 0 - green arrow
   v = iCustom(Symbol(), TradingTimeFrame, "PinBar", 0, 1);

   if (v != EMPTY_VALUE)
   {
      PbStatus = pinbarlow;
      return;
   }//if (v != EMPTY_VALUE)
   
}//void LookForPinbar()